[00:10:10] (03Merged) 10jenkins-bot: Fix monthly convert example [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347680 (https://phabricator.wikimedia.org/T439890) (owner: 10Lars SG) [00:10:28] (03CR) 10CI reject: [V:04-1] Add Relationship Manager and WLS to ZD iframe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347667 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG) [00:29:38] was that Core/menu change supposed to go out with the monthly convert example larssandergreen ? [00:54:09] (03CR) 10Lars SG: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347667 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG) [00:55:07] ejegg: no, it's not a rush I don't think. We've had the problem for a couple months now, it just never came up until I did a cache clear at the wrong time. We'll get it with the new version of Civi next week [00:55:34] thanks for the review cstone [01:10:33] oh it just got committed with https://gerrit.wikimedia.org/r/1347680 [01:21:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team: CI build slow and timing out sometimes - https://phabricator.wikimedia.org/T434024#12387904 (10Lars) Hi folks (@Peter @hashar @Andrew ), our CI tim... [01:22:36] (03PS1) 10Lars SG: Revert core/CRM/Core/Menu.php changes from d104522d17b [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347916 [01:23:04] thanks for noticing that ejegg, ^^ reverts [01:25:17] (03PS1) 10Ejegg: Add lockTSE to banner choice cache options [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1347918 (https://phabricator.wikimedia.org/T439239) [01:26:05] (03CR) 10Ejegg: [C:03+2] Revert core/CRM/Core/Menu.php changes from d104522d17b [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347916 (owner: 10Lars SG) [01:27:37] (03CR) 10Lars SG: [C:03+2] "re +2 for tests" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347667 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG) [01:28:12] (03CR) 10Lars SG: [V:03+2 C:03+2] Add Relationship Manager and WLS to ZD iframe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347667 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG) [01:28:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, and 2 others: CentralNotice must batch campaign mixin lookup & use stampede protection - https://phabricator.wikimedia.org/T439239#12387914 (10Ejegg) I'm not deeply versed in the WanObjectCache... [01:53:03] (03Merged) 10jenkins-bot: Revert core/CRM/Core/Menu.php changes from d104522d17b [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347916 (owner: 10Lars SG) [01:53:47] (03CR) 10Ejegg: "This code looks good, I'm just really annoyed you had to write it! So you had to introduce a new top-level payment_method category of 'ba" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 (https://phabricator.wikimedia.org/T438723) (owner: 10Damilare Adedoyin) [02:04:06] (03CR) 10Ejegg: [C:04-1] "Sorry for the long wait between reviews, Damilare! This just needs the namespaced files moved into the proper directory, and the mediawiki" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 (owner: 10Damilare Adedoyin) [02:06:31] (03PS1) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1347926 [02:06:43] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1347926 (owner: 10Lars SG) [02:07:49] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1347926 (owner: 10Lars SG) [02:13:20] (03CR) 10Ejegg: [C:04-2] "Thank you for this heroic effort, but I think we've got to approach the refactor differently. We certainly want to remove WmfFramework, an" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1271801 (https://phabricator.wikimedia.org/T423456) (owner: 10MGChecker) [02:14:36] (03CR) 10Ejegg: [C:04-2] "In the meantime, I'll extract some of the simpler pieces of this into a standalone patch" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1271801 (https://phabricator.wikimedia.org/T423456) (owner: 10MGChecker) [02:26:23] (03PS1) 10Ejegg: Replace RequestContext::getMain where trivial [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347936 (https://phabricator.wikimedia.org/T423456) [02:27:09] (03CR) 10Ejegg: [C:04-2] "See Ic44bdc4400be67d182cd6e2ed0bb7eaebaf73308 for the replacement of the trivial cases." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1271801 (https://phabricator.wikimedia.org/T423456) (owner: 10MGChecker) [02:27:52] (03CR) 10CI reject: [V:04-1] Replace RequestContext::getMain where trivial [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347936 (https://phabricator.wikimedia.org/T423456) (owner: 10Ejegg) [02:29:19] (03CR) 10Cstone: "@ejegg@ejegg.com it's still being worked on on gravy's side but I think the moto ACH connection (direct mail ACH) will also go through thi" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 (https://phabricator.wikimedia.org/T438723) (owner: 10Damilare Adedoyin) [02:31:13] (03PS2) 10Ejegg: Replace RequestContext::getMain where trivial [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347936 (https://phabricator.wikimedia.org/T423456) [02:33:08] (03CR) 10CI reject: [V:04-1] Replace RequestContext::getMain where trivial [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347936 (https://phabricator.wikimedia.org/T423456) (owner: 10Ejegg) [02:40:44] (03PS1) 10Reedy: SECURITY: Escape system messages in two places [extensions/CentralNotice] (REL1_46) - 10https://gerrit.wikimedia.org/r/1347949 (https://phabricator.wikimedia.org/T432419) [02:40:55] (03PS1) 10Reedy: SECURITY: Escape system messages in two places [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1347950 (https://phabricator.wikimedia.org/T432419) [02:41:06] (03PS1) 10Reedy: SECURITY: Escape system messages in two places [extensions/CentralNotice] (REL1_43) - 10https://gerrit.wikimedia.org/r/1347951 (https://phabricator.wikimedia.org/T432419) [02:45:23] !log civicrm upgraded from 40a4588a to 46fe8864 [02:45:24] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [02:48:45] (03PS3) 10Ejegg: Replace RequestContext::getMain where trivial [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347936 (https://phabricator.wikimedia.org/T423456) [02:56:04] (03CR) 10Reedy: [C:03+2] SECURITY: Escape system messages in two places [extensions/CentralNotice] (REL1_46) - 10https://gerrit.wikimedia.org/r/1347949 (https://phabricator.wikimedia.org/T432419) (owner: 10Reedy) [02:56:08] (03CR) 10Reedy: [C:03+2] SECURITY: Escape system messages in two places [extensions/CentralNotice] (REL1_43) - 10https://gerrit.wikimedia.org/r/1347951 (https://phabricator.wikimedia.org/T432419) (owner: 10Reedy) [02:56:13] (03CR) 10Reedy: [C:03+2] SECURITY: Escape system messages in two places [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1347950 (https://phabricator.wikimedia.org/T432419) (owner: 10Reedy) [02:58:33] (03Merged) 10jenkins-bot: SECURITY: Escape system messages in two places [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1347950 (https://phabricator.wikimedia.org/T432419) (owner: 10Reedy) [02:58:46] (03Merged) 10jenkins-bot: SECURITY: Escape system messages in two places [extensions/CentralNotice] (REL1_46) - 10https://gerrit.wikimedia.org/r/1347949 (https://phabricator.wikimedia.org/T432419) (owner: 10Reedy) [02:59:02] (03Merged) 10jenkins-bot: SECURITY: Escape system messages in two places [extensions/CentralNotice] (REL1_43) - 10https://gerrit.wikimedia.org/r/1347951 (https://phabricator.wikimedia.org/T432419) (owner: 10Reedy) [03:10:17] (03CR) 10Cstone: [C:03+2] "thanks this looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346802 (https://phabricator.wikimedia.org/T438918) (owner: 10Ejegg) [03:13:08] (03Merged) 10jenkins-bot: Employer autocomplete with cdx-lookup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346802 (https://phabricator.wikimedia.org/T438918) (owner: 10Ejegg) [03:26:27] (03CR) 10Cstone: [C:03+2] "this looks good, thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347240 (https://phabricator.wikimedia.org/T438904) (owner: 10Dmiranda) [03:28:05] (03Merged) 10jenkins-bot: Use the country_fields config for the ComboWiki phone field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347240 (https://phabricator.wikimedia.org/T438904) (owner: 10Dmiranda) [03:32:53] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Add in country specific fields - https://phabricator.wikimedia.org/T439938 (10Cstone) 03NEW [04:39:10] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team: CI build slow and timing out sometimes - https://phabricator.wikimedia.org/T434024#12388093 (10Peter) Hi @Lars I checked the job in CI and I think... [04:50:38] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Continuous-Integration-Infrastructure, and 2 others: CI build slow and timing out sometimes - https://phabricator.wikimedia.org/T434024#12388096 (10Peter) A made patch, please have a look that it looks ok. With the d... [06:24:15] (03PS1) 10Dmiranda: Show the Endowment logo on Combowiki when wmf_medium=endowment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348258 (https://phabricator.wikimedia.org/T434233) [06:34:04] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: display endowment with utm_medium=endowment - https://phabricator.wikimedia.org/T434233#12388147 (10dmiranda) Hi @Cstone! The patch for this ticket is ready for review and can be found her... [06:35:30] (03CR) 10CI reject: [V:04-1] build: Updating npm dependencies [extensions/FundraisingTranslateWorkflow] (REL1_43) - 10https://gerrit.wikimedia.org/r/1157359 (owner: 10Libraryupgrader) [07:15:34] (03CR) 10Damilare Adedoyin: "Recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347748 (owner: 10Damilare Adedoyin) [07:29:00] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Add SEPA - https://phabricator.wikimedia.org/T439597#12388255 (10Laurabarluzzi) At standup I mentioned picking up another task but it got worked on already so I'm going to pick this one - I'll report back on Mo... [07:29:30] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Add SEPA - https://phabricator.wikimedia.org/T439597#12388256 (10Laurabarluzzi) a:03Laurabarluzzi [08:49:01] (03CR) 10Tacsipacsi: Replace RequestContext::getMain where trivial (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347936 (https://phabricator.wikimedia.org/T423456) (owner: 10Ejegg) [10:10:15] jgleeson: good morning! Could you resolve the merge conflict of your patch so it gets merged? it was approved [10:10:17] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1346106 [10:13:33] I'm working on the sepa phab and to make my life easier I branched off from your patch since this phab will have to intoduce on top of your logic a "get submethod for these params" ; as it is now sadly it would show SEPA to even the USA etc. So it'd be helpful if we got that merged [10:17:55] (03CR) 10Laurabarluzzi: [C:03+2] Set country value to url parameter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347697 (https://phabricator.wikimedia.org/T439898) (owner: 10Damilare Adedoyin) [10:18:01] (03CR) 10Laurabarluzzi: [C:03+2] Fix eslint warning on combowiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347699 (owner: 10Damilare Adedoyin) [10:19:43] (03Merged) 10jenkins-bot: Set country value to url parameter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347697 (https://phabricator.wikimedia.org/T439898) (owner: 10Damilare Adedoyin) [10:19:46] (03Merged) 10jenkins-bot: Fix eslint warning on combowiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347699 (owner: 10Damilare Adedoyin) [11:03:48] laura|lunch: sure! I'm just finishing up the security updates for MW and then I'll move to that [11:04:07] also good morning! [11:04:14] afternoon now [11:04:15] :D [11:07:30] (03PS1) 10Jgleeson: Merge branch 'REL1_43' into fundraising/REL1_43 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1348587 [11:17:24] (03CR) 10CI reject: [V:04-1] Merge branch 'REL1_43' into fundraising/REL1_43 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1348587 (owner: 10Jgleeson) [11:18:42] 12:17:14 1) MediaWikiServicesTest::testDefaultServiceInstantiation [11:18:42] 12:17:14 InvalidArgumentException: Key "DonationInterfaceLogDebug" not found in input sources [11:20:05] interesting [11:30:57] ok [11:31:09] so apparently that old mw var 'DonationInterfaceLogDebug' now needs a default value [11:33:59] due to it being referred to in our new loggerfactory here https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1347647/6/includes/Configuration/LoggerFactory.php#14 [11:36:46] the mw core test suite does a full test run of all MW services including those registered by extensions (in our case DonationInterface). This happens in tests/phpunit/includes/MediaWikiServicesTest.php:testDefaultServiceInstantiation() [11:37:11] I'll add a default of false [11:40:34] I'm gonna self-merge that to get the security update passing on CI and out [11:43:18] (03PS1) 10Jgleeson: Add missing default for $wgDonationInterfaceLogDebug [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348620 (https://phabricator.wikimedia.org/T434831) [11:44:07] laura|lunch: that flag seems to have always been missing so it's not a gap in your patch [11:44:33] sorry, to be more precise, the default for that flag has always been missing [11:45:43] (03CR) 10Jgleeson: [C:03+2] Add missing default for $wgDonationInterfaceLogDebug [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348620 (https://phabricator.wikimedia.org/T434831) (owner: 10Jgleeson) [11:48:24] (03PS18) 10Damilare Adedoyin: Add Provider for Gravy Adyen direct paybybank connection for ACH/SEPA transactions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 (https://phabricator.wikimedia.org/T438723) [11:51:05] (03Merged) 10jenkins-bot: Add missing default for $wgDonationInterfaceLogDebug [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348620 (https://phabricator.wikimedia.org/T434831) (owner: 10Jgleeson) [11:51:34] (03CR) 10Jgleeson: "recheck" [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1348587 (owner: 10Jgleeson) [11:56:32] ok I've done a little bit of testing after merging the latest from REL1_43 into our branch locally. Payments seem to be working fine. Once that merges, I'll push it out and watch it closely. [11:57:25] (03CR) 10Damilare Adedoyin: "True @ejegg@ejegg.com and @cstone@wikimedia.org, I had to write out this integration in order to have an end to end test to make sure it w" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 (https://phabricator.wikimedia.org/T438723) (owner: 10Damilare Adedoyin) [12:02:14] (03CR) 10Jgleeson: [C:03+2] Merge branch 'REL1_43' into fundraising/REL1_43 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1348587 (owner: 10Jgleeson) [12:05:55] jgleeson: thanks for spotting the flag 👌 [12:11:34] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 3 others: Automate - MGGO appeal update - https://phabricator.wikimedia.org/T406662#12388997 (10RLewis) @Lars and any of the MGFE related appeal codes, we shouldn't overwrite those either but... [12:11:48] (03Merged) 10jenkins-bot: Merge branch 'REL1_43' into fundraising/REL1_43 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1348587 (owner: 10Jgleeson) [12:14:08] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 3 others: Automate some Direct Mail white mail coding - https://phabricator.wikimedia.org/T386031#12389003 (10RLewis) @Lars thank you Lars, I know this has been a bit of an... [12:20:36] !log payments-wiki upgraded from dae59de9 to dac9a1b9 [12:20:38] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [12:24:37] right let get those merge conflcits fixed [12:24:41] (03PS24) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [12:26:25] (03CR) 10CI reject: [V:04-1] Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 (owner: 10Damilare Adedoyin) [12:27:49] (03PS25) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [12:32:08] (03CR) 10Damilare Adedoyin: "Thanks for the CR and suggestions @ejegg@ejegg.com, done!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 (owner: 10Damilare Adedoyin) [12:32:11] (03PS26) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [12:45:30] (03PS27) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [12:45:31] (03PS12) 10Damilare Adedoyin: Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) [12:45:31] (03PS5) 10Damilare Adedoyin: Create API for submit ApplePay and GooglePay on through the Gravy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344317 (https://phabricator.wikimedia.org/T438879) [12:47:12] (03CR) 10CI reject: [V:04-1] Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) (owner: 10Damilare Adedoyin) [12:47:28] (03CR) 10CI reject: [V:04-1] Create API for submit ApplePay and GooglePay on through the Gravy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344317 (https://phabricator.wikimedia.org/T438879) (owner: 10Damilare Adedoyin) [12:55:43] (03PS9) 10Damilare Adedoyin: Add Gravy get payment method API request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1342717 [12:55:48] (03PS10) 10Damilare Adedoyin: Add Gravy get payment method API request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1342717 [12:56:22] (03PS13) 10Damilare Adedoyin: Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) [12:58:28] (03CR) 10CI reject: [V:04-1] Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) (owner: 10Damilare Adedoyin) [12:59:03] (03PS14) 10Damilare Adedoyin: Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) [12:59:16] (03PS11) 10Damilare Adedoyin: Add Gravy get payment method API request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1342717 (https://phabricator.wikimedia.org/T438879) [12:59:22] (03CR) 10CI reject: [V:04-1] Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) (owner: 10Damilare Adedoyin) [13:03:18] (03Abandoned) 10Damilare Adedoyin: Get payment method config and required fields from Gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1151739 (owner: 10Damilare Adedoyin) [13:03:46] (03Abandoned) 10Damilare Adedoyin: (Proposal) Get required fields config from Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1153158 (owner: 10Damilare Adedoyin) [13:03:58] (03PS1) 10Laurabarluzzi: Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) [13:04:37] (03PS6) 10Damilare Adedoyin: Create API for submit ApplePay and GooglePay on through the Gravy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344317 (https://phabricator.wikimedia.org/T438879) [13:05:21] (03CR) 10CI reject: [V:04-1] Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [13:06:39] (03CR) 10CI reject: [V:04-1] Create API for submit ApplePay and GooglePay on through the Gravy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344317 (https://phabricator.wikimedia.org/T438879) (owner: 10Damilare Adedoyin) [13:07:08] (03PS2) 10Laurabarluzzi: Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) [13:09:13] (03CR) 10CI reject: [V:04-1] Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [13:19:08] (03PS3) 10Laurabarluzzi: Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) [13:23:56] (03PS4) 10Laurabarluzzi: Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) [13:34:20] (03PS8) 10Jgleeson: Filter ComboWiki payment methods by country [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346106 (https://phabricator.wikimedia.org/T437508) [13:34:35] that took a lot longer than I'd hoped it would [13:38:31] (03CR) 10Jgleeson: [C:03+2] "reapplying dami's +2" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346106 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson) [13:38:45] ok once that merges laurabar you should be good to go [13:42:56] hi fr-tech! [13:43:00] thanks it wasn't super urgent but there is a lot going on and I wanted to at least clean up my local branch before wrapping my day; I'm confidence I'll have a patch for code review on Monday [13:43:21] I see a deploy from jgleeson an hour an a half ago - guessing that's the security update? [13:44:33] (03Merged) 10jenkins-bot: Filter ComboWiki payment methods by country [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346106 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson) [13:44:47] oh yep, looks like it [13:50:22] yep ejegg [13:52:35] (03PS4) 10Ejegg: Replace RequestContext::getMain where trivial [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347936 (https://phabricator.wikimedia.org/T423456) [13:54:18] (03CR) 10Ejegg: "Good catch, Tacsipacsi. I've narrowed it to just the places where we use RequestContext to get at the config or a user object for the rate" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347936 (https://phabricator.wikimedia.org/T423456) (owner: 10Ejegg) [14:09:10] (03CR) 10Ejegg: [C:03+1] Batch campaign mixin lookup (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1344334 (https://phabricator.wikimedia.org/T439239) (owner: 10Majavah) [14:10:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team: CI build slow and timing out sometimes - https://phabricator.wikimedia.org/T434024#12389445 (10hashar) I have manually rebuild the job a 20 times w... [14:12:07] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team: CI build slow and timing out sometimes - https://phabricator.wikimedia.org/T434024#12389448 (10Peter) Also FYI T439729 upcoming changes for which g... [14:15:27] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: Add SEPA - https://phabricator.wikimedia.org/T439597#12389459 (10Laurabarluzzi) @Cstone @jgleeson I have a WIP patch ready for the team to have a look at; I still want to revisit it with f... [14:21:59] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Calculate utm_key on combowiki - https://phabricator.wikimedia.org/T439981 (10Ejegg) 03NEW [14:25:11] (03CR) 10Ejegg: "Sorry I was unclear - the class and service names were fine, I just meant the namespace should be DonationInterface\Logging\ . We would e" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [14:30:21] (03PS1) 10Ejegg: Update authors list [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348736 [14:30:38] should be an easy review there ^^^ :) [14:38:04] (03CR) 10Tacsipacsi: "Actually, `EmailPrefernces` still contains a change that is neither a config nor a user object, is that intentional? (It doesn’t look as r" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347936 (https://phabricator.wikimedia.org/T423456) (owner: 10Ejegg) [14:40:39] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348736 (owner: 10Ejegg) [14:42:25] (03Merged) 10jenkins-bot: Update authors list [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348736 (owner: 10Ejegg) [15:14:16] (03PS5) 10Laurabarluzzi: Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) [15:14:24] (03CR) 10CI reject: [V:04-1] Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [15:16:50] (03PS6) 10Laurabarluzzi: Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) [15:16:51] (03CR) 10Ejegg: "Ah, session should be fine too. I'll update the commit message" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347936 (https://phabricator.wikimedia.org/T423456) (owner: 10Ejegg) [15:17:08] (03PS5) 10Ejegg: Replace RequestContext::getMain where trivial [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347936 (https://phabricator.wikimedia.org/T423456) [15:18:48] (03CR) 10CI reject: [V:04-1] Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [15:19:02] (03PS7) 10Laurabarluzzi: Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) [15:20:54] (03CR) 10CI reject: [V:04-1] Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [15:25:04] (03PS8) 10Laurabarluzzi: Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) [15:27:21] (03CR) 10Laurabarluzzi: "I made the changes, it should be correct now :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [15:32:55] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Add new ACH Connector to Gravy - https://phabricator.wikimedia.org/T438723#12390106 (10Damilare) [15:34:58] (03PS1) 10Damilare Adedoyin: WIP: Fill in fields and focus on payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348772 (https://phabricator.wikimedia.org/T439621) [15:36:52] (03CR) 10CI reject: [V:04-1] WIP: Fill in fields and focus on payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348772 (https://phabricator.wikimedia.org/T439621) (owner: 10Damilare Adedoyin) [15:55:44] (03PS15) 10Ejegg: Wait till banner fetched to consult TK enrollment [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057) [15:57:21] (03CR) 10CI reject: [V:04-1] Wait till banner fetched to consult TK enrollment [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057) (owner: 10Ejegg) [15:59:45] (03CR) 10Ejegg: "PS15 attempts to use mw.testKitchen.getExperiment, but I realize I need to update tests, as well as smoke test all the different cases." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057) (owner: 10Ejegg) [16:16:32] (03CR) 10Ejegg: "Just a couple more tiny things" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [16:29:16] (03Abandoned) 10Ejegg: WIP Use SmashPig PaymentMethod constants in Adyen code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1126658 (owner: 10Ejegg) [17:37:05] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog: Update Fundraising Tech Stack Diagram for 2026 - https://phabricator.wikimedia.org/T439891#12390734 (10Dwisehaupt) some changes for the diagram: * frmx1001 -> frmx1002 * frdb1004 -> frdb1008 * payments1005-1008 -> payments1009-1012 * frpig... [17:53:18] (03PS16) 10Ejegg: Wait till banner fetched to consult TK enrollment [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057) [18:02:56] (03PS17) 10Ejegg: Wait till banner fetched to consult TK enrollment [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057) [18:02:56] (03PS1) 10Ejegg: Move 11 yr old mystery TODO [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1348867 [18:48:03] (03PS9) 10Laurabarluzzi: Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) [18:49:06] (03CR) 10Laurabarluzzi: Follow-up patch addressing some suggestions regarding the new logging service (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [19:13:15] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06FR-donorrelations: Broken search kit - https://phabricator.wikimedia.org/T440029 (10SHust) 03NEW [19:57:08] (03PS1) 10Ejegg: Remove old FreeGeoIPLookup module [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1348956 (https://phabricator.wikimedia.org/T102848) [19:59:08] (03PS2) 10Ejegg: Remove old FreeGeoIPLookup module [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1348956 (https://phabricator.wikimedia.org/T224038) [20:15:02] 06Fundraising-Backlog, 10Fr-CentralNotice-Translation-Bugs, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: Discuss new features to facilitate CentralNotice message translation - https://phabricator.wikimedia.org/T158508#12391408 (10SBurnett-WMF) @siebrand - We have a process for tr... [20:17:12] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CentralNotice: JS code style, JSCS and JSDoc - https://phabricator.wikimedia.org/T111387#12391458 (10SBurnett-WMF) 05Open→03Resolved a:03SBurnett-WMF This phab superseded by newer work. Clo... [20:17:40] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CentralNotice: JS code style, JSCS and JSDoc - https://phabricator.wikimedia.org/T111387#12391467 (10SBurnett-WMF) [20:43:35] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM: Tracking donor strategies in Civi - https://phabricator.wikimedia.org/T437526#12391529 (10DBautista-WMF) @SBurnett-WMF Thanks for your patience. Here's an example: https://docs.google.com/spreadsheets/d/1_G0_msip-R_r4QXbUFg-i... [21:03:05] lol @ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/1348867 [21:08:30] (03CR) 10Dreamy Jazz: [C:03+2] Remove old FreeGeoIPLookup module [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1348956 (https://phabricator.wikimedia.org/T224038) (owner: 10Ejegg) [21:09:25] (03PS1) 10Dreamy Jazz: Remove old FreeGeoIPLookup module [extensions/CentralNotice] (REL1_46) - 10https://gerrit.wikimedia.org/r/1348983 (https://phabricator.wikimedia.org/T224038) [21:10:31] (03CR) 10Dreamy Jazz: [C:03+2] Remove old FreeGeoIPLookup module [extensions/CentralNotice] (REL1_46) - 10https://gerrit.wikimedia.org/r/1348983 (https://phabricator.wikimedia.org/T224038) (owner: 10Dreamy Jazz) [21:10:39] (03CR) 10Ejegg: [C:03+2] "Looks great, thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [21:10:47] (03PS1) 10Dreamy Jazz: Remove old FreeGeoIPLookup module [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1348984 (https://phabricator.wikimedia.org/T224038) [21:11:01] (03Merged) 10jenkins-bot: Remove old FreeGeoIPLookup module [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1348956 (https://phabricator.wikimedia.org/T224038) (owner: 10Ejegg) [21:11:05] (03CR) 10Dreamy Jazz: [C:03+2] Remove old FreeGeoIPLookup module [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1348984 (https://phabricator.wikimedia.org/T224038) (owner: 10Dreamy Jazz) [21:12:00] (03Merged) 10jenkins-bot: Follow-up patch addressing some suggestions regarding the new logging service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1348681 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [21:12:51] (03PS2) 10Dreamy Jazz: Remove old FreeGeoIPLookup module [extensions/CentralNotice] (REL1_43) - 10https://gerrit.wikimedia.org/r/1348985 (https://phabricator.wikimedia.org/T224038) [21:12:59] (03CR) 10Dreamy Jazz: [C:03+2] Remove old FreeGeoIPLookup module [extensions/CentralNotice] (REL1_43) - 10https://gerrit.wikimedia.org/r/1348985 (https://phabricator.wikimedia.org/T224038) (owner: 10Dreamy Jazz) [21:13:18] (03Merged) 10jenkins-bot: Remove old FreeGeoIPLookup module [extensions/CentralNotice] (REL1_46) - 10https://gerrit.wikimedia.org/r/1348983 (https://phabricator.wikimedia.org/T224038) (owner: 10Dreamy Jazz) [21:13:26] (03Merged) 10jenkins-bot: Remove old FreeGeoIPLookup module [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1348984 (https://phabricator.wikimedia.org/T224038) (owner: 10Dreamy Jazz) [21:22:12] (03Merged) 10jenkins-bot: Remove old FreeGeoIPLookup module [extensions/CentralNotice] (REL1_43) - 10https://gerrit.wikimedia.org/r/1348985 (https://phabricator.wikimedia.org/T224038) (owner: 10Dreamy Jazz)