[16:32:02] 10GitLab (CI & Job Runners), 10Patch-For-Review, 10Release-Engineering-Team (GitLab-a-thon 🦊), 10User-brennen: Deploy buildkitd to trusted GitLab runners - https://phabricator.wikimedia.org/T308271 (10dduvall) [16:33:04] 10GitLab (CI & Job Runners), 10Patch-For-Review, 10Release-Engineering-Team (GitLab-a-thon 🦊), 10User-brennen: Authenticate trusted runners for registry access against GitLab using temporary JSON Web Token - https://phabricator.wikimedia.org/T308501 (10dduvall) 05Open→03Stalled @Joe it looks like the `... [20:44:25] Has anyone looked into what it would take to build a Phabricator integration for our gitlab? https://docs.gitlab.com/ee/integration/external-issue-tracker.html [20:45:14] * bd808 finds https://docs.gitlab.com/ee/development/integrations/index.html [20:48:22] bd808: adding Phab as a custom issue tracker seems easy to do and I was about to just do it [20:48:31] except that is per project [20:48:36] and I just see my own 2 projects [20:49:14] oh cool. I had not spotted that generic integration in the list [20:49:57] Custom issue tracker settings saved and active. [20:50:04] tested in wikistats project [20:50:27] now where do I see it.. heh [20:50:42] this repo: https://gitlab.wikimedia.org/cloudvps-repos/wikistats is supposed to have phab integration now [20:50:43] My interest was in connecting the git repos I'm working to move over from Phabricator back to phab for task things. I'll poke around apis to see if I can figure out how to use this generic one [20:51:21] it's in the sidebar, custom issue tracker [20:52:05] it asked me for the following values: [20:52:10] It looks like a custom integration would mostly just change the mouse over text. https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/integrations/bugzilla.rb [20:52:14] project URL: https://phabricator.wikimedia.org/project/view/543/ [20:52:24] issue URL: https://phabricator.wikimedia.org/T:id [20:52:27] (note the placeholder) [20:52:35] new issue URL: https://phabricator.wikimedia.org/maniphest/task/edit/form/1/ [20:52:39] (creating tasks) [20:52:50] it wanted all of these..so somewhere it is using them now [20:53:23] I don't see yet where I could actually call it Phabricator instead of "Custom Issue Tracker" [20:53:53] I think that would require making a ruby class like the one I linked for Bugzilla [20:53:59] and then upstreaming it [20:54:20] * mutante notices the "IRC notifications" integration ... [20:54:44] gotcha [20:54:57] that's a fairly short file, yea [20:57:25] yea, so far it seems like every single project would do this themselves. not sure yet about global sidebar changes.. [20:57:40] it should link to tickets though when we use bug numbers in commit messages (not tested) [20:58:08] each repo would need config to point to a specific Phab tag anyway I think [20:58:29] true, to link to their project page [21:00:59] we should add the instructions to https://www.mediawiki.org/wiki/GitLab/Hosting_a_project_on_GitLab or somewhere [21:01:22] i'll keep that open as a reminder for now [21:02:09] The asana integration seems to update asana by adding comments when things are merged. That would be useful for us in Phabricator integration too. https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/integrations/asana.rb [21:03:30] there is also both IRC and Slack... we should have "create ticket from chat" integration to create tickets for all of these (chatops) [21:03:50] jk, food for now [21:05:04] stashbot could be trivially extended to make new tasks, but how to actually collect useful input from a single irc message is the hard part [21:05:04] See https://wikitech.wikimedia.org/wiki/Tool:Stashbot for help. [21:05:13] * bd808 pets stashbot [21:06:39] :) [21:09:52] could imagine using that even with just short sentences like "!mkticket remind us to follow-up... [21:09:59] and then later editing the ticket [21:10:04] be back later [21:14:49] bd808: did https://phabricator.wikimedia.org/T265617 get linked yet? [21:15:21] brennen: nope, thanks for the pointer [21:17:24] brennen: upstream I found this deep integration with some SaaS called Zentao -- https://gitlab.com/gitlab-org/gitlab/-/issues/338178 -- It looks like there is actually an ability to write a plugin that lets you pretty fully expose external issues in the gitlab UI if you want to get that deep. [21:18:49] yeah - we sort of found various threads we could pull on a while back, but have never really pulled on them [21:18:53] For mediawiki/core I imagine this would be a mess to try, but it would probably work for most other projects that only have 1 phab tag or an umbrella tag. [21:19:05] the "custom issue tracker" thing is... well, it doesn't do much. you can have a notation that creates links, mostly. [21:19:42] last i looked, anyway. i think we'd like to provide the same level of integration we've currently got with gerrit etc. [21:19:51] realizing that this rails app doesn't have a concept of deployment-specific plugins is :sad face: [21:28:45] yay! `PUT /projects/:id/integrations/custom-issue-tracker` is a thing. I should be able to wire this into the Striker stuff. [21:39:21] 10GitLab (Project Migration), 10Striker, 10Tools, 10Goal: Replace Diffusion integration with Gitlab integration in Striker (toolsadmin) - https://phabricator.wikimedia.org/T296893 (10bd808) [21:39:34] 10GitLab (Project Migration), 10Striker, 10Tools, 10Goal: Replace Diffusion integration with Gitlab integration in Striker (toolsadmin) - https://phabricator.wikimedia.org/T296893 (10bd808) [22:33:57] 10GitLab (CI & Job Runners), 10Patch-For-Review, 10Release-Engineering-Team (GitLab-a-thon 🦊), 10User-brennen: Authenticate trusted runners for registry access against GitLab using temporary JSON Web Token - https://phabricator.wikimedia.org/T308501 (10dduvall) >>! In T308501#8186003, @dduvall wrote: > @Jo...