[12:01:38] 10GitLab (Project Migration), 10serviceops-collab, 10Release-Engineering-Team (They Live 🕶️🧟): Provide mechanism to publish to doc.wikimedia.org from GitLab CI - https://phabricator.wikimedia.org/T336168 (10jnuche) 05Open→03Resolved [12:02:12] 10GitLab (Project Migration), 10API Platform, 10Anti-Harassment, 10Cloud-Services, and 19 others: Migrate PipelineLib repos to GitLab - https://phabricator.wikimedia.org/T332953 (10jnuche) [12:12:33] 10GitLab (Project Migration), 10API Platform, 10Anti-Harassment, 10Cloud-Services, and 19 others: Migrate PipelineLib repos to GitLab - https://phabricator.wikimedia.org/T332953 (10jnuche) In a project's `.gitlab-ci.yml`, it is now possible to publish documentation and test coverage results to doc.wikimedi... [12:40:37] 10GitLab (CI & Job Runners): Replace deprecated `CI_JOB_JWT` CI variable in Kokkuri - https://phabricator.wikimedia.org/T337474 (10jnuche) [12:41:09] 10GitLab (CI & Job Runners), 10Release-Engineering-Team (They Live 🕶️🧟): Replace deprecated `CI_JOB_JWT` CI variable in Kokkuri - https://phabricator.wikimedia.org/T337474 (10jnuche) a:03jnuche [14:33:51] 10GitLab (CI & Job Runners), 10Release-Engineering-Team (They Live 🕶️🧟): Replace deprecated `CI_JOB_JWT` CI variable in Kokkuri - https://phabricator.wikimedia.org/T337474 (10jnuche) [15:42:13] dcaro: fwiw, i found your 500 in logs. this feels like a gitlab code bug. [15:42:31] ActiveRecord::NotNullViolation (PG::NotNullViolation: ERROR: null value in column "note_id" of relation "diff_note_positions" violates not-null constraint [17:06:02] interesting [17:06:12] thanks for looking :) [17:09:40] brennen: I'm having some issues trying to build a simple golang image with blubber, I'm sure I'm doing something dummy, wouldn't you have a minute to look at https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-builds-api/-/merge_requests/6/diffs?commit_id=53ced1ed0a58db5ffe9499bc7f7b8479203a7cb5 ? [17:10:16] the image seems to build ok, but when running it (docker run --rm ) it always complains that either 'go' or 'builds-api' does not exist [17:18:50] oh my... I have to specify the base on all the images xd [17:19:00] that's why the result image was almost empty [17:21:32] dcaro: you can set a common base outside of the variants something like https://github.com/wikimedia/wikimedia-toolhub/blob/main/.pipeline/blubber.yaml#L3 [17:22:01] that example is super useful! thanks! [17:23:32] The other trick that file uses is "includes: [some_variant]" to inherit config from one variant to another [18:34:15] I saw :), and it's quite useful yes, I was able to run the tests, and the build, now it's failing trying to reach harbor on toolsbeta but I'll leave it for tomorrow to investigate and add proper auth (error: failed to solve: failed to push toolsbeta-harbor.wmcloud.org/path/to/image:tag: failed to do request: Head [18:34:15] "https://toolsbeta-harbor.wmcloud.org/v2/path/to/image/blobs/sha256:97bb103c4064527b83c665047c2993c29756dba9eb8a20508570baf6a15e2553": dial tcp 172.16.5.238:443: connect: connection refused) [18:34:33] that path is wrong too btw xd [19:23:56] 10GitLab (Upstream pit of despair 🕳️), 10Release-Engineering-Team (Radar), 10User-brennen: GitLab MR reviews throw 500 errors when commenting on some specific lines - https://phabricator.wikimedia.org/T337514 (10brennen) [19:24:50] 10GitLab (Upstream pit of despair 🕳️), 10Release-Engineering-Team (Seen), 10Upstream: GitLab: Make public the default fork option - https://phabricator.wikimedia.org/T324016 (10brennen) [21:25:52] brennen: I gave CodeReviewBot an avatar from commons. Please do revert/replace if you hate what I picked out. https://phabricator.wikimedia.org/p/CodeReviewBot/ https://commons.wikimedia.org/wiki/File:Antu_automated-tasks.svg [21:49:21] bd808: downright charming. :) [21:53:21] let's say one wanted to abuse some feature of gitlab to stash review requests to multiple reviewers [21:54:40] merge request labels, maybe? [21:54:55] https://gitlab.wikimedia.org/brennen/test/-/merge_requests/11 [21:56:36] cute. Can those be queried across repos? [21:56:58] good q [21:59:04] yes! https://gitlab.wikimedia.org/dashboard/merge_requests?scope=all&state=all&label_name[]=review-request%3Abrennen [21:59:13] https://gitlab.wikimedia.org/dashboard/merge_requests?scope=all&state=opened&label_name[]=review-request%3Abrennen [21:59:15] sure enough [22:01:46] i don't know if something like that would be better than hacking it in other ways, but i'm pretty convinced we need some multiple reviewers [22:01:57] _some way to do_, that is. [22:02:49] yeah, life is going to be even rougher for non-team code review if you have to guess a singular human