[05:24:03] 10GitLab (Account Approval), 10Release-Engineering-Team: Requesting GitLab account activation for USER[S] - https://phabricator.wikimedia.org/T337534 (10Nik.xyz.in) [07:41:29] nice logo! https://usercontent.irccloud-cdn.com/file/iNuQEIAk/image.png [09:11:05] 10GitLab (Account Approval), 10Release-Engineering-Team: Requesting GitLab account activation for Nik.xyz.in - https://phabricator.wikimedia.org/T337534 (10Peachey88) [09:20:25] Anyone knows if the jobs run on shared runners have access to the internet? And if they do not, if it's possible to enable? I'm trying to push the blubber built image to a custom repository, but it seems to be unable to reach it at all [09:41:39] dcaro: outgoing traffic to the internet should be possible from shared runners. Access to other WMCS instances is restricted and has to be allowed in https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/refs/heads/production/hieradata/cloud.yaml#174 [09:48:13] jelto: that is interesting, that includes the "public" openstack endpoints I guess? [09:50:42] 10GitLab (CI & Job Runners), 10Release-Engineering-Team (They Live 🕶️🧟): Replace deprecated `CI_JOB_JWT` CI variable in Kokkuri - https://phabricator.wikimedia.org/T337474 (10jnuche) 05Open→03In progress [09:51:22] If that's the case, just sent a patch :) https://gerrit.wikimedia.org/r/c/operations/puppet/+/923547 [10:14:07] 10GitLab (CI & Job Runners), 10Release-Engineering-Team (They Live 🕶️🧟): Replace deprecated `CI_JOB_JWT` CI variable in Kokkuri - https://phabricator.wikimedia.org/T337474 (10jnuche) [10:14:54] 10GitLab (CI & Job Runners), 10Release-Engineering-Team (They Live 🕶️🧟): Replace deprecated `CI_JOB_JWT` CI variable in Kokkuri - https://phabricator.wikimedia.org/T337474 (10jnuche) @brennen I updated the description. It seems this won't prevent us from upgrading to GitLab 16 after all. [10:24:43] dcaro: I'm not sure where the public openstack endpoint lives, but if it's somewhere inside of 172.16.0.0/21 yes. This range is blocked on WMCS to prevent access to other WMCS projects. [10:27:31] jelto: wait, if I ssh to the runner, and do a curl it works, does it add the rules to the containers themselves or similar instead? [10:28:56] it's 172.16.5.238 the ip, so yes, it's in that range [10:29:48] oh, yes, it's in the DOCKER_ISOLATION table [10:30:24] so yep, the patch is needed, though as taavi said in there, it will open access to *any* wmcs hosted proxied webservice (as the ip is of the proxy) [12:32:14] jelto: updated the patch to reflect that :) https://gerrit.wikimedia.org/r/c/operations/puppet/+/923547 [13:12:31] 10GitLab (Project Migration), 10serviceops-collab, 10Release-Engineering-Team (They Live 🕶️🧟): Provide mechanism to publish to doc.wikimedia.org from GitLab CI - https://phabricator.wikimedia.org/T336168 (10hashar) 05Resolved→03Open Coming from https://gerrit.wikimedia.org/r/c/integration/docroot/+/92254... [13:13:01] 10GitLab (Project Migration), 10API Platform, 10Anti-Harassment, 10Cloud-Services, and 19 others: Migrate PipelineLib repos to GitLab - https://phabricator.wikimedia.org/T332953 (10hashar) [13:15:30] 10GitLab (Upstream pit of despair 🕳️), 10Release-Engineering-Team (Radar), 10User-brennen: GitLab MR reviews throw 500 errors when commenting on some specific lines - https://phabricator.wikimedia.org/T337514 (10dcaro) Thanks! [13:27:25] 10GitLab (Project Migration), 10Release-Engineering-Team (They Live 🕶️🧟), 10User-brennen: Define a permissions model for the /repos/mediawiki/ namespace on GitLab - https://phabricator.wikimedia.org/T336807 (10Mvolz) One thing I wanted to flag up is that main branches can be protected so that only developer... [15:00:05] 10GitLab (Project Migration), 10Release-Engineering-Team (They Live 🕶️🧟), 10User-brennen: Define a permissions model for the /repos/mediawiki/ namespace on GitLab - https://phabricator.wikimedia.org/T336807 (10dancy) >>! In T336807#8882990, @Mvolz wrote: > One thing I wanted to flag up is that main branches... [15:26:54] I'm trying to add test coverage to a repo that uses kokkuri, is there an established way to do this? [15:27:54] Right now when I look at the job logs it seems like an xml file is generated into a black hole and gitlab can't find it [15:27:59] https://gitlab.wikimedia.org/repos/data-engineering/mediawiki-event-enrichment/-/jobs/101661 [15:31:50] Hi tchin. I'm taking a look [15:47:24] tchin: Ok. So when you build an image w/ kokkuri, the build process runs in an isolated environment that doesn't affect the workspace directory that gitlab creates. You have to specify additional flags to "export" files from the build environment. You can find an example in the scap repo: https://gitlab.wikimedia.org/repos/releng/scap/-/blob/master/.gitlab-ci.yml#L60 [15:47:24] The `BUILDCTL_BUILD_FLAGS: --output type=local,dest=generated-documentation` translates to "copy the contents of the built image into the 'generated-documentation' directory in the workspace. So in your case you might use `BUILDCTL_BUILD_FLAGS: --output type=local,dest=test-output`.. then reference something below test-output/ in .gitlab-ci.yml. [15:48:35] xref: https://github.com/moby/buildkit#local-directory [15:48:47] (kokkuri uses buildkit / buildctl to build images) [15:49:37] The text beginning "To export specific files use multi-stage builds..." might be useful too if copying the entire image contents is too much. [16:00:49] ooo this is really helpful thanks for the pointers [16:01:51] 10GitLab (Integrations), 10Phabricator: Get GitLab to render `T{\d}+` in MR overviews, comments, etc. as links to Phabricator - https://phabricator.wikimedia.org/T337570 (10Jdforrester-WMF) [16:41:51] 10GitLab (Integrations): Get GitLab to render `T{\d}+` in MR overviews, comments, etc. as links to Phabricator - https://phabricator.wikimedia.org/T337570 (10Aklapper) [16:43:53] 10GitLab (Integrations), 10Phabricator: Get GitLab to render `T{\d}+` in MR overviews, comments, etc. as links to Phabricator - https://phabricator.wikimedia.org/T337570 (10Jdforrester-WMF) This is relevant to Phabricator, as without this kind of integration we'll need to dump it and use GitLab issues. [16:50:18] 10GitLab (Integrations), 10Phabricator: Get GitLab to render `T{\d}+` in MR overviews, comments, etc. as links to Phabricator - https://phabricator.wikimedia.org/T337570 (10bd808) A potential solution would be to work upstream to implement a Phabricator [[https://docs.gitlab.com/ee/integration/external-issue-t... [17:05:05] 10GitLab (Integrations), 10Phabricator: Get GitLab to render `T{\d}+` in MR overviews, comments, etc. as links to Phabricator - https://phabricator.wikimedia.org/T337570 (10Aklapper) After [removing Phabricator code, metrics, and documentation](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117649) I'm... [18:57:43] 10GitLab (Account Approval), 10Abstract Wikipedia team, 10Release-Engineering-Team: Requesting GitLab account activation for Nik.xyz.in - https://phabricator.wikimedia.org/T337534 (10Jdforrester-WMF) [23:51:24] 10GitLab: Cannot log into GitLab due to email address conflict - https://phabricator.wikimedia.org/T337598 (10nshahquinn-wmf) [23:51:32] 10GitLab: Cannot log into GitLab due to email address conflict - https://phabricator.wikimedia.org/T337598 (10nshahquinn-wmf) a:05nshahquinn-wmf→03None