[01:03:22] brennen, dancy: Does gitlab have an action log somewhere that shows things like which admin approved which user? I'm trying to decide if I should add durable logging to https://gitlab.wikimedia.org/toolforge-repos/gitlab-account-approval (like writing to a wiki page) or not. [15:44:55] bd808: Gitlab does store who created an account along with the account information. [15:46:15] (for users that are explicitly created, for example, by ldap-sync-bot). Users that are automatically created (e.g., by logging in for the first time using their wikitech account info) do not have that information. [15:46:34] I think adding durable logging to your tool would be a good idea. [15:47:39] One more thing: You can add "admin notes" to users that you create. [15:57:25] dancy: thanks. that kicks off some ideas in my head. I'll see if I can work on them today. :) [16:26:35] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: Allow Gitlab CI OSV template to fail - https://phabricator.wikimedia.org/T353819 (10mmartorana) [16:27:06] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: [EPIC] Application Security Pipeline Components for Gitlab - Phase 2 Work - https://phabricator.wikimedia.org/T342177 (10mmartorana) [16:27:15] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: Allow Gitlab CI OSV template to fail - https://phabricator.wikimedia.org/T353819 (10mmartorana) 05Open→03In progress p:05Triage→03Medium [16:31:39] i had thought that i remembered seeing an "approved by", but i can't now seem to find it in the UI, at any rate. [16:33:49] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10Patch-For-Review, 10SecTeam-Processed, and 2 others: Allow Gitlab CI OSV template to fail - https://phabricator.wikimedia.org/T353819 (10CodeReviewBot) mmartorana opened https://gitlab.wikimedia.org/repos/security/gitlab-ci-security-templates/-/mer... [16:34:51] brennen: you get that on MRs [16:36:22] yeah. maybe my brain is just doing some transference from elsewhere. [16:38:17] brennen: https://gitlab.wikimedia.org/admin/users/ will show "Created by" at the bottom of the table if the user was explicitly created. [16:38:29] e.g. https://gitlab.wikimedia.org/admin/users/mcastro-wmf [16:42:07] dancy: ah, yeah, guess that's what i was thinking of. [18:12:26] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: [EPIC] Application Security Pipeline Components for Gitlab - Phase 2 Work - https://phabricator.wikimedia.org/T342177 (10mmartorana) [18:12:34] 10Gitlab-Application-Security-Pipeline, 10SecTeam-Processed, 10Security: Provide use case about specific workflow in documentation - https://phabricator.wikimedia.org/T348548 (10mmartorana) 05In progress→03Resolved The [[ https://www.mediawiki.org/wiki/Security/Application_Security_Pipeline#Risk_review_a... [18:12:38] 10Gitlab-Application-Security-Pipeline, 10SecTeam-Processed, 10Security: Provide use case about specific workflow in documentation - https://phabricator.wikimedia.org/T348548 (10mmartorana) [19:41:54] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10Patch-For-Review, 10SecTeam-Processed, and 2 others: Allow Gitlab CI OSV template to fail - https://phabricator.wikimedia.org/T353819 (10CodeReviewBot) sbassett merged https://gitlab.wikimedia.org/repos/security/gitlab-ci-security-templates/-/merge... [19:45:23] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security: Allow Gitlab CI OSV template to fail - https://phabricator.wikimedia.org/T353819 (10sbassett) 05In progress→03Resolved [19:45:26] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: [EPIC] Application Security Pipeline Components for Gitlab - Phase 2 Work - https://phabricator.wikimedia.org/T342177 (10sbassett) [19:45:36] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security: Allow Gitlab CI OSV template to fail - https://phabricator.wikimedia.org/T353819 (10sbassett)