[02:06:47] [telegram] the time and timezone (mis)handling in the schedule is confusing. there's a column saying "Start time (UTC)" which says the first session today starts at "05:00 (03:00 GMT)" and then links to a tool which says that's "5:00 am (GMT+01:00)"... so it starts at 3am, 4am and 5am UTC simultaneously 🤔 [02:16:04] [telegram] Ah yes, it looks like the tool got updated and it made it hard to read. Let's try and reword that... [02:55:36] [telegram] The first set of core hours of day 2 is starting! https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2022/Schedule [02:55:39] [telegram] Krinkle turned my user script for showing zonestamp values as local times into a default gadget on mediawiki.org. The 05:00 is your local time according to your browser. The 03:00 GMT is what the time stamp is set to. (re @Nikki: the time and timezone (mis)handling in the schedule is confusing. there's a column saying "Start time (UTC)" which says the firs...) [03:03:15] [telegram] hm, what's it called? I don't see it in the gadgets list (re @bd808: Krinkle turned my user script for showing zonestamp values as local times into a default gadget on mediawiki.org. The 05:00 is y...) [03:03:52] [telegram] Why not just use UTC? Most Wikimedians should be UTC-N :P [03:08:10] @Nikki: it's https://www.mediawiki.org/wiki/MediaWiki:Gadget-site-hackathon-zonestamp.js which has been put into the globally enabled "Site" gadget [03:09:30] [telegram] ah, disabled the gadget and now it's much better [03:26:30] [telegram] aside from the issue of it making it say two times for (essentially) the same timezone, "21.05.22, 05:00 (03:00 GMT)" (wrapped onto four lines, no less) makes it a lot harder for me to parse than "03:00 (UTC)" since it's a block of numbers [03:28:46] @nikki: those of you in GMT+1:00 have an easier time converting the times than folks who are in say GMT+5:30 or GMT-7:00 :) [03:30:40] [telegram] and even once I pick the time out, there's actually multiple times, which means more ways for me to mess it up, since my biggest problem with timezones is applying the offset the right number of times [03:30:59] "5/20/22, 9:00 PM (03:00 GMT)" makes lots more sense for me. [03:31:05] "5/20/22, 9:00 PM (03:00 GMT)" makes lots more sense for me. [03:32:02] but maybe the default gadget treatment was not ideal. that's fair criticism [03:32:13] [telegram] that leads to the "wrapped onto four lines" problem [03:33:22] [telegram] what might have been more helpful is if there were exactly one time shown, but that time was adjustable to local time vs UTC with a check-box or something [03:33:31] everything is horrible! we are all doomed!! ;) [03:33:57] [telegram] now that's not the lego movie I remember :-) [03:34:28] lol [03:34:28] [telegram] (context: Q17003501) [03:35:38] https://bash.toolforge.org/quip/GkWv5IAB8Fs0LHO5PoKO [03:39:14] opt-in gadget/userscript with support of customizing the display format really does seem ideal. or finding a wiki-like scheduling platform that has better UX than multi-column wiki tables... [03:56:35] [telegram] yeah, opt-in and only showing one time would be my preference. if it's going to be enabled by default though, I think it should show the converted time in brackets, because it doesn't know whether the page was written with automatic conversion in mind or not, and I think it should only display the date if it's actually different [03:57:14] [telegram] it would be even better if it would use my wiki preferences, since I already told it what timezone I want to see :P [05:03:09] [telegram] Come join us for a toolhub session, if you're free! https://phabricator.wikimedia.org/T308392 [05:29:55] [telegram] Hello guys I could not join any of the sessions. The link was not connect. Can anyone help please? What time is today's session please?. Thanks! [05:40:30] [telegram] Hi! There will be many more sessions. You can see the schedule here: https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2022/Schedule#The_Hackathon_is_Live! [06:32:42] [telegram] Hallo. The translatable strings of Pywikibot are broken into many sub-groups. You can see a list of all these groups by going to https://translatewiki.net/wiki/Special:Translate?filter=%21translated&action=translate&language=ee&group=out-pywikipedia-0-all and clicking on "Pywikibot" next to Message group / All. [06:32:55] [telegram] My question is: which of these groups are the most frequently seen by users? [06:33:02] [telegram] In edit summaries, or anywhere else. [06:33:19] [telegram] If you don't have precise statistics, it's fine. Guessing is fine, too. [06:43:14] Just looking over the phab sched [06:45:33] amire80: except of the pywikibot-pywikibot group the very most of them are used for edit summaries. The most used script might be "Redirect". If a translation is missing there is a fallback to another language which is "en" as a final step [07:22:45] [telegram] is there any good python module to edit the wiki pages other than pywikibot ? [07:43:11] [telegram] I saw some git repo with python code samples for most of the wiki actions, some time back. Can anyone share it? [07:49:28] [telegram] Any of these? https://www.mediawiki.org/wiki/Manual:Creating_a_bot#Python [08:07:00] see: https://www.mediawiki.org/wiki/API:Client_code#Python [08:08:27] [telegram] This has led to some interesting situations since the time zone I am in and my browser is in are not the same because of my internet provider :D (re @bd808: Krinkle turned my user script for showing zonestamp values as local times into a default gadget on mediawiki.org. The 05:00 is y...) [08:26:14] Good morning Hackathon :) [08:27:06] Morning! [09:05:28] [telegram] Morning all! [09:19:01] [telegram] Hi, Can some one verify and approve OAuth tokens for the project: VideoCutTool? [09:19:02] [telegram] https://meta.wikimedia.org/wiki/Special:OAuthListConsumers/view/4d8cd8043f2647e26a862cd19fd64ecd Thanks! [09:29:28] [telegram] Thanks tgr for approving :)) (re @gopavasanth: Hi, Can some one verify and approve OAuth tokens for the project: VideoCutTool? [09:29:29] [telegram] https://meta.wikimedia.org/wiki/Special:OAuthLis...) [10:07:52] [telegram] Found that. it is here - https://github.com/wikimedia/mediawiki-api-demos [10:40:23] [telegram] I am interested in creating a Graphical User Interface in the programming language R. Do you have experience with that. [11:43:33] [telegram] Hello everyone, do you know how to hide links: (mobileaction=toggle_view_mobiand (mobileaction=toggle_view_desktop) on wikis? Do you know the steps to remove them? [11:43:34] [telegram] [11:43:35] [telegram] Thanks a lot for your help, [11:43:37] [telegram] [11:43:38] [telegram] Example : [11:43:40] [telegram] [11:43:41] [telegram] For my wiki : [11:43:43] [telegram] [11:43:44] [telegram] [11:43:46] [telegram] Desktop : (https://Website/wiki/Exemple_Article?(mobileaction=toggle_view_desktop) [11:43:47] [telegram] [11:43:49] [telegram] [11:43:50] [telegram] Mobile : (https://Website/wiki/Exemple_Article?(mobileaction=toggle_view_mobile) [11:43:52] [telegram] [11:43:53] [telegram] ___________________________ [11:43:55] [telegram] _ [11:43:56] [telegram] For Wikipedia => [11:43:58] [telegram] [11:43:59] [telegram] Mobile : (https://en.m.wikipedia.org/wiki/Roman_Empire) [11:44:01] [telegram] [11:44:02] [telegram] [11:44:04] [telegram] Desktop : (https://en.wikipedia.org/wiki/Roman_Empire) [11:46:16] [telegram] Omg that is pure evil [12:02:36] [telegram] the WikiBär local meetup in Berlin is hanging out in Open Hacking Room 1 :) : https://tools-static.wmflabs.org/bridgebot/12a238ff/file_19328.jpg [12:17:02] [telegram] Hello everyone, do you know how to hide links: (mobileaction=toggle_view_mobiand (mobileaction=toggle_view_desktop) on wikis? Do you know the steps to remove them? [12:17:02] [telegram] [12:17:04] [telegram] Thanks a lot for your help, [12:17:05] [telegram] [12:17:07] [telegram] Example : [12:17:08] [telegram] [12:17:10] [telegram] For my wiki : [12:17:11] [telegram] [12:17:13] [telegram] [12:17:14] [telegram] Desktop : (https://Website/wiki/Exemple_Article?(mobileaction=toggle_view_desktop) [12:17:16] [telegram] [12:17:17] [telegram] [12:17:19] [telegram] Mobile : (https://Website/wiki/Exemple_Article?(mobileaction=toggle_view_mobile) [12:17:20] [telegram] [12:17:22] [telegram] ___________________________ [12:17:23] [telegram] _ [12:17:25] [telegram] For Wikipedia => [12:17:26] [telegram] [12:17:28] [telegram] Mobile : (https://en.m.wikipedia.org/wiki/Roman_Empire) [12:17:29] [telegram] [12:17:31] [telegram] [12:17:32] [telegram] Desktop : (https://en.wikipedia.org/wiki/Roman_Empire) [12:27:02] [telegram] probably the `$wgMobileUrlTemplate` setting? https://github.com/wikimedia/mediawiki-extensions-MobileFrontend#wgmobileurltemplate (re @Magva: Hello everyone, do you know how to hide links: (mobileaction=toggle_view_mobiand (mobileaction=toggle_view_desktop) on wikis? Do...) [12:32:24] [telegram] Thank you ❤️, for your help, do you know how to set it with my wiki. Example: (m.example.org) [12:45:08] [telegram] no idea, I haven’t used this setting before, I just looked through the documentation and thought it seemed relevant [12:46:54] [telegram] Hm, someone deleted my comment? [12:49:14] [telegram] not according to the group admin log… which even shows when people edit their messages. no idea what happened 🤷‍♂️ (re @Thecladis: Hm, someone deleted my comment?) [12:49:27] [telegram] Interesting [12:50:31] [telegram] Ah [12:51:13] [telegram] The comment is still there, it is just that Magva posted their question twice and I was looking under the wrong instance of the question 😅 [12:51:46] [telegram] aah. all the pieces are falling into place [12:52:18] [telegram] 😜 [12:53:04] @WMYupic can you elaborate on what kind of browser and computer you use? I'm not sure I understand how an internet provider controls the clock of your computer settings. [12:53:25] @WMYupik * [12:56:36] [telegram] I'm assuming the clock is set automatically, but the internet provider's IP is geolocated in the wrong timezone, so the automatic setting is incorrect (re @wmtelegram_bot: [irc] @WMYupic can you elaborate on what kind of browser and computer you use? I'm not sure I understand how an intern...) [12:59:04] [telegram] This :) (re @jhsoby: I'm assuming the clock is set automatically, but the internet provider's IP is geolocated in the wrong timezone, so the automati...) [12:59:34] [telegram] Well the ip is in the right timezone, I'm in the wrong one :D [13:00:44] [telegram] 🙌Hello everyone can you help me configure my wiki on ($wgMobileUrlTemplate = ) [13:00:44] [telegram] [13:00:46] [telegram] my wiki starts with: Example: (m.example.org) [13:01:20] @WMYupik Which OS? I believe this is a feature of the OS where you can choose your time zone to be set automatically, but you can set it directly as well. I thought such features were optin but perhaps nowadays default. Eg Android and macOS you can set it directly as well and then all websites and apps will show it correctly [13:02:02] I never enabled such features, almost forgot that was a thing :-) [13:02:19] [telegram] Yes, I could choose to set it myself (MacOS), but I hop timezones so much, I can't be arsed :D [13:02:58] [telegram] Hello everyone can you help me configure my wiki on ($wgMobileUrlTemplate = ) [13:02:59] [telegram] [13:03:01] [telegram] my wiki starts with: Example: (m.example.org) [13:03:02] I see. Well at least it's consistent with the clock you see on your Mac desktop right? So is hopefully still somewhat useful [13:03:15] [telegram] please don't ask the same question repeatedly like this. once is enough (re @Magva: Hello everyone can you help me configure my wiki on ($wgMobileUrlTemplate = ) [13:03:16] [telegram] [13:03:17] [telegram] my wiki starts with: Example: (m.example.org)) [13:10:31] [telegram] Yes, if I looked at that and not my watch 🤦‍♀ And I do find it useful, just need to adjust to it :D (re @wmtelegram_bot: [irc] I see. Well at least it's consistent with the clock you see on your Mac desktop right? So is hopefully still som...) [13:30:31] Hello [13:51:51] How are folks feeling on day 2? Did you meet anyone new? Did you hear an interesting talk? Have you made progress on a hack that you were excited to work on? [13:52:35] i met lots of people [13:52:41] joining again now [13:52:51] bd808: check -cloud too [13:54:09] [telegram] I liked the game jam session [13:54:14] RhinosF1: ack. I'll see if I can help them in a bit. [13:56:02] Programming for core hours part 2 starts in about an hour (15:00 GMT). There will be talks about Matrix, Toolhub, Vector 2022, and Wikimaps all starting then. https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2022/Schedule [14:14:17] [telegram] hello [14:14:48] [telegram] hello and good evening from sunny singapore (GMT+8) [14:14:57] [telegram] Afternoon! [14:15:28] [telegram] how is Singapore sunny at 22:15? 😅 [14:16:22] [telegram] LOL [14:16:26] [telegram] Temperature wise probably [14:16:56] [telegram] It's lovely & grey as always in dull England [14:17:03] [telegram] are there more people active here or on IRC / libera [14:17:15] [telegram] This is bridged [14:17:29] [telegram] Core hours are in ~45 minutes [14:23:01] [telegram] It joined Scandinavia? :D (re @jhsoby: how is Singapore sunny at 22:15? 😅) [14:23:47] [telegram] It's strangely grey yet sunny here in Stockholm 🤨 (re @Samuel: It's lovely & grey as always in dull England) [14:24:28] [telegram] It's been very up & down this week [14:24:39] [telegram] Either boiling or freezing [14:25:53] [telegram] i love stockholm! 😻 [14:26:36] [telegram] Me too. It feels so weird to be back here after 3 years! [14:30:50] [telegram] seems like zonestamp tool has a small bug as well. Apparently it applies DST to timezones without displaying it. So 5 am on central European time shows 3am on GMT+1 when it should show 3am on GMT + 2. (re @bd808: Krinkle turned my user script for showing zonestamp values as local times into a default gadget on mediawiki.org. The 05:00 is y...) [14:31:18] Want to show off your hackathon attendance? Check out https://www.mediawiki.org/wiki/Template:User_hackathon_2022, https://www.mediawiki.org/wiki/Template:Hackathon_badge_contributor_goat, https://www.mediawiki.org/wiki/Template:Hackathon_badge_easter_eggs_goat, and https://www.mediawiki.org/wiki/Template:Hackathon_badge_explorer_goat [14:31:32] ooh ye [14:58:14] Publicize your tools and find new tools -- a talk about Toolhub -- starting in https://coremeet.workadventu.re/infrastructure-tools at the top of the hour. [15:00:53] [telegram] Community Room starting soon with Matrix, PubHubs, and social tools! [15:05:39] [telegram] that is in https://coremeet.workadventu.re/community-building [15:18:15] [telegram] Greetings from the in-person Wikimedia Hackathon in Washington, DC [15:20:51] [telegram] Hi DC meetup!! [15:21:38] [telegram] Hi all. If you're at a meetup (or online) and have photos, make sure to add them to the commons category! https://commons.wikimedia.org/wiki/Category:Wikimedia_Hackathon_2022 [15:23:22] addshore: if you will be able to check my patch on gerrit, that would be awesome [15:23:45] [telegram] Hellob]* [15:25:27] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/793934 [15:28:01] [telegram] for projects not on phabricator (e.g. PAWS), what should the process of taking a task be like [15:36:01] [telegram] The Wiki Mentor Africa session is starting in the Community Building! [15:39:27] [telegram] PAWS' project is here: https://phabricator.wikimedia.org/project/view/1648/ (re @hongsy: for projects not on phabricator (e.g. PAWS), what should the process of taking a task be like) [15:57:16] Anyone around with interface admin on mw.o? Enough folks have complained about the zonestamp display customization that I would like https://www.mediawiki.org/w/index.php?title=MediaWiki:Gadgets-definition&oldid=5222797 to be reverted. [16:02:04] or Amir1, if you want to review it, too [16:02:35] it would be nice to get a review, so that I can wrap up this during the hackathon: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/793934 [16:06:13] [telegram] lol chill (re @wmtelegram_bot: [irc] it would be nice to get a review, so that I can wrap up this during the hackathon: https://gerrit.wikimedia.org/r/...) [16:06:58] [telegram] ☺️Hello, do you know how to set the : ($wgMobileUrlTemplate = ) [16:06:58] [telegram] On a wiki? [16:06:59] [telegram] [16:07:01] [telegram] Thanks for your help, [16:07:13] bd808: do people complain about local times in general, or just the format? IMO if you just keep it at time-only, no date or timezone, and keep one of the two columns for UTC, it will be much more readable [16:07:53] (I can revert though if you prefer, I suppose using staff ifadmin on mw.org is okay) [16:09:34] tgr: I would appreciate the revert. I'm getting the reports second or third hand mostly so difficult to say what the core issues are. Easier just to undo than to try and roll forward in real time, especially since I don't have interface admin there to actually work on the solution. [16:10:50] [telegram] This has been asked several times, and there have been answers. Please do check the replies and avoid reposting. Thanks a lot! (re @Magva: ☺️Hello, do you know how to set the : ($wgMobileUrlTemplate = ) [16:10:50] [telegram] On a wiki? [16:10:52] [telegram] [16:10:53] [telegram] Thanks for your help,) [16:11:12] [telegram] https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:LocalSettings.php [16:12:45] done [16:14:02] <3 [16:15:32] [telegram] <3 [16:15:49] while we are at complaining, I see someone made the schedule headers sticky, which is a quality-of-life improvement but on Vector2022 gets hidden below the skin's own sticky header [16:15:51] [telegram] /help@wikilinksbot [16:16:07] [telegram] /delete@wikilinksbot [16:16:28] [telegram] /delete@wikilinksbot [16:16:40] [telegram] /delete@wikilinksbot [16:16:41] tgr: sorry to bother. you removed the whole "site" gadget instead of just removing the zonestamp bit. The inverse of https://www.mediawiki.org/w/index.php?title=MediaWiki%3AGadgets-definition&type=revision&diff=5222797&oldid=5207766 would be ideal. [16:17:24] duh, sorry [16:19:36] [telegram] PAWS is https://phabricator.wikimedia.org/project/view/1648/. A general rule of Phabricator though is try to apply good tags, but trust that others will help with tagging as well. (re @hongsy: for projects not on phabricator (e.g. PAWS), what should the process of taking a task be like) [16:23:03] [telegram] correction: I mean for projects with source code not on gerrit (eg PAWS) (re @bd808: PAWS is https://phabricator.wikimedia.org/project/view/1648/. A general rule of Phabricator though is try to apply good tags, bu...) [16:23:49] [telegram] PAWS code is at https://github.com/toolforge/paws . [16:25:16] [telegram] I'm not sure I understand the question though. The usual workflow is for a user to assign themselves on a task in phabricator and send a PR in github. [16:54:57] Sessions starting at the top of the hour: Bridging the research and developer communities, The Wikimedia Developer Portal, [Small wiki toolkits] What is SuggestBot and How to Get It. See https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2022/Schedule for rooms. [17:01:06] [telegram] Hi hackathon people! Sam Wilson and I have been working on a documentation viewer for tools: https://docs.toolforge.org/ If you have a tool that needs documentation and you're interested in writing docs in Markdown, we're looking for early adopters! You can find out more at https://docs.toolforge.org/docs/toolforge-docs [17:02:10] [telegram] 👀 [17:02:26] [telegram] does it pull the documentation source files from the tool home directory (whatever is deployed there), or the source code directory? [17:02:58] [telegram] Interesting easter eggs : https://tools-static.wmflabs.org/bridgebot/06a2048c/file_19366.jpg [17:03:10] [telegram] it pulls from the tool's source code repository, whatever repository is listed in the ToolHub tool record [17:03:25] [telegram] ok [17:06:22] Mitar: could the default for the option be to not add the extra meta data? [17:06:35] Other than that it certainly looks like it would work [17:06:48] [telegram] Weird, what browser are you in? It's a mediawiki page, seems to work in Chrome and Safari. [17:07:27] The choice of doing it as a static method goes against the code base a little bit. It might be better to inject the service that is needed (lookup) in a constructor, and then reuse it as a service in the dump generator [17:07:38] Would also be awesome to have a small unit test for it [18:07:20] [telegram] Hi all! If you're a newcomer or have ideas for newcomers, come give us feedback in the cantina! [18:46:33] > could the default for the option be to not add the extra meta data? [18:46:34] I mean, sure. But I must say I am struggling to understand why the option is needed at all. I mean, if it is for backwards compatibility, then opt-out seems fine. If there is some reason not to include additional fields? Especially given that they are included in the API? Is this something somebody else has to make a decision on to enable it for [18:46:34] dumps? Then I think it would be neat if we could loop them in at this point and see how they stand on this. I just feel that for all installations having this metadata is useful and I think it makes it easier for people to not have to figure out why it is missing for them on their installation once they see it on Wikidata. So, who is the person who [18:46:35] will enable this flag on Wikidata? [18:47:26] I was looking at ArrayValueCollector file when I was working on this. It also has a static method? I thought that such "data transformation" seems a comparable thing? [18:47:56] But I can refactor it, for sure. [18:48:35] > Would also be awesome to have a small unit test for it [18:48:36] The issue is, I am not sure if I am really running any unit tests when I run it locally. Can you trigger running CI tests on Gerrit to see what happens there? [18:48:49] I followed https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase#development but this seems to do only linting? [18:55:06] [telegram] 👋 good to see a singaporean here! (I have lots of family there) [18:56:10] [telegram] How about building a skin? (re @haleywmf: Hi all! If you're a newcomer or have ideas for newcomers, come give us feedback in the cantina!) [18:56:31] [telegram] 👋 good to see a singaporean here! (I have lots of family there) (re @hongsy: hello and good evening from sunny singapore (GMT+8)) [18:57:09] > Would also be awesome to have a small unit test for it [18:57:10] I was also hoping that existing tests would cover these new fields as well, but as I said, nothing failed after I added new code, so I am not sure how they do cover things. [18:57:15] [telegram] https://m.mediawiki.org/wiki/Manual:How_to_make_a_MediaWiki_skin (re @Jon: How about building a skin?) [18:57:28] [telegram] in three minutes I'm playing a piano concert for the hackathon! ^^ you can watch in the cantina or here: https://twitch.tv/lucaswerkmeister [18:58:11] [telegram] (please note that I'll only pay attention to the Twitch chat live, one channel is enough on the phone ^^) [19:02:29] [telegram] am getting 503 notices for enwiki here in Indonesia [19:03:22] there is a known incident, page just went out [19:03:40] unless you're an SRE, I suggest you enjoy the piano concert for a bit :) [19:04:37] [telegram] what good is https://www.wikimediastatus.net if it is much more useless than https://www.isitdownrightnow.com/wikimedia.org.html ? [19:04:51] [telegram] claims that all systems are operational, when they clearly are not [19:04:54] [telegram] oh I forgot about wikimediastatus [19:05:01] it has to be updated manually [19:05:02] [telegram] Status page is manually updated [19:05:10] [telegram] O_o (re @Samuel: Status page is manually updated) [19:05:14] [telegram] the hell? [19:05:35] [telegram] ? [19:05:38] [telegram] ah ok, just saw the normal error notice (re @wmtelegram_bot: [irc] there is a known incident, page just went out) [19:06:31] where is the piano concert? [19:06:41] https://klaxon.wikimedia.org/ will tell you automatically if SRE has been paged to an incident [19:06:42] [telegram] (thinks of what is the suggestions of SREs...) (re @wmtelegram_bot: [irc] unless you're an SRE, I suggest you enjoy the piano concert for a bit :)) [19:07:22] [telegram] "as it can wake up engineers who are asleep" —- this sounds a bit cruel :) [19:07:37] Mitar: https://www.twitch.tv/lucaswerkmeister. You can get to it also from the "cantina" on the map by walking onto the stage where the piano is. [19:08:05] [telegram] does it actually *page*? :D (re @wmtelegram_bot: [irc] https://klaxon.wikimedia.org/ will tell you automatically if SRE has been paged to an incident) [19:08:10] [telegram] Are the wikis up? We got paged but not at laptop. Going home but takes me 15 min [19:08:21] things are recovering now [19:08:28] [telegram] They're back [19:08:33] [telegram] slowly going back [19:08:36] nice! [19:08:40] [telegram] It says resolved now. Should I ..hmm. Ok [19:08:44] [telegram] See _security irc Mutante for you [19:08:56] [telegram] I can't from mobile (re @Samuel: See _security irc Mutante for you) [19:09:55] [telegram] I forgot that you were still fairly sane [19:10:12] [telegram] @mutante23 there are plenty of folks responding. rzl, godog, marostegui. You should be fine to stay away [19:10:29] [telegram] Thank you Bryan! [19:24:36] [telegram] I understand that not all people have an SSH client on their phone, but not having an IRC client! (re @Samuel: I forgot that you were still fairly sane) [19:25:28] [telegram] It stops you working 24/7 [19:25:37] [telegram] :) [19:27:18] addshore: I removed static. See also my other comments above. [19:29:02] so I am not sure if tests are running for me locally, and if you could enable tests on Gerrit (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/793934) [19:29:03] or anyone else [19:30:12] Mitar: recheck'd [19:30:50] Mitar: failed [19:33:14] can I "recheck" myself? [19:33:44] Mitar: no [19:35:01] I see [19:35:03] I rebased now [19:35:44] Mitar: ci running auto needs a whitelist [19:35:54] allowlist? [19:36:35] I really hope transition to GitLab will happen soon [19:37:02] so why it is not working, I rebased [19:38:37] https://www.mediawiki.org/wiki/Continuous_integration/Allow_list [19:41:59] the failure to merge is probably not related to your patch, taavi reported in #wikimedia-releng that there are several patches with that error [19:44:06] thanks, so what can I do? [20:42:40] Don't forget to sign up for the showcase at 15:00 GMT tomorrow! There are 20 presenter slots and only one has been taken so far! https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2022/Showcase [22:00:46] I am going to check that CI issue [22:08:11] hashar: o/ lmk if i can help [22:09:06] ori: thanks :] [22:09:19] looks like some ssh connection went idle somehow. I will restart zuul entirely [22:11:27] I was close to that as the best next step, so I guess my zuul instincts are not horrible :) [22:13:12] yup [22:13:22] we had that issue at some point a while ago [22:13:45] sometime Gerrit might not properly close the ssh connection and the Zuul server waits infinitely for an answer [22:13:48] something like that [22:14:40] patches that failed would need a `recheck` [22:14:56] * hashar heads back to WorkAdventure [22:15:00] thanks for the ping bd808 ! [22:15:25] thank you for the fix :) [22:16:25] ori: are you on the workadventure system ? [22:16:36] have seen you quickly then you have vanished [22:22:48] so I am guessing there is now a big backlog of CI jobs, so I should just wait on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/793934 for results to appear? [22:24:52] Mitar: https://integration.wikimedia.org/zuul/ shows that one running (and it's going to be a failure per a number of the sub-tests) [22:27:02] awesome, thanks [22:27:18] OK, as I thought my changes should be failing tests [22:27:24] I do not get then how to run wikibase tests locally [22:27:35] I tried https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase#development but it seems it runs only linting [22:27:44] any idea anyone how to run tests locally? [22:28:47] addshore? [22:29:04] maybe https://www.mediawiki.org/wiki/Wikibase/Programmer%27s_guide_to_Wikibase#PHPUnit_tests [22:34:16] hmmm, I do not find those files in wikibase checkout [22:35:02] Just noticed a "This page is outdated." marker template on that page Mitar. I guess that probably means old junk :/ [22:35:04] do I have to have mediawiki itself as well? I cloned just wikibase git [22:36:00] it seems likely that yes you would need mediawiki/core too. wikibase is an extension and I assume relies on core for a lot of things. [22:39:42] [telegram] yes, to run most tests you’ll need MediaWiki core (not just cloned / checked out, but also installed) [22:40:20] so instructions in the README are not up to date? [22:40:21] [telegram] [[mw:cli]] might be useful (I don’t use it but I think many other Wikibase developers do) [22:40:28] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase#development [22:41:02] so are there some instructions how to setup minimal environment for developing wikibase extension and running tests? [22:43:32] you'll need to set up a MediaWiki installation first. https://www.mediawiki.org/wiki/Cli is probably the easiest to get started with, https://www.mediawiki.org/wiki/MediaWiki-Docker and https://www.mediawiki.org/wiki/MediaWiki-Vagrant are also options [22:45:40] [telegram] Slides from our session about docs are now on Commons, and you can still participate in the discussion via Etherpad and the talk page https://mediawiki.org/wiki/Documentation/Technical_documentation_community_and_outreach_programs/Hackathon_2022_docs_discussions (Etherpad links are in both the phab task and the slides) [22:47:18] then install wikibase (following the normal instructions or https://www.mediawiki.org/wiki/MediaWiki-Docker/Extension/Wikibase) [22:47:48] but for unit tests I should not need a database running, or mediawiki itself running as a daemon, no? [22:49:13] can I get recheck on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/793934 please? [22:50:52] sent [22:50:59] much appreciated, thanks! [22:51:32] despite all the hiccups with the CI, my hackathon experience and friendliness here is awesome! [23:00:50] [telegram] Mitar: pure unit tests should indeed be able to run without a database, I think, but I’m not sure if that’s realistic for the code you’re working with [23:01:13] the linter will certainly run without a database [23:01:56] [telegram] that is true (see also the phpcs-modified, phpcs-committed, fix-modified, and fix-committed composer scripts, to speed up the process) [23:02:23] [telegram] Speaking of unit tests, how do you run them for an extension in a docker installation? [23:02:34] [telegram] (phpcs vs fix is whether to only check or also automatically fix issues; modified runs on files that are different from the last commit, committed runs on files that were touched in the last commit) [23:08:31] how do I list multiple phabricator tasks in the commit messages? multiple "bug:" lines? [23:08:38] [telegram] when i follow the method from [[Manual:PHP unit testing/Running the tests#Select by directory or file]], I get this error: [23:08:38] [telegram] [23:08:40] [telegram] `[c00338ccb80126893cd4456d] [no req] Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Cannot return last error, no db connection ()` (re @jhsoby: Speaking of unit tests, how do you run them for an extension in a docker installation?) [23:08:49] [telegram] yeah (re @wmtelegram_bot: [irc] how do I list multiple phabricator tasks in the commit messages? multiple "bug:" lines?) [23:27:10] https://m.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Phabricator [23:28:09] [telegram] "If a patch resolves two or more bugs, put each `Bug: T12345` reference on its own line at the bottom." [23:28:25] [telegram] oooh didn't know it'd link that example