[00:48:06] [telegram] *Y_es Hello Everyone promo has done it again within 18hours of trading with $800 I was able to make $9520 I just got my payout join Mr Bryan class*_ [00:48:06] [telegram] [00:48:07] [telegram] t.me/joinchat/Yh_uwLj5wyljMjI0 [00:48:08] [telegram] t.me/joinchat/Yh_uwLj5wyljMjI0 [00:52:42] [telegram] /stat@combot [04:59:47] [telegram] I have a project here, no investment, no risk, daily profit. , + @Muqing676 [08:15:54] [telegram] And our fortnightly Wikipedia downtime is here... [08:16:38] [telegram] Yep, icinga is being very spammy so I assume people are working on it [08:17:57] [telegram] This time it even is indicated on https://www.wikimediastatus.net/ so I guess it is a bigger thing than before [08:18:19] [telegram] That's manually updated. It just means they've had enough time. [08:18:30] [telegram] The last few ones were not very long outages [08:37:58] [telegram] Everything seems back to normal [16:27:50] [telegram] Hi all! I have a question about PHP's date format syntax. I recently tried adding the entry `'dmy date' => 'j "di" F "di" Y'` to the `$dateFormats` array in `MessagesKea.php`, but apparently that syntax didn't work (see comment thread here (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/795872/1..3/languages/messages/MessagesKea.php#b47)), so I had to resort to the format `'j \d\i F \d\i Y'`. Can anyone h [18:09:53] [telegram] php > var_dump( date_format( new DateTime(), 'j "di" F "di" Y' ) ); [18:09:54] [telegram] string(26) "12 "1209" June "1209" 2022" [18:24:26] [telegram] But as you can see in the comments on Gerrit, the "di" format is used in other languages without problems (re @tehreedy: php > var_dump( date_format( new DateTime(), 'j "di" F "di" Y' ) ); [18:24:26] [telegram] string(26) "12 "1209" June "1209" 2022") [18:29:26] [telegram] Thanks, Jon. I meant to copy that here but had to go AFK for a while 😅 (re @jhsoby: But as you can see in the comments on Gerrit, the "di" format is used in other languages without problems) [18:42:08] [telegram] Unfortunately, Amir's comment of "and causes the wiki to break" isn't substantiated with any apparent logs :P [18:42:17] [telegram] And https://integration.wikimedia.org/ci/job/mediawiki-quibble-composertest-php72-docker/68831/console : FAILURE in 50s has been removed [18:42:56] [telegram] Put a patchset ontop of it (or git HEAD), with the original version [18:43:05] [telegram] See what the failure is.. And maybe it'll be more obvious [19:12:42] [telegram] https://gerrit.wikimedia.org/r/804766 [19:18:08] [telegram] And mediawiki-quibble-composertest-php72-docker has passed... [19:31:32] [telegram] huh, weird... could it be due to the first patch using the deprecated array creation syntax? Maybe I'll try a patch normalizing those patterns, then. [19:32:21] [telegram] the long array syntax could've accounted for that test failing, yeah (and it would be expected to)... [19:32:32] [telegram] But that wouldn't have caused the wiki to break [19:36:51] [telegram] I referred to my local wiki. It couldn't load any pages when I tried it with the older version of that patch. (re @tehreedy: Unfortunately, Amir's comment of "and causes the wiki to break" isn't substantiated with any apparent logs :P) [19:39:02] [telegram] From what I can tell, the escaped string syntax is only used in MessagesGl.php, MessagesPt.php, and now also MessagesKea.php. All the others use double-quoted strings or even plain Unicode characters within the single-quoted string (I'm assuming they don't match any of the date format characters) [19:39:40] [telegram] ^ seems to not cause any errors on my wiki (re @tehreedy: https://gerrit.wikimedia.org/r/804766) [19:39:48] [telegram] I'll submit a patch changing those three files and we can check if anything breaks [19:39:59] [telegram] Standardisation is good :) [19:40:16] [telegram] (Or would you prefer me to reuse your patch, Sam?) [19:40:29] [telegram] (in case that's even possible) [19:40:34] [telegram] Feel free to create your own [19:40:41] [telegram] Ok, on it. [19:40:43] [telegram] With the right permissions you could indeed take over mine [19:40:59] [telegram] But for something relatively simple like this, I don't see much point [19:43:07] [telegram] Hopefully we can work out why Amir's wiki was unhappy too [19:44:04] [telegram] Do you think having strings concatenated with regular dare formatting characters, without spaces, like` ``'H"h"i"min"'` in `MessagesPt.php`, may cause a problem? [19:47:58] [telegram] I think the format is supposed to be pretty flexible [19:48:52] [telegram] Alright, here goes :) https://gerrit.wikimedia.org/r/c/mediawiki/core/+/804770 [21:00:31] [telegram] @amire80 When you get chance, I'd be curious to see if that works on your wiki [21:08:58] [telegram] @waldyrious I'm adding you to the CI magic list so that it will automatically run tests on your patches [21:16:26] [telegram] Oh, I appreciate that :) I'm not sure it's warranted (it's been several years since I've been anything close to a frequent committer), but I'm assuming my presence in the list won't add friction to others, so thank you! (re @tehreedy: @waldyrious I'm adding you to the CI magic list so that it will automatically run tests on your patches) [21:17:26] [telegram] Even if you're doing it infrequently... It's nice when it just works ;) [22:05:24] the bar for the allow list is "not obviously malicious"