[05:53:44] <wm-bb>	 <cvictorovich> Still IE users out there?
[05:54:25] <wm-bb>	 <cvictorovich> If there's barely IE users nowadays I may try to drop IE support for extensions
[05:58:25] <wm-bb>	 <Nikki> https://www.mediawiki.org/wiki/Compatibility#Browsers is what mediawiki supports - IE11 has basic support but doesn't get javascript
[05:59:12] <wm-bb>	 <cvictorovich> May you see my codes? I can open a port on my system and let you in (re @Nikki: https://www.mediawiki.org/wiki/Compatibility#Browsers is what mediawiki supports - IE11 has basic support but doesn't get javasc...)
[05:59:22] <wm-bb>	 <cvictorovich> Editing on VSC
[06:00:41] <wm-bb>	 <cvictorovich> https://prod.liveshare.vsengsaas.visualstudio.com/join?F77A1D60752A4DE18ADA50DECCA8487BDFEF
[06:03:02] <wm-bb>	 <cvictorovich> Here I'm trying to migrate some of interface objects into OOUI objects as well as restructure the js (maybe move some of code blocks into PHP?), therefore I'm asking for help, especially on common good practices
[06:05:29] <wm-bb>	 <cvictorovich> Yeah, my current project is migrate current HotCat gadget into an extension. I wrote some hook files and extension.json, making the script able to load. But how I can optimize current structure?
[06:14:05] <wm-bb>	 <Nikki> I don't have time right now, but I don't think that's something I could help with anyway :( I'm not sure what's considered good practice
[06:15:21] <wm-bb>	 <cvictorovich> How to load OOUI objects correctly?
[07:27:46] <wm-bb>	 <cvictorovich> https://gerrit.wikimedia.org/r/c/mediawiki/extensions/HotCat/+/959146
[07:28:02] <wm-bb>	 <cvictorovich> Can my changes get reviewed?
[08:52:47] <wm-bb>	 <vikipolimer> ```
[08:52:48] <wm-bb>	 <vikipolimer> "ResourceModules": {
[08:52:49] <wm-bb>	 <vikipolimer>         "ext.HotCat": {
[08:52:51] <wm-bb>	 <vikipolimer>             "dependencies": [
[08:52:52] <wm-bb>	 <vikipolimer>                 "mediawiki.util",
[08:52:54] <wm-bb>	 <vikipolimer>                 "mediawiki.user",
[08:52:55] <wm-bb>	 <vikipolimer>                 "mediawiki.Title",
[08:52:57] <wm-bb>	 <vikipolimer>                 "mediawiki.api",
[08:52:58] <wm-bb>	 <vikipolimer>                 "oojs-ui-core",
[08:53:00] <wm-bb>	 <vikipolimer>                 "oojs-ui-windows",
[08:53:01] <wm-bb>	 <vikipolimer>                 "oojs-ui-widgets",
[08:53:03] <wm-bb>	 <vikipolimer>                 "oojs-ui.styles.icons-interactions",
[08:53:04] <wm-bb>	 <vikipolimer>                 "oojs-ui.styles.icons-movement",
[08:53:06] <wm-bb>	 <vikipolimer>                 "oojs-ui.styles.icons-content",
[08:53:07] <wm-bb>	 <vikipolimer>                 "oojs-ui.styles.icons-moderation",
[08:53:09] <wm-bb>	 <vikipolimer>                 "oojs-ui-toolbars",
[08:53:10] <wm-bb>	 <vikipolimer>                 "oojs-ui.styles.icons-editing-core",
[08:53:12] <wm-bb>	 <vikipolimer>                 "oojs-ui.styles.icons-layout",
[08:53:13] <wm-bb>	 <vikipolimer>                 "oojs-ui.styles.icons-user",
[08:53:15] <wm-bb>	 <vikipolimer>                 "oojs-ui.styles.icons-media",
[08:53:16] <wm-bb>	 <vikipolimer>                 "oojs-ui.styles.icons-editing-advanced"
[08:53:18] <wm-bb>	 <vikipolimer>             ]
[08:53:19] <wm-bb>	 <vikipolimer> ...```
[08:53:21] <wm-bb>	 <vikipolimer>  (re @cvictorovich: How to load OOUI objects correctly?)
[08:53:22] <wm-bb>	 <cvictorovich> Oh my!
[08:53:29] <wm-bb>	 <cvictorovich> All these are required?
[08:55:16] <wm-bb>	 <vikipolimer> You can just use what you need.
[08:55:43] <wm-bb>	 <cvictorovich> I don't really know...
[08:55:45] <wm-bb>	 <vikipolimer> If you want to use icons you need yo add the icon group.
[08:55:54] <wm-bb>	 <cvictorovich> （首）
[08:56:17] <wm-bb>	 <vikipolimer> ```
[08:56:18] <wm-bb>	 <vikipolimer> "oojs-ui-core",
[08:56:19] <wm-bb>	 <vikipolimer>                 "oojs-ui-windows",
[08:56:21] <wm-bb>	 <vikipolimer>                 "oojs-ui-widgets",
[08:56:23] <wm-bb>	 <vikipolimer> ```
[08:56:24] <wm-bb>	 <vikipolimer> 
[08:56:25] <wm-bb>	 <vikipolimer> 
[08:56:27] <wm-bb>	 <vikipolimer> You need to use this three anyway
[08:57:43] <wm-bb>	 <cvictorovich> "oojs-ui.styles.icons-interactions",
[08:57:43] <wm-bb>	 <cvictorovich>                 "oojs-ui.styles.icons-movement",
[08:57:45] <wm-bb>	 <cvictorovich>                 "oojs-ui.styles.icons-content",
[08:57:46] <wm-bb>	 <cvictorovich>                 "oojs-ui.styles.icons-moderation"
[08:58:13] <wm-bb>	 <cvictorovich> Can these ben invoked with "oojs-ui.styles" or something?
[08:59:40] <wm-bb>	 <vikipolimer> Nope :/ You have to use the icon group (re @cvictorovich: Can these be invoked with "oojs-ui.styles" or something?)
[09:01:52] <wm-bb>	 <cvictorovich> Is there icons for tick/cross in these koleksiyons?
[09:04:07] <wm-bb>	 <vikipolimer> You can check the OOUI icons set here:
[09:04:09] <wm-bb>	 <vikipolimer> 
[09:04:10] <wm-bb>	 <vikipolimer> https://doc.wikimedia.org/oojs-ui/master/demos/?page=icons&theme=wikimediaui&direction=ltr&platform=desktop
[09:04:31] <wm-bb>	 <cvictorovich> Wow, helpful!
[09:04:45] <wm-bb>	 <vikipolimer> https://doc.wikimedia.org/oojs-ui/master/js/
[09:06:19] <wm-bb>	 <cvictorovich> Now that I should invoke icons in js
[09:07:09] <wm-bb>	 <cvictorovich> Is it iconWidget?
[09:08:14] <wm-bb>	 <vikipolimer> nope (re @cvictorovich: Now that I should invoke icons in js)
[09:09:03] <wm-bb>	 <vikipolimer> If you want to use any icon from any icon group you need to add that group to the dependencies.
[09:09:22] <wm-bb>	 <cvictorovich> Dependencies added
[09:09:52] <wm-bb>	 <cvictorovich> I need to use an icon in my existing JS
[09:11:10] <wm-bb>	 <vikipolimer> So you can use icons in elements
[09:12:00] <wm-bb>	 <vikipolimer> Check the elements using on this documentation. (re @vikipolimer: https://doc.wikimedia.org/oojs-ui/master/js/)
[09:12:51] <wm-bb>	 <cvictorovich> I've been wondering where to invoke "append"
[09:14:35] <wm-bb>	 <vikipolimer> ```
[09:14:36] <wm-bb>	 <vikipolimer> // An IconWidget with a label via LabelWidget.
[09:14:37] <wm-bb>	 <vikipolimer> var myIcon = new OO.ui.IconWidget( {
[09:14:39] <wm-bb>	 <vikipolimer>         icon: 'help',
[09:14:40] <wm-bb>	 <vikipolimer>         title: 'Help'
[09:14:42] <wm-bb>	 <vikipolimer>      } ),
[09:14:43] <wm-bb>	 <vikipolimer>      // Create a label.
[09:14:45] <wm-bb>	 <vikipolimer>      iconLabel = new OO.ui.LabelWidget( {
[09:14:46] <wm-bb>	 <vikipolimer>          label: 'Help'
[09:14:48] <wm-bb>	 <vikipolimer>      } );
[09:14:49] <wm-bb>	 <vikipolimer>  $( document.body ).append( myIcon.$element, iconLabel.$element );```
[09:14:54] <wm-bb>	 <cvictorovich> I'm using it
[09:15:02] <wm-bb>	 <vikipolimer> Like this.
[09:15:39] <wm-bb>	 <cvictorovich> But where would (document.body).append append my objects?
[09:16:15] <wm-bb>	 <jhsoby> that would just add it to the end of the <body> element. but instead of that, you can append it to any jquery object you want (re @cvictorovich: But where would (document.body).append append my objects?)
[09:16:20] <wm-bb>	 <vikipolimer> Oh, you can choose some another element instead of document body.
[09:16:45] <wm-bb>	 <vikipolimer> It adds element to the your doucument. (re @vikipolimer: // An IconWidget with a label via LabelWidget.
[09:16:46] <wm-bb>	 <vikipolimer> var myIcon = new OO.ui.IconWidget( {
[09:16:48] <wm-bb>	 <vikipolimer>         icon: 'help',
[09:16:49] <wm-bb>	 <vikipolimer>         title: 'Help'
[09:16:51] <wm-bb>	 <vikipolimer> ...)
[09:17:32] <wm-bb>	 <cvictorovich> Maybe both of you should see my codes
[09:17:49] <wm-bb>	 <vikipolimer> ```
[09:17:49] <wm-bb>	 <vikipolimer> $('.your-chosen-class').append(yourOOUIelement.$element);```
[09:17:51] <wm-bb>	 <cvictorovich> The old UI objects are appending somewhere
[09:19:05] <wm-bb>	 <vikipolimer> ```
[09:19:06] <wm-bb>	 <vikipolimer> var myIcon = new OO.ui.IconWidget( {
[09:19:07] <wm-bb>	 <vikipolimer>         icon: 'help',
[09:19:09] <wm-bb>	 <vikipolimer>         title: 'Help'
[09:19:10] <wm-bb>	 <vikipolimer>      } ),
[09:19:12] <wm-bb>	 <vikipolimer>      iconLabel = new OO.ui.LabelWidget( {
[09:19:13] <wm-bb>	 <vikipolimer>          label: 'Help'
[09:19:15] <wm-bb>	 <vikipolimer>      } );
[09:19:16] <wm-bb>	 <vikipolimer>  $('.your-chosen-class').append(myIcon.$element);```
[09:20:49] <wm-bb>	 <cvictorovich> https://prod.liveshare.vsengsaas.visualstudio.com/join?F77A1D60752A4DE18ADA50DECCA8487BDFEF
[09:21:00] <wm-bb>	 <cvictorovich> Here you can see what I'm doing
[09:21:39] <wm-bb>	 <cvictorovich> I'm actually changing an object inside an array (?)
[09:22:19] <wm-bb>	 <vikipolimer> Could you please share your snippet?
[09:24:33] <wm-bb>	 <cvictorovich> Too long, please wait
[09:24:51] <wm-bb>	 <cvictorovich> existsYes: new OO.ui.IconWidget( {
[09:24:51] <wm-bb>	 <cvictorovich>       icon: 'check'
[09:24:52] <wm-bb>	 <cvictorovich>     } ),
[09:24:54] <wm-bb>	 <cvictorovich>     iconLabel: new OO.ui.LabelWidget( {
[09:24:55] <wm-bb>	 <cvictorovich>       label: ''
[09:24:57] <wm-bb>	 <cvictorovich>     }),
[09:24:58] <wm-bb>	 <cvictorovich>     existsNo: "../src/images/Feather-core-x.svg",
[09:25:05] <wm-bb>	 <cvictorovich> addShortcuts: function ( map ) {
[09:25:06] <wm-bb>	 <cvictorovich>       if ( !map ) return;
[09:25:07] <wm-bb>	 <cvictorovich>       window.HotCat.shortcuts = window.HotCat.shortcuts  {};
[09:25:09] <wm-bb>	 <cvictorovich>       for ( var k in map ) {
[09:25:10] <wm-bb>	 <cvictorovich>         if ( !map.hasOwnProperty( k )  typeof k !== 'string' ) continue;
[09:25:12] <wm-bb>	 <cvictorovich> 
[09:25:13] <wm-bb>	 <cvictorovich>         var v = map[ k ];
[09:25:15] <wm-bb>	 <cvictorovich>         if ( typeof v !== 'string' ) continue;
[09:25:16] <wm-bb>	 <cvictorovich> 
[09:25:18] <wm-bb>	 <cvictorovich>         k = k.replace( /^\s+|\s+$/g, '' );
[09:25:19] <wm-bb>	 <cvictorovich>         v = v.replace( /^\s+|\s+$/g, '' );
[09:25:21] <wm-bb>	 <cvictorovich>         if ( !k.length || !v.length ) continue;
[09:25:22] <wm-bb>	 <cvictorovich> 
[09:25:24] <wm-bb>	 <cvictorovich>         window.HotCat.shortcuts[ k ] = v;
[09:25:25] <wm-bb>	 <cvictorovich>       }
[09:25:27] <wm-bb>	 <cvictorovich>     }
[09:26:13] <wm-bb>	 <cvictorovich> All of these are in a "var HC = window.HotCat = {}"
[09:27:05] <wm-bb>	 <cvictorovich> If this works, I'd remove those icons from my package
[09:27:55] <wm-bb>	 <vikipolimer> Define a variable for this icon element and append it. (re @cvictorovich: existsYes: new OO.ui.IconWidget( {
[09:27:55] <wm-bb>	 <vikipolimer>       icon: 'check'
[09:27:57] <wm-bb>	 <vikipolimer>     } ),
[09:27:58] <wm-bb>	 <vikipolimer>     iconLabel: new OO.ui.LabelWidget( {
[09:28:00] <wm-bb>	 <vikipolimer>       label: ''
[09:28:01] <wm-bb>	 <vikipolimer>     }),
[09:28:03] <wm-bb>	 <vikipolimer> ...)
[09:31:07] <wm-bb>	 <cvictorovich> Outside the original func
[09:31:21] <wm-bb>	 <cvictorovich> ?
[09:34:22] <wm-bb>	 <cvictorovich> Well, seems all these are related to another function
[09:34:53] <wm-bb>	 <cvictorovich> Unsure if appending is done there
[09:38:22] <wm-bb>	 <cvictorovich> Are OOUI buttons/input areas the same?
[10:03:17] <andre>	 Please do NOT paste dozens of code lines here. It's spamming IRC.
[10:03:24] <andre>	 Use Pastebins.
[10:14:57] <wm-bb>	 <cvictorovich> Sorry for not knowing this (re @wmtelegram_bot: <andre> Use Pastebins.)
[10:23:01] <wm-bb>	 <cvictorovich> https://phabricator.wikimedia.org/P52538
[10:23:19] <wm-bb>	 <cvictorovich> Okay, I posted that snippet here
[14:49:23] <wm-bb>	 <George> /stat@combot
[15:24:23] <wm-bb>	 <George> /stat@combot
[16:05:36] <wm-bb>	 <andreklapper> Thanks. What's your specific question?
[16:07:46] <wm-bb>	 <cvictorovich> Are you talking to me? (re @andreklapper: Thanks. What's your specific question?)
[16:08:19] <wm-bb>	 <andreklapper> Yes, you posted last here.
[16:09:26] <wm-bb>	 <cvictorovich> I’m attempting to implement current objects (for instance, buttons) with OOUI objects
[16:09:59] <wm-bb>	 <cvictorovich> Whenever I replace original objects it cannot work at all
[16:10:41] <wm-bb>	 <cvictorovich> Also, some of these codes might should be implemented with PHP?
[16:10:56] <wm-bb>	 <cvictorovich> Some maybe even in CSS
[16:12:32] <wm-bb>	 <cvictorovich> Currently version on js is clunky but don’t know how to reorganize
[16:12:50] <wm-bb>	 <andreklapper> Okay. Do you have a **specific*** qyestion?
[16:13:05] <wm-bb>	 <cvictorovich> This one! (re @cvictorovich: I’m attempting to implement current objects (for instance, buttons) with OOUI objects)
[16:13:30] <wm-bb>	 <cvictorovich> No OOUI objects can be displayed
[16:13:34] <wm-bb>	 <andreklapper> I don't see a question.
[16:13:59] <wm-bb>	 <andreklapper> What does happen instead? (re @cvictorovich: No OOUI objects can be displayed)
[16:14:04] <wm-bb>	 <cvictorovich> See commented out codes
[16:16:29] <wm-bb>	 <andreklapper> Too many comments. Which specific one? (re @cvictorovich: See commented out codes)
[16:16:41] <wm-bb>	 <cvictorovich> https://tools-static.wmflabs.org/bridgebot/5dae8f27/file_52632.jpg
[16:17:04] <wm-bb>	 <andreklapper> Context?
[16:17:42] <wm-bb>	 <cvictorovich> https://tools-static.wmflabs.org/bridgebot/9c131e8c/file_52633.jpg
[16:17:57] <wm-bb>	 <cvictorovich> The original code, also what I intended
[16:18:18] <wm-bb>	 <andreklapper> You posted screenshot. Not code.
[16:18:34] <wm-bb>	 <andreklapper> And my question was which commented line.
[16:18:51] <wm-bb>	 <andreklapper> And what happens. And what should happen instead.
[16:19:55] <wm-bb>	 <cvictorovich> https://phabricator.wikimedia.org/P52545
[16:19:57] <wm-bb>	 <andreklapper> People likely will not read and review 150 lines of code without a minimal and self-contained testcase and a clear and specific description of a problem
[16:20:17] <wm-bb>	 <cvictorovich> This one contains the code in question
[16:20:30] <wm-bb>	 <andreklapper> Too many lined
[16:20:35] <wm-bb>	 <andreklapper> *lines
[16:20:45] <wm-bb>	 <cvictorovich> Line 22-48
[16:21:00] <wm-bb>	 <andreklapper> Which comment in lines 22-48?
[16:21:19] <wm-bb>	 <cvictorovich> I preserved the original code and commented out what I wrote
[16:21:57] <wm-bb>	 <cvictorovich> Those 2 comment blocks are OOUI buttons I wrote
[16:22:45] <wm-bb>	 <andreklapper> And what's the problem?
[16:24:21] <wm-bb>	 <cvictorovich> When I replace the original js-style buttons with OOUI ones, the input fields and buttons cannot display when clicking on + link, only generating more + links
[16:25:21] <wm-bb>	 <cvictorovich> As is seen on my screenshots above
[16:26:46] <wm-bb>	 <cvictorovich> The input field shown above should be an OOUI one as well
[16:37:05] <wm-bb>	 <cvictorovich> Is my question specific enough?