[07:07:21] I generally don't think that videostreams to look at code (text) are popular... (re @cvictorovich: Nikki, may you connect to my VSC session?) [07:08:12] Not video stream, that's about collab editing... [07:08:38] I merged all previous changes in the repo [07:09:01] https://gerrit.wikimedia.org/g/mediawiki/extensions/HotCat [07:19:38] Forwarded from penchan76: Have a nice day [07:21:37] OOUI buttons are still not loading [07:21:57] None is functioning well [08:21:07] collaborative editing needs a lot more time/effort/attention than looking at a diff or a small bit of code though. I usually look at diffs or code snippets while working on other things (e.g. while waiting for something to run/load), while eating, while travelling, etc (re @cvictorovich: Not video stream, that's about collab editing...) [08:24:30] yesterday when you asked, I didn't even have time to respond because I was in the middle of going somewhere with someone [08:28:29] looking at the most recent commit, there are lots of whitespace changes that don't follow mediawiki's coding conventions - https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript (re @cvictorovich: https://gerrit.wikimedia.org/g/mediawiki/extensions/HotCat) [08:30:01] But it isn’t a major problem to deal with currently! [08:30:54] I would surely fix that in later commits, now I have to make it run properly! [08:32:47] when I want to do whitespace changes, I normally put them in a separate commit/edit, because they make it hard to see what else is being changed [08:38:58] I'm bad at only changing one thing at a time though, so often when I go to commit/save changes, I realise I've made multiple unrelated changes that I don't want to group together, then I often have to make a copy of my current version, restore the original, and copy over only the changes I want to include in the commit >_< [08:39:40] We're the same in this way: do multiple things in a commit... [08:42:50] sometimes I'm lucky and can use `git add` to only add certain files, or `git add -p` to split changes in a file into chunks, other times it's almost as much work to split the changes as it was to make the changes originally [08:43:58] but whenever I need to go back and look at what was changed, I don't regret splitting things up :P [08:45:40] We can come back to current codes... [08:46:07] My problems above is existing [09:32:24] Look at "this.OK.setFlags" line [09:33:06] My local debugger is throwing "Cannot read properties of undefined" error here