[11:14:30] btullis: opinion on task :) [15:08:53] https://gerrit.wikimedia.org/r/c/operations/software/homer/deploy/+/976749 this is to not need stuff like https://gerrit.wikimedia.org/r/c/operations/homer/public/+/975225 [15:13:12] 👀 [15:27:03] XioNoX: AIUI this would replace the required config/{sites|devices}.yaml patch with clicking something in netbox? [15:27:25] (sorry for the pretty ignorant way to put this :)) [15:27:34] jayme: clicking something in netbox (or using the API) + running homer [15:27:49] yeah, running homer for sure. That does not change [15:28:57] sgtm...assuming you feel that's a better solution then the cookbook [15:38:37] jayme: it's a different tradeoff and looks like this approach was prefered so I'm fine with it [15:39:13] I'm still not 100% sure on how to structure the netbox custom field (the "clicking something" part) [15:39:37] boolean, full group list, etc [15:39:49] you mean the different approaches you've thankfully described in the commit message [15:39:56] yeah...I'm not sure either [15:40:19] would that be hard to change in the future? [15:41:05] like if we go with what you've implemented now and feel like we need the "BGP group" field later? [15:45:33] it's work I don't think anyone would like doing :) [15:45:40] hrhr [15:45:52] not *that* hard, but annoying [15:48:01] AIUI the 'A "routing" selection field' could be a drop down with only valid groups. Is that correct? [15:49:44] jayme: yeah it can be anything, you can safely play with them in https://netbox-next.wikimedia.org/extras/custom-fields/ (create, edit, etc) and a description of all the options in https://docs.netbox.dev/en/stable/customization/custom-fields/ [15:50:29] it's a question of what should we expose to the operator vs. what to abstract [15:52:31] got it. I'm just not very familiar with netbox and was not sure if that would mean a free text field which would be very error prone I suppose [15:54:44] yep, free text would be bad :) [15:55:26] drop down also have the risk of growing forever and becoming a pain to use (other than through APIs) [16:02:37] I still opted for that now to be prepared for the future...but ultimately I'm not sure [16:05:56] yeah not straightforward, let's see what others think [16:06:15] * jayme nods