[13:38:33] jayme: would you be able to assist me on something deployment-charts CI related? I've recenty added `version: 1.23` for de-k8s-eqiad in https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/refs/heads/production/hieradata/common/kubernetes.yaml#876 to ensure that we select the right helm3 binary for all releases in dse-k8s [13:38:33] (https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1259838) [13:39:29] however, the CI always fails with (in effect) `no such value kubernetesVersion`, even if I can see it under .fixtures/general-dse-k8s-eqiad.yaml [13:42:29] in ./helmfile.yaml: error during ../global.yaml.part.0 parsing: template: stringTemplate:1:49: executing "stringTempl [13:42:29] ate" at <.Values.kubernetesVersion>: map has no entry for key "kubernetesVersion" [13:43:07] oooh, nvm, I know where this is coming from. I'm missing the general file in the release values I think [13:46:09] yeah, that was added (and maybe not to everything) as prep for the 1.31 upgrade...maybe there is an example helmfile somewhere that does not contain it and has been used [13:50:46] confirme, I was missing `- "/etc/helmfile-defaults/general-{{ .Environment.Name }}.yaml"` in the env values [14:06:19] Hello. I'd appreciate a sanity check on this patch please. https://gerrit.wikimedia.org/r/c/operations/puppet/+/1256287 - just because it touches the `kubernetes::clusters_defaults` structure and I don't want to break anything on anyone else's clusters. Thanks. [14:07:31] btullis: can I suggest adding `Hosts: P:kubernetes::master` and running pcc? [14:07:48] cdanis: Will do. Thanks. [14:33:51] Ah, thanks. Yeah, that would have caused some puppet errors and embarrassment.