[06:15:29] legoktm: done! lemme know if I need to add more info or if what I wrote is clear enough [06:33:43] klausman: o/ https://docs.celeryproject.org/en/stable/history/whatsnew-5.0.html#new-command-line-interface for the celery arg thing [09:29:03] Ah, thanks. Just as I thought [09:30:37] :) [09:31:26] so I am trying to add support for TLS to the istio ingress gateway, but the https config (that includes the TLS secret) must be done in knative-serving, since it is there that we define L7 routing/configs/etc.. [09:31:49] the caveat is that the TLS secret needs to be created in the istio namespace, from a helm deploy for knative-serving [09:32:03] that according to what serviceops says, may be a little weird for helm [09:33:39] so Janis suggested something like https://phabricator.wikimedia.org/P17139 for admin_ng, using the "raw" chart (TIL) [09:34:04] but of course we'll have to pull the secret from the helmfile private config, and somehow make it available in the helmfile.yaml [09:34:11] always lovely to work with helm [10:42:06] * elukey lunch [15:39:11] elukey: lgtm, thanks :) [15:43:50] morning all [15:44:03] Slack is down for me, so I assume that means all the managers get the day off [15:58:28] morning :) [16:05:34] FIXED! [16:05:47] Used my deep front end experience and wiped cookies [16:09:22] ^ LOL [16:09:29] also good morning [16:17:10] accraze: o/ I didn't ask yesterday, do you want a task to track the transition of docker images to multi-stage build? [16:17:20] it can be done slowly, no pressure [16:18:12] elukey: yeah i was literally thinking we should make one when I was I was signing off yesterday [16:19:51] going to create one :) [16:20:08] I just checked the docker registry btw, and IIUC it pulls images from swift [16:20:35] this is why it is probably not a huge concern [16:20:47] aha! that is good to know :) [16:21:57] i still think it's good that we continue trimming the images where we can, especially if we can leverage the streaming technique in the future [16:23:36] 10Machine-Learning-Team: Move ML docker images to multi-stage build - https://phabricator.wikimedia.org/T290266 (10elukey) p:05Triage→03Medium [16:23:45] created --^ [16:24:00] didn't add a lot of details since most of them are in the code review, but in case I can be more verbose [16:25:12] awesome, i can start looking into the other model-servers later today [16:25:29] i think they should all be similar (minus the topic model server) [16:38:16] I think so yes! [16:48:10] btw I did a spike using poetry to handle python deps yesterday [16:48:20] it's definitely got a nice developer ux [16:48:51] but it doesn't really help our backtracking issue since revscoring & model repos use ranges for the versions [16:49:38] i think just explicitly pinning versions in requirements.txt is the easiest solution for now [16:50:20] really sad position but I agree [16:50:37] is there a github issue for this opened to upstream? I guess that we are not the only ones impacted [16:51:17] https://github.com/pypa/pip/issues/10235 [16:52:32] ^ not even sure that having a 'deepness' option would help us since some of the libraries that cause us pain are deps of deps of deps... [16:55:53] other solutions i've seen people mention are just using older versions of pip (pre v21.x.x) with the ` --use-deprecated=legacy-resolver`option but that's more of a temporary fix [17:02:46] yeah :( [17:56:52] * elukey afk! [18:52:33] 10Machine-Learning-Team: Move ML docker images to multi-stage build - https://phabricator.wikimedia.org/T290266 (10ACraze) [18:52:37] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks), 10Patch-For-Review: Production images for ORES/revscoring models - https://phabricator.wikimedia.org/T279004 (10ACraze) [19:19:39] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks), 10Patch-For-Review: Production images for ORES/revscoring models - https://phabricator.wikimedia.org/T279004 (10ACraze) Quick update on our progress - We now have model server images published in the [[ https://docker-registry.wikimedia.org/ | WMF Docker R... [21:44:06] 10Machine-Learning-Team: Move ML docker images to multi-stage build - https://phabricator.wikimedia.org/T290266 (10ACraze) Nice job @elukey! Confirming that the `2021-09-01-140944-production` version of [[ https://docker-registry.wikimedia.org/wikimedia/machinelearning-liftwing-inference-services-editquality/ta...