[07:59:57] elukey: I will review that helm change (719128) today [08:02:03] One question: is there a convention on maximum line length in the charts? At least Gerrit wraps a lot of the comments. [08:02:32] klausman: o/ no hurry I think it is probably something that needs a follow up, serviceops will likely tell me that I didn't get half of how things are done in the repo :D [08:02:41] no idea about a rule, we can use anything [08:02:53] I think the common values are 80c or 100c [08:03:33] I have no objection to keeping non-comment lines longer if it makes the code more readable/using no line continuations), but I think prose/comments should be wrapped for readability [08:04:24] I think the Gerrit limit is 100c (or maybe that is a eper-user setting? [08:04:29] s/eper/per/ [08:05:49] sure [08:51:34] 10Lift-Wing, 10Machine-Learning-Team, 10Patch-For-Review: Create a LB service for inference.discovery.wmnet - https://phabricator.wikimedia.org/T289835 (10elukey) Allocated two IPs for the new service in netbox: https://netbox.wikimedia.org/ipam/ip-addresses/8994/ https://netbox.wikimedia.org/ipam/ip-addres... [09:41:26] 10Lift-Wing, 10Machine-Learning-Team, 10Patch-For-Review: Create a LB service for inference.discovery.wmnet - https://phabricator.wikimedia.org/T289835 (10elukey) Reserved port 4688 in https://wikitech.wikimedia.org/wiki/Kubernetes/Service_ports, will amend istio config in a bit. [10:24:37] * elukey lunch! [15:51:05] 10Lift-Wing, 10Machine-Learning-Team, 10Patch-For-Review: Create a LB service for inference.discovery.wmnet - https://phabricator.wikimedia.org/T289835 (10elukey) Interesting thing happened while trying to configure https://gerrit.wikimedia.org/r/719227 - we cannot specify, in Pybal, a port for health checks... [15:58:03] * elukey afk! [16:54:07] o/ [16:54:23] just getting caught up on some of the code review discussion from elukey and kevinbazira [16:54:56] i think we might be on to something by only including NLTK in the `build` variant [17:07:10] accraze: o/ [17:07:31] I was afk, anything not working with nltk? [17:09:55] IIUC what the downloader does is just store files under the home dir of the user (unless specified otherwise) [17:10:21] yep i think that's correct... going to try it out on articlequality today, kevinbazira says he could retrieve a prediction for topic model w/o nltk [17:10:36] i think we might be using the stopwords for features somewhere but not sure [17:10:44] ah wow! [17:10:59] so we could reduce even more the size of the image [17:11:13] yep that's what i'm thinking :) [17:13:21] \o/ [23:33:05] ahh bummer -- it seems the articlequality model server won't load when we exclude nltk from the `production` variant [23:33:36] this is due to revscoring needing stopwords for revscoring.languages.english features :( [23:34:00] this will likely be the case for the other models (maybe not topics though...)