[15:42:39] o/ [15:45:46] o/ [15:46:23] I need to merge some changes for the https egress gateway, but from my manual tests it seems to work for the editquality pod! [16:07:05] niiiiice! [16:15:39] ITS HAPPENING [16:15:40] elukey: is it cool if i deploy the updated articlequality image? [16:16:09] (thx for the +2 and merge btw :) ) [16:16:09] accraze: please go ahead, no issues from my side :) [16:16:30] I have 3 code reviews to merge [16:16:37] https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/745555 (and the rest of the chain) [16:16:48] the last one is probably the one that most of us should review [16:17:37] ack, will look at it in a sec after i deploy articlequality [16:17:42] yep yep! [16:18:00] super nice thing is that I can see egress gw metrics [16:18:27] the last step is to configure rate limit on the egress gw side [16:18:35] still not sure how it is done, but I'll investigate [16:23:12] ok deploy is done and confirming the predictor works! [16:23:23] gooooood [16:23:30] all services on ml-serve are running kserve now :) [16:23:44] \o/ [16:23:48] the deploy process is really really nice! [16:23:48] nice job accraze ! [16:24:09] thx elukey :) [16:25:09] ok gonna take a look at your CR now [16:28:06] ah ok i see you are updating the WIKI_URL with the new istio-egress gw [16:28:25] exactly yes [16:28:32] we'll have to work in that way from now on [16:28:46] every time that we need a new endpoint, the egress gw will need to be instructed [16:28:50] and then the pods will call it [16:28:59] it kinda DRYes a little the config too [16:29:32] in the bright future with the istio mesh and autoproxy/discovery/etc.. we'll just use the "real" hostnames, like en.wikipedia.org [16:29:38] and istio will take care or the routing [16:30:47] nice, yeah that makes sense [16:31:37] how should we handle this in dev? i'm still just using the https *.wikipedia.org as wiki url [16:42:05] I think it is fine for the moment, we can then adapt.. [16:57:33] folks I have of course broken the current set up on ml-serve-eqiad, and I have meetings and a run with people right in a few mins [16:57:47] will fix it asap, but for the time being if you see errors blame me :) [17:01:20] no worries elukey! [17:09:01] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks): Lift Wing proof of concept - https://phabricator.wikimedia.org/T272917 (10ACraze) [17:09:25] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks), 10Patch-For-Review: Migrate from Kfserving to Kserve - https://phabricator.wikimedia.org/T293331 (10ACraze) 05Open→03Resolved a:03ACraze All inference-service images in the [[ https://docker-registry.wikimedia.org/ | WMF registry ]] have been upgrade... [17:21:47] * elukey afk!