[08:01:27] going to the dentist, will join later :) [11:31:12] * elukey lunch! [15:35:26] o/ [15:41:20] o/ [15:45:25] accraze: I am still fighting a bit with yaml but I have a draft for kserve-inference [15:46:11] awesome! [15:46:21] i knew there was going to be some yaml horror involved :) [15:55:30] i think where i got confused when looking at the chart was how to structure the transformer config and make it conditional [15:57:11] yes it is tricky, I am trying to make it flexible but helm templating is not so easy [15:57:36] ^^^ [15:58:23] yeah talking it over in the tech meeting yesterday was helpful [15:59:59] i realized it wasn't supposed to be at the individual isvc level, but rather for each inference namespace [16:29:22] 10Machine-Learning-Team, 10artificial-intelligence, 10Wikilabels, 10articlequality-modeling: Build article quality model for Dutch Wikipedia - https://phabricator.wikimedia.org/T223782 (10Halfak) See discussion here about a new iteration of the model. https://nl.wikipedia.org/w/index.php?title=Overleg_geb... [16:50:49] * elukey hates yaml [16:51:24] lol [16:54:31] i knew someone a few years ago who would convert yaml to json to work with it and then convert it back [16:54:44] there are errors like "error converting YAML to JSON: yaml: line 34: mapping values are not allowed in this context" that doesn't tell you a lot about what's wrong [16:54:51] and you can spend hours on it [16:55:37] haha yeah ii'm not sure converting really helps out much in the long run ¯\_(ツ)_/¯ [17:20:50] accraze: https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/747880 is the idea [17:21:04] in the .fixtures dir I put some examples [17:21:18] it should be flexible enough to allow us to introduce transformers gradually [17:21:23] or to change them selectively [17:23:55] Every yaml tutorial is like "See how easy it is!" [17:24:00] with some toy example [17:27:02] ^ this [17:27:10] elukey: cool, taking a look! [17:30:25] going afk for a bit, will read later! [17:33:44] accraze: just updated the cr, there was a little pebcak :) [17:36:28] ack [17:36:41] still reading through, but i think this looks good so far! [17:57:16] nice giving it a +1 for now, this should work to get us started [17:57:52] now we just need to make transformers for editquality, draftquality and topic :) [18:02:12] gotta [18:02:24] gotta go afk for a bit, but will be back [19:55:51] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks): Fix pipeline image publishing workflow - https://phabricator.wikimedia.org/T297823 (10ACraze) Looking at the PipelineLib and Deployment pipeline docs, it seems we will need to define an additional stage (i.e. `publish`) that runs pushes the production image... [20:09:47] accraze: ack will merge tomorrow! [20:09:50] thanks for the review [21:14:32] (03PS1) 10Zabe: Avoid using WikiPage::factory() [extensions/ORES] - 10https://gerrit.wikimedia.org/r/747943 (https://phabricator.wikimedia.org/T297688) [21:17:47] (03CR) 10jerkins-bot: [V: 04-1] Avoid using WikiPage::factory() [extensions/ORES] - 10https://gerrit.wikimedia.org/r/747943 (https://phabricator.wikimedia.org/T297688) (owner: 10Zabe) [22:15:01] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks): Fix pipeline image publishing workflow - https://phabricator.wikimedia.org/T297823 (10ACraze) [22:59:00] (03PS2) 10Zabe: Avoid using WikiPage::factory() [extensions/ORES] - 10https://gerrit.wikimedia.org/r/747943 (https://phabricator.wikimedia.org/T297688)