[06:40:54] good morning folks :) [07:08:37] (03CR) 10Kevin Bazira: [C: 03+2] "LGTM" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/769121 (https://phabricator.wikimedia.org/T294419) (owner: 10Accraze) [07:13:38] (03Merged) 10jenkins-bot: topic: revert to non-transformer architecture [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/769121 (https://phabricator.wikimedia.org/T294419) (owner: 10Accraze) [07:17:40] (03CR) 10Kevin Bazira: [C: 03+2] "LGTM" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/769122 (https://phabricator.wikimedia.org/T300270) (owner: 10Accraze) [07:23:09] (03Merged) 10jenkins-bot: topic: add http error handling [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/769122 (https://phabricator.wikimedia.org/T300270) (owner: 10Accraze) [08:56:48] 10ORES, 10Machine-Learning-Team (Active Tasks): revscoring feature extraction error for Wikidata - https://phabricator.wikimedia.org/T302851 (10elukey) I retrieved the content of https://www.wikidata.org/w/api.php?rvprop=comment%7Ccontentmodel%7Cids%7Cuser%7Csize%7Cuserid%7Ccontent%7Ctimestamp&revids=133490209... [09:20:54] good morning :) [09:22:23] hello! [10:19:43] 10ORES, 10Machine-Learning-Team (Active Tasks): revscoring feature extraction error for Wikidata - https://phabricator.wikimedia.org/T302851 (10elukey) I was able to repro with the following minimal code: ` import mwapi from revscoring import Model from revscoring.extractors import api with open("/srv/deplo... [10:24:02] 10ORES, 10Machine-Learning-Team (Active Tasks): revscoring feature extraction error for Wikidata - https://phabricator.wikimedia.org/T302851 (10elukey) The other similar error for 1585637588 is related to the following `text` value: ` '{{Property documentation}}\n{{China properties}}' ` [10:28:01] aiko: o/ were you able to fix the black formatter issue? [10:29:29] (03PS4) 10AikoChou: editquality: add the ORES augmented feature output [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/767494 (https://phabricator.wikimedia.org/T301766) [10:30:37] elukey: I just sent a new patch [10:32:08] super :) [10:33:29] I hope I fix it. It passed black on my local [10:34:24] yep +2 from CI :) [10:34:35] 🥳 [10:40:19] (03CR) 10Elukey: "Great work Aiko, added some notes for everybody to review related to the names used, nothing more." [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/767494 (https://phabricator.wikimedia.org/T301766) (owner: 10AikoChou) [10:49:56] 10ORES, 10Machine-Learning-Team (Active Tasks): revscoring feature extraction error for Wikidata - https://phabricator.wikimedia.org/T302851 (10elukey) If I try the same code with , the `text` value is something like: ` '{"type":"item","id":"Q104665876","labels":{"pl":{"language":"pl", .... ` That of course... [10:50:54] very interesting --^ [10:51:06] no idea how to follow up though [10:58:57] anyway, good to do some python debugging to break the usual k8s madness :D [11:37:44] (03CR) 10AikoChou: editquality: add the ORES augmented feature output (032 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/767494 (https://phabricator.wikimedia.org/T301766) (owner: 10AikoChou) [11:39:37] * elukey lunch! [11:41:55] (03PS5) 10AikoChou: editquality: add the ORES augmented feature output [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/767494 (https://phabricator.wikimedia.org/T301766) [14:46:06] Good job Aiko! [14:50:24] (03CR) 10Elukey: [C: 03+1] "Left some nits for the comments, but just suggestions. The code LGTM, but I'll let the final +2 to Kevin :)" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/767494 (https://phabricator.wikimedia.org/T301766) (owner: 10AikoChou) [15:29:26] (03PS6) 10AikoChou: editquality: add the ORES augmented feature output [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/767494 (https://phabricator.wikimedia.org/T301766) [15:31:09] chrisalbon: ack! [15:31:25] I have a question for the team - are we going to port the item quality model to liftwing? [15:31:31] (for wikidata) [15:33:21] (03CR) 10AikoChou: "done :)" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/767494 (https://phabricator.wikimedia.org/T301766) (owner: 10AikoChou) [15:46:04] * elukey bbiab! [17:52:20] 10ORES, 10Machine-Learning-Team (Active Tasks): revscoring feature extraction error for wikitext papes in Wikidata - https://phabricator.wikimedia.org/T302851 (10Halfak) [17:56:57] (03CR) 10Kevin Bazira: [C: 03+2] "LGTM!" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/767494 (https://phabricator.wikimedia.org/T301766) (owner: 10AikoChou) [17:58:26] aiko: congrats :) --^ [18:00:39] (03Merged) 10jenkins-bot: editquality: add the ORES augmented feature output [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/767494 (https://phabricator.wikimedia.org/T301766) (owner: 10AikoChou) [18:02:16] 10ORES, 10Machine-Learning-Team (Active Tasks): revscoring feature extraction error for wikitext papes in Wikidata - https://phabricator.wikimedia.org/T302851 (10Halfak) Agreed that the error message could be better. The feature extraction should work on anything that is an entity (Properties, Items, and Lexe... [19:03:41] 10ORES, 10Machine-Learning-Team (Active Tasks): revscoring feature extraction error for wikitext papes in Wikidata - https://phabricator.wikimedia.org/T302851 (10elukey) @Halfak I like the idea, and it should be relatively easy to be implemented in revscoring. We'll need to do the dance of updating revscoring... [23:23:33] 10ORES, 10Machine-Learning-Team (Active Tasks): revscoring feature extraction error for wikitext papes in Wikidata - https://phabricator.wikimedia.org/T302851 (10Halfak) Been overloaded recently. Don't wait for me, but I'll put something together if I get inspired.