[07:41:07] good morning folks! [07:41:13] need to run an errand for ~30 mins, bbl! [10:18:45] folks I created a pull request for the wikidata item quality issue https://github.com/wikimedia/revscoring/pull/517 [10:18:57] still not tested but probably it should make the errors clearer [10:19:13] lemme know your thoughts (credits to Aaron for the overall idea) [11:11:20] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks), 10Patch-For-Review: Experiment with the Istio TLS mesh - https://phabricator.wikimedia.org/T297612 (10elukey) Confirmed with `istioctl manifest generate`, the daemonset is added by default when the istio cni component is enabled. I have filed https://githu... [11:11:32] not great news from the cni testing :( --^ [11:30:02] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks), 10Patch-For-Review: Experiment with the Istio TLS mesh - https://phabricator.wikimedia.org/T297612 (10JMeybohm) Would you try this hack? :-) This rewrites the Daemonset to be a Deployment with 0 replicas. As no Pods will be created, I think this should not... [11:50:15] * elukey lunch! [11:53:53] aiko and elukey, I have added ML-Sandbox docs and examples on how to use it as a development environment: https://wikitech.wikimedia.org/wiki/Machine_Learning/LiftWing/Inference_Services#ML-Sandbox [12:59:05] nice thanks! [14:25:27] made some progress with the istio mesh stuff, now I see the istio-proxy container added, but the storage initializer fails to fetch from swift [14:26:08] I have the strong feeling that the cni plugin adds the iptables rules when the pod is created, but the storage initializer goes before the istio-proxy and fails to query thanos (since it would go through the proxy [14:29:44] * elukey meetings [14:47:53] Morning all [14:54:34] morning! [15:16:44] https://github.com/istio/istio/issues/23802#issuecomment-628035658 [15:16:48] morning! [15:19:19] sooooo we'll need to have a special rule to allow the storage initializer to fetch the model [16:50:12] * elukey afk for a bit! [18:07:42] some progresses in the istio-proxy test, getting closer! [18:20:58] * elukey afk! ttl [20:20:03] (03CR) 10Umherirrender: [C: 03+2] Tests: expected value goes first in PHPUnit assertions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/768079 (owner: 10DannyS712) [20:36:13] (03Merged) 10jenkins-bot: Tests: expected value goes first in PHPUnit assertions [extensions/ORES] - 10https://gerrit.wikimedia.org/r/768079 (owner: 10DannyS712)