[07:26:04] 10Machine-Learning-Team, 10Patch-For-Review: Upgrade ORES to Debian Buster or Bullseye - https://phabricator.wikimedia.org/T303801 (10elukey) From WMCS: May 1, 2022: All active Stretch VMs will be shut down (but not deleted) by WMCS admins. Our VMs in deployment-prep and other places are all Stretch, so movin... [07:26:16] good morning :) [08:08:51] good morning! :) [08:59:47] aiko: o/ if you want and have time I could use some help in testing https://phabricator.wikimedia.org/T302851 [08:59:52] (nothing really urgent) [09:05:59] elukey: sure! what can I help? [09:09:21] aiko: there is a code review opened in github (it should be mentioned in the task), it should work just fine but I'd need a second pair of eyes to confirm/improve it and finally test it [09:09:57] the final goal would be to deploy it to ores as well, so starting with running the revscoring pytest suite could be good (just to see that nothing explodes) [09:10:44] then if everything goes fine we should release another version of revscoring to pypi (never done it, we may need to ask to Aaron about how it was done in the past) [09:10:56] and update the wheel in the ORES wheels repo [09:10:58] etc.. [09:11:22] but please take your time to check the task and the errors, lemme know if all makes sense [09:11:43] I think it is worth doing but an extra opinion is surely good :) [09:20:11] elukey: I see. I'll look into it and ping you if I have any question! :) [10:14:49] Morning :) [11:37:22] * elukey lunch! [12:09:45] I'll be hacking away at the staging k8s changes. While there has been no reply re: IP ranges, I doubt there will be major changes (and even if, search and replace of IP networks isn't too difficult). [14:00:04] elukey: o/ I left a comment to the code review. Also I managed to run pytest using Docker locally, so I added test cases for the patch. https://github.com/AikoChou/revscoring/commit/3570a324f5da212e994c98bf49e2ca2ba4e7fb8c [14:02:26] klausman: you can also ping folks in #serviceops to get a review of the ipranges [14:02:29] aiko: nice! [14:03:20] I'll review it in a bit [14:16:16] Morning [14:28:29] morning! [14:35:07] aiko: I cannot repro the pickle issue that you raised, it is very weird [14:39:41] ah I see why, commenting in the review [15:47:01] I swear, Puppet will be the end of me. [15:49:04] * elukey understands the feeling [15:49:37] At least I'm now at the point whre it's "Oh, forgot that in the private repo" type of errors [15:51:37] elukey: sent you a private repo review :-{ [15:51:39] oops, [15:51:44] :-P <- meant that [15:52:35] klausman: I was looking to your main patch, it looks very good but it seems very big [15:52:53] I don't want to be a party breaker but I'd split it in smaller pieces [15:53:03] Yeah, I think some factoring-out might be in order there [15:53:12] like 1) config of the control plane 2) lvs config 3) worker nodes role [15:53:18] That, too [15:53:37] for now, I keep it "complete" so I don't forget anything. At review time, I can split out bits. [15:53:44] everything can work also with the actual change, but there are many moving parts like pybal confd etc.. [15:53:50] ack perfect :) [16:32:09] noooooooooooooo andy [16:38:34] :( [16:59:02] :'( [17:18:19] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks), 10Patch-For-Review: Return meaningful HTTP responses in Lift Wing's revscoring backends - https://phabricator.wikimedia.org/T300270 (10calbon) Might need some quick review to see if we deployed. [17:31:17] * elukey back in a few! [17:47:23] 10ORES, 10Machine-Learning-Team (Active Tasks): revscoring feature extraction error for wikitext papes in Wikidata - https://phabricator.wikimedia.org/T302851 (10elukey) a:03achou [17:47:40] aiko: assigned ---^ to you since we are working on it together and it is active [17:48:22] o/ Luca, I just checked the code change, it seems you didn’t include changes in tests/features/wikibase/tests/test_revision.py maybe you missed it? [17:49:59] aiko: I did yes, was it in your pull request? [17:50:41] ahh I see [17:51:12] elukey: the test case passed\ [17:52:10] https://www.irccloud.com/pastebin/YWKtxGme/ [17:53:29] yep yep I am watching your commit on your repo [17:55:10] aiko: will fix it tomorrow first thing [17:55:12] elukey: regarding the pickle error, I'll try to figure it out [17:55:38] elukey: :) [17:55:47] ack! One qs about https://phabricator.wikimedia.org/T301766 - are you planning to work on the extended feature for article/drafquality as well? [17:56:20] elukey: yes [17:56:48] perfect, so the update to the other model is not super urgent, we can do it anytime, but let's try to test the other two model types with extended features [17:57:37] ok, got it! :) [17:58:16] super, thanks a lot :) [17:58:29] I am going afk for today, have a nice evening/day folks :) [17:59:04] have a nice evening, Luca :D [18:20:29] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks), 10Patch-For-Review: Return meaningful HTTP responses in Lift Wing's revscoring backends - https://phabricator.wikimedia.org/T300270 (10AikoChou) Checked deployment-chart, only editquality has been deployed. [18:31:50] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks), 10Patch-For-Review: Return meaningful HTTP responses in Lift Wing's revscoring backends - https://phabricator.wikimedia.org/T300270 (10AikoChou) Hmm, editquality image is also not the latest version. Need to deploy as well. [18:34:07] I'm done for today. Have a nice day folks! [19:18:59] HAve a great night Aiko! [20:49:34] 10Machine-Learning-Team, 10artificial-intelligence, 10Edit-Review-Improvements-RC-Page, 10Growth community maintenance, and 3 others: Enable ORES in RecentChanges for Hindi Wikipedia - https://phabricator.wikimedia.org/T303293 (10Halfak) @Psingh07 & @Nikhil1194, can you link to the posts you made on Hindi... [22:13:27] 10Machine-Learning-Team, 10artificial-intelligence, 10Edit-Review-Improvements-RC-Page, 10Growth community maintenance, and 3 others: Enable ORES in RecentChanges for Hindi Wikipedia - https://phabricator.wikimedia.org/T303293 (10calbon) @Halfak The Product Dept reached out to me about enabling ORES in H...