[07:56:44] morning folks! [07:59:22] Morning aiko :) [08:19:12] hi :) [08:32:24] Hello Luca and Tobias :) [08:32:56] afaics all ORES nodes are on buster, a little cleanup in puppet is needed but so far everything seems to work fine [08:33:47] I think that we can start prepping the change for https://github.com/wikimedia/revscoring/pull/518 aiko [08:34:03] that should be, in theory, update the wheels repo with the new revscoring wheel [08:34:04] I would like to deploy the arwiki-editquality-goodfaith. Could you help me with that? on either eqiad or codfw. Thank you! [08:34:10] and then updated the submodule on ores-deploy [08:34:17] If the feature gets tested no problem, we can apply the same change to the other editquality models (not urgent) [08:34:31] aiko: sure, do you have a code change open? [08:35:00] elukey: it already got merged https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/790293 [08:36:48] aiko: ah ok this is draftquality right? Not arwiki-editquality [08:37:20] it should already be deployed [08:37:26] elukey: \o [08:37:31] klausman: o/ [08:37:36] did you also see the sudo failures? [08:37:59] elukey: the code change is for both and we only deployed and tested draftquality so far [08:39:55] aiko: I see, deployed just now for eqiad :) [08:40:14] klausman: do you mean the mails to root@ ? [08:40:51] if so I think that it is a race condition with scap when it tries to execute its scripts the first time (when puppet hasn't yet created all the credentials) [08:41:17] Ah, I see, so we can ignore them [08:41:34] yeah I think so [08:41:45] elukey: thanks :) let me test it a bit. Then we can start doing revscoring later [08:46:41] 10Machine-Learning-Team, 10SRE-Access-Requests: Add Aiko and Kevin to the deployment posix group - https://phabricator.wikimedia.org/T308308 (10elukey) [08:59:37] klausman: sorry for the extra comments, I didn't see your previous CR :( [08:59:47] np :) [09:00:01] feel free to close the task afterwards, I think that we are done [09:00:07] Roger [09:00:58] I'll do a few PCC runs to see if it's overall a NOOP [09:01:50] 10Machine-Learning-Team, 10SRE-Access-Requests: Add Aiko and Kevin to the deployment posix group - https://phabricator.wikimedia.org/T308308 (10elukey) I may have created this task too soon, some discussion on T305729 is still happening, let's wait before proceeding. [09:10:51] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks), 10Patch-For-Review: Support (or not) the ORES augmented feature output in liftwing - https://phabricator.wikimedia.org/T301766 (10achou) Current status: * we deployed the new editquality image for arwiki and tested the feature * we deployed the new draftqu... [09:57:12] elukey: From I read in https://phabricator.wikimedia.org/T303801, iiuc we will merge the python37 branch into the master one for ores wheels. It seems the merge hasn't been done. Should I merge it first? or should I update the wheel on python37 branch? [10:15:27] aiko: yeah I think the idea was to merge python37 in to master, but since it may be a complicated move with git-lfs etc.., I'd just use the python37 branch from now on for the wheels [10:15:32] what do you think? [10:15:44] then we can think about the merge in the future, but it seems not pressing [10:17:42] elukey: I agree, that makes sense [10:21:25] super [10:21:42] so yeah the trick is to update the revscoring wheel and the test it [10:21:57] I hope that I have published the right code version etc.. but better to double check [10:22:18] (we can test easily in deployment-prep with your httpbb script for example) [10:22:51] going afk, ttl! [10:31:00] (03PS1) 10AikoChou: Update revscoring to 2.11.2 [research/ores/wheels] (python37) - 10https://gerrit.wikimedia.org/r/791576 (https://phabricator.wikimedia.org/T302851) [12:56:03] elukey: ^^^ after the new wheel getting merged, I also need to update https://gerrit.wikimedia.org/r/q/project:mediawiki/services/ores/deploy, right? [13:09:48] Good morning! [13:14:57] morning :) [13:15:16] aiko: exactly yes, the wheels submodule sha needs to be upgraded as well [13:15:39] I am still a little confused about how git-lfs handles binaries, since: [13:15:46] https://gerrit.wikimedia.org/r/c/research/ores/wheels/+/791576/1/revscoring-2.11.1-py2.py3-none-any.whl [13:15:49] vs [13:15:54] https://gerrit.wikimedia.org/r/c/research/ores/wheels/+/791576/1/revscoring-2.11.2-py2.py3-none-any.whl [13:16:31] aiko: do you have git-lfs installed etc.. on your laptop? [13:17:19] elukey: ah no.. [13:17:20] see for example https://gerrit.wikimedia.org/r/c/research/ores/wheels/+/784664, the files added all have the sha etc.. mark [13:26:33] (03PS2) 10AikoChou: Update revscoring to 2.11.2 [research/ores/wheels] (python37) - 10https://gerrit.wikimedia.org/r/791576 (https://phabricator.wikimedia.org/T302851) [13:27:36] o/ morning Chris :) [13:37:14] elukey: I updated the patch. now it should be right. :) [13:38:43] aiko: yep I've seen it, looks good! The size seems very different between versions, not sure if related or not [13:39:02] We could probably add a post-checkout hook that at least warns the user if no git LFS is deteced. [13:39:26] definitely [13:39:48] IIRC with git lfs ls-files there should be a list of files known and not-known to git lfs [13:40:30] I mean the hook would run right after the first clone, so ppl could then apt install git-lfs. [13:40:49] Not sure if they'd need to re-clean the git repo, tho [13:41:31] elukey: there is a .gitattributes lists file types [13:42:11] yep it should hint git-lfs about what to take care of [13:55:47] anyway, let's chat about it next week, not very urgent [13:55:53] ^^^ [13:55:55] I am going to log off for today folks, have a nice weekend! [13:56:06] Night elukey! Have a great weekend all! [14:02:40] Ok! have a nice weekend Luca :) [17:35:14] 10Machine-Learning-Team, 10SRE, 10SRE-Access-Requests: Add Aiko and Kevin to the deployment posix group - https://phabricator.wikimedia.org/T308308 (10RLazarus) 05Open→03Stalled a:03elukey >>! In T308308#7926592, @elukey wrote: > I may have created this task too soon, some discussion on T305729 is stil... [17:45:21] 10Machine-Learning-Team, 10SRE, 10SRE-Access-Requests: Add Aiko and Kevin to the deployment posix group - https://phabricator.wikimedia.org/T308308 (10RLazarus) p:05Triage→03Medium