[08:33:17] (03PS2) 10Kevin Bazira: editquality: refactor setting of the HTTP host header into its own method [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) [08:35:38] (03CR) 10CI reject: [V: 04-1] editquality: refactor setting of the HTTP host header into its own method [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) (owner: 10Kevin Bazira) [08:37:04] (03CR) 10Kevin Bazira: editquality: refactor setting of the HTTP host header into its own method (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) (owner: 10Kevin Bazira) [08:55:18] (03CR) 10Elukey: editquality: refactor setting of the HTTP host header into its own method (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) (owner: 10Kevin Bazira) [09:07:49] (03PS3) 10Kevin Bazira: editquality: refactor setting of the HTTP host header into its own method [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) [09:14:40] (03CR) 10Klausman: editquality: refactor setting of the HTTP host header into its own method (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) (owner: 10Kevin Bazira) [09:21:39] (03CR) 10Kevin Bazira: "The 3rd patchset fixed jenkins CI error where a black test was failing:" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) (owner: 10Kevin Bazira) [09:26:42] ok TIL of the day [09:26:43] https://github.com/wikimedia/mediawiki-services-ores-deploy/blob/1c8b8a1b6280ce1a971aad3b9476ed96b9144665/config/00-main.yaml#L110 [09:26:57] the /precache URIS in ORES is more complicated that expected [09:27:25] for every wiki, we have a list of models associated with them in the config [09:28:22] so that when changeprop hits the /precache URI with a recentchange event, ORES knows what models are associated with the wiki and scores the rev-id accordingly [09:28:47] in our case, changeprop would only be able to hit a certain model type, but it should know it in advance [09:50:21] (03CR) 10AikoChou: editquality: refactor setting of the HTTP host header into its own method (032 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) (owner: 10Kevin Bazira) [09:55:45] I have created https://github.com/wikimedia/ores/pull/361 to fix the swagger specs of ORES [09:57:21] basically to update https://ores.wikimedia.org/v3/#!/scoring/post_v3_precache [09:58:18] (03CR) 10Elukey: editquality: refactor setting of the HTTP host header into its own method (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) (owner: 10Kevin Bazira) [10:04:34] (03PS4) 10Kevin Bazira: editquality: refactor setting of the HTTP host header into its own method [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) [10:10:55] (03PS5) 10Kevin Bazira: editquality: refactor setting of the HTTP host header into its own method [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) [10:18:08] (03CR) 10Klausman: [C: 03+1] editquality: refactor setting of the HTTP host header into its own method [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) (owner: 10Kevin Bazira) [10:24:24] <- lunch [10:26:16] 10Lift-Wing, 10Epic, 10Machine-Learning-Team (Active Tasks): Send score to eventgate when requested - https://phabricator.wikimedia.org/T301878 (10elukey) Today I reviewed a little more the ChangeProp's code and the ORES' code, my initial idea may not be applicable. At the moment ORES offers a /precache end... [10:26:26] added everything that I found today in --^ [10:27:16] it looks difficult to fix, maybe we could think about a new set of events called revision-score-blabla, deprecating revision-score [10:27:26] * elukey lunch, ttl! [11:05:32] (03PS6) 10Kevin Bazira: editquality: refactor setting of the HTTP host header into its own method [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) [11:10:44] (03CR) 10Kevin Bazira: editquality: refactor setting of the HTTP host header into its own method (032 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) (owner: 10Kevin Bazira) [11:24:14] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks): Test Ray worker in Kserve - https://phabricator.wikimedia.org/T309624 (10achou) I was able to run two models `arwiki-damaging` and `jawiki-damaging` in the same inference service using ray serve: ` aikochou@ml-sandbox:~/isvcs/damaging$ kubectl get isvc -n k... [11:54:57] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks): Test Ray worker in Kserve - https://phabricator.wikimedia.org/T309624 (10achou) Some notes what I changed: * Upload two model binary files to the same bucket, and changed the name other than model.bin * In isvc yaml: 1) request two cpus 2) change env INFERE... [13:26:11] 10Lift-Wing, 10Epic, 10Machine-Learning-Team (Active Tasks), 10Patch-For-Review: Set up the ml-cache clusters - https://phabricator.wikimedia.org/T302232 (10elukey) @lbowmaker Hi! I had a chat with Eric about the use cases described above, and if you have some time I'd like to understand if any of them cou... [13:30:54] 10Lift-Wing, 10artificial-intelligence, 10Machine-Learning-Team (Active Tasks): Migrate draftquality models - https://phabricator.wikimedia.org/T310698 (10kevinbazira) [13:36:29] got the green light to merge my change for the cassandra ml cluster, trying to bootstrap the eqiad one [13:38:05] 10Lift-Wing, 10artificial-intelligence, 10Machine-Learning-Team (Active Tasks): Upload draftquality model binaries to storage - https://phabricator.wikimedia.org/T310701 (10kevinbazira) [13:42:54] 10Lift-Wing, 10artificial-intelligence, 10Machine-Learning-Team (Active Tasks): Create draftquality inference services - https://phabricator.wikimedia.org/T310704 (10kevinbazira) [13:43:53] of course we need to run buster and our nodes have bullseye [13:43:55] sigh [13:43:58] reimaging [15:58:16] Frogot to mention it during the meeting: I did something horrible to my shoulder and currently am a bit typing- (and especially mosuing-) impaired. [15:58:47] (whate xactly I did, I dunno. At my age "slept wrong" is definitely a possibility :)) [19:06:32] (03CR) 10AikoChou: editquality: refactor setting of the HTTP host header into its own method (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/805388 (https://phabricator.wikimedia.org/T309623) (owner: 10Kevin Bazira) [19:32:26] 10Machine-Learning-Team, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Wikimedia-Site-requests, 10editquality-modeling: Add new recent changes filters to az.wiki - https://phabricator.wikimedia.org/T310691 (10Stang) Tagging machine learning team for necessary support related to ORES model training...