[07:47:56] (03PS2) 10Elukey: articlequality: move preprocess() to async [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/821722 (https://phabricator.wikimedia.org/T313915) [07:50:14] (03PS3) 10Elukey: articlequality: move preprocess() to async [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/821722 (https://phabricator.wikimedia.org/T313915) [07:53:01] all right the code change seems to work! [08:29:58] (03CR) 10Elukey: "Question for Aiko/Kevin - there is the possibility, in theory, to add some shared code to "revscoring_util" (or a new module) under the py" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/821722 (https://phabricator.wikimedia.org/T313915) (owner: 10Elukey) [08:30:34] folks I need to bring my mother's cat to the vet, should be back in an hour or so! [09:08:08] (03PS1) 10AikoChou: nsfw: create model-server and blubberfile [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/822046 (https://phabricator.wikimedia.org/T314810) [09:14:48] (03PS2) 10AikoChou: nsfw: create model-server and blubberfile [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/822046 (https://phabricator.wikimedia.org/T314810) [10:08:59] (03CR) 10Elukey: "Overall everything seems good! I am going to do a more extensive pass this afternoon, but everything seems in place." [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/822046 (https://phabricator.wikimedia.org/T314810) (owner: 10AikoChou) [10:09:36] (03CR) 10Elukey: "Aiko already anticipated me :)" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/822046 (https://phabricator.wikimedia.org/T314810) (owner: 10AikoChou) [10:12:09] :) [10:12:28] :) [10:12:42] I left a comment in the integration/config change, related to the python shared dir [10:12:47] but overall all looks good [10:16:49] aiko: when you have time (after the nsfw project) it would be super great to document the procedure that you are using on Wikitech [10:23:42] elukey: that sounds good! I'll do it :) [10:24:32] <3 [10:24:57] as FYI, this afternoon there is some Datacenter Rack maintenance, namely swapping PDUs (power units) in codfw [10:25:10] some of our hosts are affected, I am depooling them and shutting them down [10:25:36] ores2008 [10:25:38] ores2009 [10:25:42] (03CR) 10Kevin Bazira: [C: 03+1] articlequality: move preprocess() to async (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/821722 (https://phabricator.wikimedia.org/T313915) (owner: 10Elukey) [10:25:46] ml-serve2008 [10:27:11] going afk for lunch! [10:34:33] elukey: ack [12:18:11] (03CR) 10AikoChou: "Luca and Kevin: Another thing I'd like to bring up is I have noticed that articlequality is different from other revscoring models. It doe" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/821722 (https://phabricator.wikimedia.org/T313915) (owner: 10Elukey) [12:20:41] (03CR) 10AikoChou: [C: 03+1] articlequality: move preprocess() to async [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/821722 (https://phabricator.wikimedia.org/T313915) (owner: 10Elukey) [12:22:16] the thing I just mentioned above should be for another ticket, so I gave +1 :) [13:08:59] Morning all! [13:17:08] o/ [13:26:45] aiko: o/ [13:27:52] thanks for the code review, I am checking the articlequality code [13:28:13] so afaics from debug logging on stat1004, the api extractor makes a call to the MW api to get the rev-id metadata [13:28:19] but that's it, nothing more [13:29:31] I am not sure if there is a specific use case for fetching rvprop=["ids", "content"], [13:29:41] (that is what the standalone http call does basically) [13:30:48] there is only a mention in https://github.com/wikimedia/revscoring/blob/master/revscoring/extractors/api/extractor.py#L208 but no idea how it can be used [13:30:52] but it is a good point! [13:31:29] (03CR) 10Elukey: [C: 03+2] "Thanks to both for the reviews! Going to merge and follow up on IRC about Aiko's last comment." [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/821722 (https://phabricator.wikimedia.org/T313915) (owner: 10Elukey) [13:35:51] (03Merged) 10jenkins-bot: articlequality: move preprocess() to async [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/821722 (https://phabricator.wikimedia.org/T313915) (owner: 10Elukey) [13:45:09] (03CR) 10Elukey: "Left some comments for the Python code, but nothing blocking, lemme know your thoughts! The rest looks very good, should be ready to go!" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/822046 (https://phabricator.wikimedia.org/T314810) (owner: 10AikoChou) [13:58:38] 10Lift-Wing, 10artificial-intelligence, 10drafttopic-modeling, 10Machine-Learning-Team (Active Tasks), 10Patch-For-Review: Create drafttopic inference services - https://phabricator.wikimedia.org/T314456 (10kevinbazira) a:03kevinbazira [14:18:29] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks), 10Patch-For-Review: Move revscoring isvcs to async architecture - https://phabricator.wikimedia.org/T313915 (10elukey) Tests for articlequality: regular blocking code: ` elukey@deploy1002:~$ wrk -c 1 -t 1 --timeout 2s -s inference.lua https://inference-s... [14:18:40] performance tests for the new articlequality image in staging --^ [14:18:42] really good [14:18:54] async seems to confirm its usefulness [14:21:39] moving the image to prod with https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/822090/ [14:26:58] sweeeet [15:02:29] elukey teaaam meeeting [15:02:32] stop coding [15:03:15] I was following rack maintenance from DC ops :D [15:52:33] (03CR) 10AikoChou: "Thanks for the review. I'll submit a new patch for the points you mentioned :)" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/822046 (https://phabricator.wikimedia.org/T314810) (owner: 10AikoChou) [15:52:53] aiko: let's sync tomorrow morning for the "Experimental" namespace, I'll work on it :) [15:53:10] elukey: sounds great! :) [15:53:16] super [15:53:33] leaving for today folks, have a nice rest of the day :) [15:53:35] away afk! [15:53:44] (this was the IRC command :P) [15:53:55] bye Luca!