[06:16:55] good morning folks! [06:20:47] reading "some" mails before being productive :D [07:02:28] 10Machine-Learning-Team, 10ORES, 10Edit-Review-Improvements-RC-Page, 10Growth-Team: Add ORES to English Wikiquote - https://phabricator.wikimedia.org/T312592 (10elukey) Hi folks! I was on holidays and I didn't see the task till now. The ML team is moving from ORES to Lift Wing, the new infrastructure, so w... [07:11:29] 10Lift-Wing, 10Documentation, 10Machine-Learning-Team (Active Tasks): Improve Lift Wing documentaton - https://phabricator.wikimedia.org/T316098 (10elukey) 05Resolved→03Open Thanks a lot for the efforts Aiko, great work! Before closing, since you brought up the subject, I think that we could take this t... [07:57:58] 10Lift-Wing, 10Machine-Learning-Team (Active Tasks), 10Patch-For-Review: Connect Outlink topic model to eventgate - https://phabricator.wikimedia.org/T315994 (10elukey) There are some high level points to discuss before proceeding in my opinion. We can definitely use the `events.py` module but we'd need to f... [08:05:56] (03CR) 10Elukey: [WIP] outlink: add code to send events to EventGate (033 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/828481 (https://phabricator.wikimedia.org/T315994) (owner: 10AikoChou) [08:20:11] elukey: Morning! [08:34:10] o/ [08:37:02] elukey: ping me whenever you want to sync up via VC [08:37:33] klausman: maybe this afternoon, would it be ok? [08:38:09] Sure [08:38:59] I saw the gdoc about the api proposal, in my todo list :) [08:39:25] have we reached some decision/consensus about the use of the revscoring score cache ? [08:40:03] There are some aspects that Aiko brought up that need addressing. I specifically waited with doing so until you were back, since I didn't want to make any deeper decisions/developments without you in the loop [08:41:58] yep yep adding it is a big job, I was wondering if there have been discussions (didn't find traces on slack/phab etc.. so I was curious) [08:43:17] That's my bad. I got heads down in that doc and kinda forgot making a phab ticket [08:45:15] nah please I wasn't really meaning to ask for phab updates, I was only curious since I have been reading many things :) [08:46:57] <3 [08:54:51] I am refactoring my async preprocess code, hope to have a code review out later on, it should ease adding async preprocess to drafttopic and outlink [08:58:49] Take it easy, no need to burn out on the first day ;) [09:01:53] nah I missed coding a bit, not burning out [09:02:11] Alright then :) [10:01:55] high level thought while refactoring - moving code to the python/preprocess_utils.py module seems very nice but it carries a consequence, namely adding revscoring as dependency in the common python's requirement.txt [10:02:14] this is not really ideal, in the future we don't want other models to inherit the dependency [10:02:37] so I am thinking, if everybody agrees, to add another "python" directory, maybe called python_revscoring [10:02:48] in which we store revscoring-only common code [10:03:03] to ease the future deprecation [10:11:56] need to think a bit more about it, but it seems the most feasible road forward [10:17:12] I think the pricniple is sound. Not sure about the directory name [10:17:28] It sorotf implies that the revscoring lib being used is in there. [10:17:32] sortof* [10:21:12] yeah this is the idea, a place where we confine revscoring-only common code [10:21:20] so it is very clear what ends up in there [10:21:39] and we set to install its requirements.txt only in the isvcs that run revscoring [10:22:23] I mean as long as we have a README in there or sth, it should be fine [10:22:33] yep yep [10:24:54] +1 [10:41:42] lunch! [10:47:57] same [13:36:59] working on a different proposal [13:37:17] we can have a python/revscoring/.. subdirectory with its own requirements.txt file [13:43:11] that sounds cleaner, yes [14:01:18] ack testing it now [14:01:33] kevinbazira_: o/ how is it going with testing kserve locally with Docker? [14:01:56] lemme know if it is a good way to go or if something is missing [14:23:43] bringing my cat to vet, back in ~30 mins :) [14:39:41] Shall we have a VC chat when you're back? [15:00:49] sure [16:21:08] (03PS1) 10Elukey: editquality: refactor preprocess common code [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/829847 (https://phabricator.wikimedia.org/T313915) [16:23:22] (03PS2) 10Elukey: editquality: refactor preprocess common code [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/829847 (https://phabricator.wikimedia.org/T313915) [16:23:45] this is what I meant today --^ [16:52:53] (03CR) 10Klausman: [C: 03+1] "Love the better separation of logic/functionality." [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/829847 (https://phabricator.wikimedia.org/T313915) (owner: 10Elukey) [16:58:56] afk for today, have a nice rest of the day folks!