[10:54:23] <wikibugs>	 (03CR) 10AikoChou: "Thanks for working on this! I like the idea of refactoring to avoid too many if/else. I'd like to understand the code better and put some " [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/871185 (https://phabricator.wikimedia.org/T323624) (owner: 10Ilias Sarantopoulos)
[12:26:34] <wikibugs>	 (03CR) 10Kevin Bazira: [C: 03+1] "LGTM!" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/870517 (https://phabricator.wikimedia.org/T325657) (owner: 10Elukey)
[12:37:43] <wikibugs>	 (03CR) 10Ilias Sarantopoulos: Create different objects for MP/SP (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/871185 (https://phabricator.wikimedia.org/T323624) (owner: 10Ilias Sarantopoulos)
[14:28:58] <chrisalbon>	 Morning all!
[14:29:26] <isaranto>	 \o/ Chris!
[16:18:56] <wikibugs>	 (03PS6) 10Ilias Sarantopoulos: Create different objects for MP/SP [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/871185 (https://phabricator.wikimedia.org/T323624)
[16:55:26] <wikibugs>	 (03PS7) 10Ilias Sarantopoulos: Create different objects for MP/SP [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/871185 (https://phabricator.wikimedia.org/T323624)
[16:57:06] <wikibugs>	 (03PS8) 10Ilias Sarantopoulos: Create different objects for MP/SP [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/871185 (https://phabricator.wikimedia.org/T323624)
[17:00:12] <wikibugs>	 (03PS9) 10Ilias Sarantopoulos: Create different objects for MP/SP [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/871185 (https://phabricator.wikimedia.org/T323624)
[17:03:30] <wikibugs>	 (03PS10) 10Ilias Sarantopoulos: Create different objects for MP/SP [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/871185 (https://phabricator.wikimedia.org/T323624)
[17:03:34] <isaranto>	 aiko: I updated the patch and I have QA'd it locally, all combinations work. I had to do some refactoring to allow inheritance between async and blocking functions
[17:04:12] <isaranto>	 logging off folks! good evening
[17:05:37] <isaranto>	 I consumed most of my day building and testing the images to enable/disable multiprocessing for preprocess and/or inference so I did not debug the error in the precommit hooks. will do that next week
[17:09:03] <wikibugs>	 10Machine-Learning-Team, 10Patch-For-Review: Test revscoring model servers on Lift Wing - https://phabricator.wikimedia.org/T323624 (10isarantopoulos)  I have broken down the RevscoringModel in a parent class used for single processing and a child class for MP. On deployment we need to input the following env...
[17:20:11] <aiko>	 isaranto: o/ got it! talk to you next week! 
[17:43:13] <isaranto>	 I broke down the predict and preprocess functions otherwise we would have too much duplicate code