[09:22:08] I created a new patch to run one last test (famous last words :) ) and enable MP only for preprocessing for drafttopic [09:22:33] klausman: this is yours to merge please šŸ™ https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/879279 [09:28:19] Looking [09:29:08] +2'd [09:35:50] thaanks [09:36:22] Let me know when you deploy, I'd like to keep an eye on the Grafana dashboards [09:37:49] Iā€™m doing it right now! [09:38:00] done [09:42:53] yeah, looks good so far [10:55:17] 10Machine-Learning-Team, 10Patch-For-Review: Test revscoring model servers on Lift Wing - https://phabricator.wikimedia.org/T323624 (10isarantopoulos) I ran a final set of tests and I repasting here the original results for single process (SP) as it is difficult to navigate the results in this thread. **SP - S... [11:46:44] * klausman lunch [11:52:42] yesterday pandas adopted ruff https://github.com/pandas-dev/pandas/commit/db8af0e767cb66a7b747984feec380822012cce9 [11:53:14] so I started looking into it today. it is ridiculously fast and already has a pre-commit hook [12:10:48] (03PS11) 10Ilias Sarantopoulos: Add pre-commit hooks [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/875284 (https://phabricator.wikimedia.org/T325198) [12:23:59] (03PS12) 10Ilias Sarantopoulos: Add pre-commit hooks [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/875284 (https://phabricator.wikimedia.org/T325198) [12:26:37] (03PS13) 10Ilias Sarantopoulos: Add pre-commit hooks [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/875284 (https://phabricator.wikimedia.org/T325198) [12:28:35] (03PS14) 10Ilias Sarantopoulos: Add pre-commit hooks [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/875284 (https://phabricator.wikimedia.org/T325198) [12:29:36] (03CR) 10CI reject: [V: 04-1] Add pre-commit hooks [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/875284 (https://phabricator.wikimedia.org/T325198) (owner: 10Ilias Sarantopoulos) [12:47:32] (03PS15) 10Ilias Sarantopoulos: Add pre-commit hooks [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/875284 (https://phabricator.wikimedia.org/T325198) [13:06:39] (03CR) 10AikoChou: revertrisk: build image for multilingual model (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878947 (https://phabricator.wikimedia.org/T325295) (owner: 10AikoChou) [13:11:15] (03PS2) 10AikoChou: revertrisk: build image for language-agnostic model [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878944 (https://phabricator.wikimedia.org/T325295) [13:12:20] (03CR) 10AikoChou: "There are two models. I'll first merge this to build an image and then build another one." [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878944 (https://phabricator.wikimedia.org/T325295) (owner: 10AikoChou) [13:13:28] (03PS2) 10AikoChou: revertrisk: build image for multilingual model [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878947 (https://phabricator.wikimedia.org/T325295) [13:14:09] (03PS3) 10AikoChou: revertrisk: build image for language-agnostic model [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878944 (https://phabricator.wikimedia.org/T325295) [14:05:08] aiko: regarding the extra index url in your first patch, I tried it too and indeed it doesnt work :( . patch is ready from my side then for merge šŸ‘ [14:25:17] (03CR) 10Ilias Sarantopoulos: revertrisk: build image for language-agnostic model (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878944 (https://phabricator.wikimedia.org/T325295) (owner: 10AikoChou) [14:25:40] (03PS16) 10Ilias Sarantopoulos: Add pre-commit hooks [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/875284 (https://phabricator.wikimedia.org/T325198) [14:52:02] Morning all [15:06:45] \o [15:13:10] o/ [16:37:27] (03CR) 10AikoChou: revertrisk: build image for language-agnostic model (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878944 (https://phabricator.wikimedia.org/T325295) (owner: 10AikoChou) [16:40:10] (03CR) 10Ilias Sarantopoulos: revertrisk: build image for multilingual model [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878947 (https://phabricator.wikimedia.org/T325295) (owner: 10AikoChou) [16:40:43] (03CR) 10Ilias Sarantopoulos: [C: 03+1] revertrisk: build image for language-agnostic model (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878944 (https://phabricator.wikimedia.org/T325295) (owner: 10AikoChou) [16:42:20] isaranto: thanks for the review :) [16:44:17] (03CR) 10AikoChou: [C: 03+2] revertrisk: build image for language-agnostic model [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878944 (https://phabricator.wikimedia.org/T325295) (owner: 10AikoChou) [16:47:05] :) [16:51:31] (03Merged) 10jenkins-bot: revertrisk: build image for language-agnostic model [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878944 (https://phabricator.wikimedia.org/T325295) (owner: 10AikoChou) [17:07:43] (03PS3) 10AikoChou: revertrisk: build image for multilingual model [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878947 (https://phabricator.wikimedia.org/T325295) [17:20:11] (03CR) 10AikoChou: [C: 03+2] revertrisk: build image for multilingual model [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878947 (https://phabricator.wikimedia.org/T325295) (owner: 10AikoChou) [17:26:01] (03Merged) 10jenkins-bot: revertrisk: build image for multilingual model [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/878947 (https://phabricator.wikimedia.org/T325295) (owner: 10AikoChou)