[10:55:30] o/ [10:55:57] I started work manually setting the threshold values in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/948542 [10:56:10] I also attached the links to ORES [10:59:36] \o [10:59:53] lmk if-and-when that change needs review [11:10:29] sure! I am cross-checking values and what else needs to change in the extension. Will definitely need a second (third) pair of eyes as the info is too much! [11:14:05] aye [11:14:16] how are you transforming the JSOn fro the URLs to PHP dict data? [11:14:34] I had a go at it with jq last week, but it quickly became very messy [11:15:45] in the previous go I had done it with a script, which messed up the order (I think this has been the issue all along) [11:16:52] now I just add a separate request per threshold [11:16:59] Kinda wild that some JSON lib things array order doesn't matter [11:24:59] Also, hwo do you arrive from the array of structs that have f1/!f1 etc in them at the precise values to use? [11:25:48] E.g. if I curl https://ores.wikimedia.org/v3/scores/arwiki?models=damaging&model_info=statistics.thresholds.false, I get a long list of those stanzas, how do you arrive at likelygood/bad/... values? (0.833, 0.154 etc) [11:28:28] It has just one set of values and we use the value in the threshold field [11:29:33] I don't understand? One set of values? [11:29:35] The url contains the query after the "thresholds.false" param [11:29:46] w8 [11:31:02] This is a sample request https://ores.wikimedia.org/v3/scores/zhwiki?models=goodfaith&model_info=statistics.thresholds.false."''maximum recall @ precision >= 0.15''" [11:31:13] url will not accept that [11:31:16] curl* [11:31:53] or rather, my shell will already start interpeting things like & [11:32:20] and if I quite it, curl complains about a malformed URL [11:32:26] quote* [11:32:26] Just try it in the browser. Otherwise with curl I think you have to escape the double quotes [11:33:08] ah, so it _should_ be https://ores.wikimedia.org/v3/scores/zhwiki?models=goodfaith&model_info=statistics.thresholds.false.%22%27%27maximum%20recall%20@%20precision%20%3E=%200.15%27%27%22 [11:36:14] Yep! [11:36:31] Sry forgot to mention the alternative is to encode the url :) [11:37:09] :) [11:48:42] isaranto: so this works. Sorta. I think :) curl -s 'https://ores.wikimedia.org/v3/scores/zhwiki?models=damaging&model_info=statistics.thresholds.true.%22%27%27maximum%20recall%20@%20precision%20%3E=%200.15%27%27%22'|jq '..|.true?[0].threshold?|select( . != null )' [11:49:45] naturally, for the False sets the jq filter expression should use false?[0] [11:50:58] IIUC, exactly one of min and max is always 0 or 1, respectively, right? [11:51:31] And the other one is always the threshold value. [12:02:37] Exactly! I will write some comments with code snippets from the original code of the extension on the phabricator task [12:02:44] * isaranto lunch! [12:04:39] ditto [12:21:54] 10Machine-Learning-Team: Revert Risk multi-lingual model performance and reliability may need a review - https://phabricator.wikimedia.org/T340822 (10achou) @klausman Last Friday I deployed new changes to the revert-risk models. In ml-serve-codfw, all pods were updated and running without any issues. But in ml-s... [12:22:58] aiko: will take a look after lubch [12:30:30] klausman: thanks!! [13:15:36] aiko: seems like it was the usual "old revisions hanging around", cleaning them up now [13:19:39] 10Machine-Learning-Team, 10Patch-For-Review: fiwiki RC filters classify all edits as 'very likely bad faith' - https://phabricator.wikimedia.org/T343308 (10isarantopoulos) I have opened a patch that replaces the queries for the thresholds with the values as @Ladsgroup suggested. https://gerrit.wikimedia.org/r... [13:33:09] 10Machine-Learning-Team: Revert Risk multi-lingual model performance and reliability may need a review - https://phabricator.wikimedia.org/T340822 (10klausman) Should be all clean now: ` # kubectl get pods -n revertrisk NAME READY STATUS RESTARTS... [13:33:17] aiko ^^^ [15:14:24] (03PS1) 10Ilias Sarantopoulos: read thresholds numeric values [extensions/ORES] - 10https://gerrit.wikimedia.org/r/948584 (https://phabricator.wikimedia.org/T343308) [15:16:09] (03CR) 10CI reject: [V: 04-1] read thresholds numeric values [extensions/ORES] - 10https://gerrit.wikimedia.org/r/948584 (https://phabricator.wikimedia.org/T343308) (owner: 10Ilias Sarantopoulos) [15:26:26] klausman: nice, thank you [15:49:57] 10Machine-Learning-Team, 10Epic: Lift Wing improvements to get out of MVP state - https://phabricator.wikimedia.org/T333453 (10achou) [15:50:48] 10Machine-Learning-Team, 10Research, 10Patch-For-Review: Index out of range in revert risk multi-lingual - https://phabricator.wikimedia.org/T340811 (10achou) 05Open→03Resolved The new model binary has been uploaded and deployed. Thank you all for working on this! The task is resolved. :) [15:52:37] 10Machine-Learning-Team, 10Epic: Lift Wing improvements to get out of MVP state - https://phabricator.wikimedia.org/T333453 (10achou) [15:52:59] 10Machine-Learning-Team: FeatureNotFound exception in revertrisk multi-lingual - https://phabricator.wikimedia.org/T340812 (10achou) 05Open→03Resolved a:03achou [15:53:07] 10Machine-Learning-Team, 10Epic: Lift Wing improvements to get out of MVP state - https://phabricator.wikimedia.org/T333453 (10achou) [15:53:25] 10Machine-Learning-Team: Pop index out of range exception in revertrisk multi lingual - https://phabricator.wikimedia.org/T340813 (10achou) 05Open→03Resolved a:03achou [17:11:39] 10Machine-Learning-Team, 10Add-Link, 10Growth-Team, 10User-notice: Deploy "add a link" to 13th round of wikis - https://phabricator.wikimedia.org/T308138 (10Sgs) I ran this script for adding the link-recommendation task type and populating the excluded sections entries: `lang=bash PHAB=T308138 for WIKI in... [17:30:36] 10Machine-Learning-Team, 10Add-Link, 10Growth-Team, 10Patch-For-Review, 10User-notice: Deploy "add a link" to 13th round of wikis - https://phabricator.wikimedia.org/T308138 (10Sgs) a:05kostajh→03Sgs [17:32:11] 10Machine-Learning-Team, 10Add-Link, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10User-notice: Deploy "add a link" to 13th round of wikis - https://phabricator.wikimedia.org/T308138 (10Sgs) [17:33:14] 10Machine-Learning-Team, 10Add-Link, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10User-notice: Deploy "add a link" to 13th round of wikis - https://phabricator.wikimedia.org/T308138 (10Sgs) 05Open→03In progress [21:56:55] 10Machine-Learning-Team, 10Patch-For-Review: fiwiki RC filters classify all edits as 'very likely bad faith' - https://phabricator.wikimedia.org/T343308 (10Ladsgroup) >>! In T343308#9090074, @isarantopoulos wrote: > I have opened a patch that replaces the queries for the thresholds with the values as @Ladsgrou...