[07:51:25] (03CR) 10Elukey: article-descriptions: add article-descriptions model server (0312 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/970831 (https://phabricator.wikimedia.org/T343123) (owner: 10Kevin Bazira) [07:57:48] (03CR) 10Elukey: article-descriptions: add article-descriptions model server (032 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/970831 (https://phabricator.wikimedia.org/T343123) (owner: 10Kevin Bazira) [08:13:52] (03CR) 10Elukey: article-descriptions: add article-descriptions model server (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/970831 (https://phabricator.wikimedia.org/T343123) (owner: 10Kevin Bazira) [09:12:48] (03CR) 10Kevin Bazira: article-descriptions: add article-descriptions model server (032 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/970831 (https://phabricator.wikimedia.org/T343123) (owner: 10Kevin Bazira) [09:15:09] (03PS3) 10Kevin Bazira: article-descriptions: add article-descriptions model server [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/970831 (https://phabricator.wikimedia.org/T343123) [09:41:57] (03CR) 10Kevin Bazira: "recheck" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/970831 (https://phabricator.wikimedia.org/T343123) (owner: 10Kevin Bazira) [09:51:35] (03CR) 10CI reject: [V: 04-1] article-descriptions: add article-descriptions model server [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/970831 (https://phabricator.wikimedia.org/T343123) (owner: 10Kevin Bazira) [09:52:00] kevinbazira: o/ for --^, you can run "tox" in you local inference-services repo dir and you should get two things [09:52:19] 1) automatic changes to the code that doesn't comply with ruff/black/etc.. tools standards [09:52:33] 2) the remaining errors that may need a manual fix [09:53:02] sure sure, working on it now ... [11:14:43] (03PS4) 10Kevin Bazira: article-descriptions: add article-descriptions model server [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/970831 (https://phabricator.wikimedia.org/T343123) [11:24:42] elukey: --^ all the CI checks for the article-descriptions model-server have run successfully. [11:26:19] nice! [11:27:04] I think we can wait for Ilias/Aiko's review before proceeding further, to see if any refactor is needed etc.. [11:27:16] is it ok for you? [11:27:29] (03CR) 10Elukey: article-descriptions: add article-descriptions model server (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/970831 (https://phabricator.wikimedia.org/T343123) (owner: 10Kevin Bazira) [11:28:21] yes, that's ok with me. [11:28:31] thanks for the reviews elukey. [11:31:05] np! Nice work