[08:18:34] Guten tag! [09:08:51] 10Machine-Learning-Team: Enable local runs for article-descriptions model - https://phabricator.wikimedia.org/T351940 (10isarantopoulos) The above issue was caused by the folowing line of code ` base_url = urljoin(self.rest_gateway_endpoint, self.wiki_url or mw_host) ` it tries to create a url from `rest_gatewa... [09:39:57] Guten morgen! [09:51:33] cmw [09:51:38] oops :) [09:52:49] You got me google searching cmw! [09:53:47] That is a mistype/misaling of trying ^A^C (new tmux window) and "mw" a tool I wrote that quickly shows me what new mail I have :) [09:53:56] Also, 早上好！ [09:56:17] :D [09:56:25] I hope I got it right :) [09:56:53] it's perfect :D [09:57:48] <3 [11:17:12] (03PS1) 10AikoChou: revert-risk: enable local run [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/979315 (https://phabricator.wikimedia.org/T352181) [11:18:05] kevinbazira: regarding the load testing if you agree we can start documenting load test results as we discussed this week. Adding a directory under wrk/article_descriptions where we can have: input data, lua files and a README.md where we paste some results [11:18:08] wdyt? [11:21:08] (03CR) 10Ilias Sarantopoulos: revert-risk: enable local run (032 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/979315 (https://phabricator.wikimedia.org/T352181) (owner: 10AikoChou) [11:21:17] isaranto: that's exactly the process I am following to add load tests for the article_descriptions isvc. [11:21:29] In the meantime, I am quickly supporting Martin from the research team to fix the link recommendation training pipeline. [11:21:29] after this I'll resume with load testing the article_descriptions isvc. [11:22:56] sure! no hurry, just wanted to discuss it with you beforehand. [11:31:05] isaranto: o/ do you mean separating the knowledge_integrity upgrade from the kserve version upgrade? (there I upgraded both) or do you mean not filing any upgrades in that patch? [11:32:42] I mean the latter. Separating the upgrades from the refactoring [11:33:16] isaranto: okk got it [11:33:31] I do it also sometimes and I should be reminded otherwise! [11:34:10] no biggy but if the merge is blocked this means that both changes would be blocked [11:35:33] (03PS2) 10AikoChou: revert-risk: enable local run [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/979315 (https://phabricator.wikimedia.org/T352181) [11:36:46] 10Machine-Learning-Team: Fix the link recommendation training pipeline - https://phabricator.wikimedia.org/T352525 (10kevinbazira) [11:37:19] agree, changed it :) [11:40:32] 10Machine-Learning-Team: Fix the link recommendation training pipeline - https://phabricator.wikimedia.org/T352525 (10kevinbazira) From a quick check, the link recommendation training pipeline uses [[ https://gitlab.wikimedia.org/repos/data-engineering/conda-analytics | conda-analytics ]] and the last time this... [11:44:10] I'm gonna also run docker images to see if everything works fine [11:50:19] 🙌 [12:11:27] 10Machine-Learning-Team, 10ORES: Review trafiic on ores.wikimedia.org - https://phabricator.wikimedia.org/T352527 (10isarantopoulos) [12:12:16] I took a look at logstash for leftover traffic towards ores.wikimedia.org. Things are looking good! I opened a task so we can follow up and deal with this properly [12:13:33] 10Machine-Learning-Team: Fix the link recommendation training pipeline - https://phabricator.wikimedia.org/T352525 (10kevinbazira) I have dug a little more and found that this setup is indeed failing because some package version numbers are way behind specifically these packages: ` jupyter-core packaging request... [12:27:37] aiko: I'll review the local run later today. I have to redownload the model and test the patch [12:28:01] * isaranto afk lunch [13:37:57] (03PS3) 10AikoChou: revert-risk: enable local run [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/979315 (https://phabricator.wikimedia.org/T352181) [13:41:11] ---^ fixed the python dir path in the blubber file [13:48:41] isaranto: ack, no hurry :) [13:50:14] 10Machine-Learning-Team, 10Wikimedia Enterprise, 10Data-Engineering (Sprint 6), 10Epic, 10Event-Platform: [Event Platform] Implement PoC Event-Driven Data Pipeline for Revert Risk Model Scores using Event Platform Capabilities - https://phabricator.wikimedia.org/T338792 (10lbowmaker) [15:22:50] me2! [16:00:05] (03CR) 10Ilias Sarantopoulos: [C: 03+1] "Great work! I tested the patch using the instructions in the README.md and it is working flawlessly! Also built the lang-agnostic docker i" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/979315 (https://phabricator.wikimedia.org/T352181) (owner: 10AikoChou) [16:00:21] --^ aiko: awesome! [16:03:52] Just check the comment cause we need to change the CI triggers in order to build the images. If you need any help on that let me know. It is similar to what I did earlier this week https://gerrit.wikimedia.org/r/c/integration/config/+/978535 [16:04:11] I had forgotten to do it and we were wondering why the images weren't built [16:12:52] (03PS19) 10Ilias Sarantopoulos: add revertrisk model to the list of models [extensions/ORES] - 10https://gerrit.wikimedia.org/r/971547 (https://phabricator.wikimedia.org/T348298) [16:16:59] 10Machine-Learning-Team, 10MediaWiki-extensions-ORES, 10Growth-Team, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: Add revertrisk-language-agnostic to RecentChanges filters - https://phabricator.wikimedia.org/T348298 (10isarantopoulos) I also changed the order of the filters in order for revertris... [16:33:11] folks I am going afk for the weekend. Cu all Monday <3 [16:46:19] \o