[05:46:31] Good morning folks o/ [07:05:43] kevinbazira: o/ how r u ? :) [07:05:55] would you like to help with the articlequality model? [07:06:15] isaranto: o/ [07:06:58] yes, you had mentioned earlier on that I could follow up on the task list you shared. should I go ahead? [07:08:24] ofc! just wanted to sync here as well [07:09:09] so you are creating the CI pipelines and the entry in the deployment charts right? [07:10:16] yep yep [07:11:56] great! thanks a lot for helping :) [07:12:06] sure np! [07:12:31] we can then discuss about the preprocessing part (probably Monday would be ok). I plan to make a start today [07:12:47] sounds good [07:55:38] (03PS1) 10Kevin Bazira: articlequality: add CI pipelines [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1043644 (https://phabricator.wikimedia.org/T360455) [08:08:17] (03CR) 10CI reject: [V:04-1] articlequality: add CI pipelines [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1043644 (https://phabricator.wikimedia.org/T360455) (owner: 10Kevin Bazira) [09:09:21] isaranto: just noticed https://gerrit.wikimedia.org/r/1042154 is not yet merged. the blubberfile is required by the articlequality CI jobs. [09:10:25] kevinbazira: yes I am testing it at the moment to see if I can bump debian to bookworm and blubber to 0.23 [09:11:25] okok we shall run the pipeline once that has been merged [09:13:22] in the new blubber version since it is using a virtualenv the python packages are in a different directory so it is taking more time to test it [09:14:02] perhaps I can just push the patch with the blubber version we have been using for now and investigate required blubber changes in a different task [09:15:15] sure sure [09:16:09] I remember you created a task for that: https://phabricator.wikimedia.org/T367293 :) [09:17:34] you're right! I'll work on it for 10-15 minutes more and if I manage to make things work I'll push it with the new version, otherwise I'll fall back to the previous one and update the task in any case with my findings [09:18:07] just to unblock things [09:28:09] 06Machine-Learning-Team: Update blubber version in docker images - https://phabricator.wikimedia.org/T367293#9891799 (10isarantopoulos) [09:36:14] ok it works, I'm pushing the new changes now [09:41:04] (03PS2) 10Ilias Sarantopoulos: ci: add blubber for articlequality [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1042154 (https://phabricator.wikimedia.org/T360455) [09:41:42] (03PS3) 10Ilias Sarantopoulos: ci: add blubber for articlequality [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1042154 (https://phabricator.wikimedia.org/T360455) [09:41:53] (03CR) 10CI reject: [V:04-1] ci: add blubber for articlequality [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1042154 (https://phabricator.wikimedia.org/T360455) (owner: 10Ilias Sarantopoulos) [09:45:18] (03PS4) 10Ilias Sarantopoulos: ci: add blubber for articlequality [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1042154 (https://phabricator.wikimedia.org/T360455) [09:45:28] (03CR) 10CI reject: [V:04-1] ci: add blubber for articlequality [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1042154 (https://phabricator.wikimedia.org/T360455) (owner: 10Ilias Sarantopoulos) [09:51:08] (03CR) 10Ilias Sarantopoulos: "I have tested building both the production and the test image." [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1042154 (https://phabricator.wikimedia.org/T360455) (owner: 10Ilias Sarantopoulos) [10:00:02] (03CR) 10Ilias Sarantopoulos: [C:03+2] articlequality: add CI pipelines [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1043644 (https://phabricator.wikimedia.org/T360455) (owner: 10Kevin Bazira) [10:00:06] (03CR) 10Ilias Sarantopoulos: [C:03+1] articlequality: add CI pipelines [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1043644 (https://phabricator.wikimedia.org/T360455) (owner: 10Kevin Bazira) [10:00:42] kevinbazira: everything seems ready. I think we can try to merge your patch so that we will see CI build in the patch that adds the blubber image [10:00:59] otherwise we just add the changes in one patch [10:01:08] is it ok if I try to merge your patch? [10:01:32] yeah sure no problem [10:03:29] (03CR) 10Ilias Sarantopoulos: [V:03+2 C:03+2] articlequality: add CI pipelines [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1043644 (https://phabricator.wikimedia.org/T360455) (owner: 10Kevin Bazira) [10:04:26] (03PS5) 10Ilias Sarantopoulos: ci: add blubber for articlequality [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1042154 (https://phabricator.wikimedia.org/T360455) [10:04:40] ok, done and I rebased the other patch [10:05:17] thanks for help Kevin <3 [10:06:25] great! the CI pipeline seems to be running now :) [10:10:18] * isaranto afk lunch! [12:35:04] if anyone is around a review here would be great so I can make an attempt to push liftwing-python to PyPI https://github.com/wikimedia/liftwing-python/pull/17 [12:35:41] mercelisv: I copied the README.md from your PR (https://github.com/wikimedia/liftwing-python/pull/16) so that it can be in the first version [12:39:38] kevinbazira: I think it would be you to do the review whenever you have some time [13:15:18] I think I'm going to try to force push it so I have the time to retry if the first attempt fails [13:26:52] done! [13:27:02] `pip install liftwing` \o/ [13:34:07] nice :) [13:35:56] o/ [13:36:35] in other new the blubber etc for articlequality is ready again for review with bookworm - kserve 0.13 and blubber 0.23 :) https://gerrit.wikimedia.org/r/c/machinelearning/liftwing/inference-services/+/1042154 [13:36:49] *news [13:39:53] (03CR) 10Klausman: [C:03+1] ci: add blubber for articlequality (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1042154 (https://phabricator.wikimedia.org/T360455) (owner: 10Ilias Sarantopoulos) [13:40:02] one tiny nit, otherwise LGTM [13:41:25] nit picking is very welcome! [13:41:38] good :) [13:41:39] I am a weird type of human (if one). [13:48:47] (03PS6) 10Ilias Sarantopoulos: ci: add blubber for articlequality [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1042154 (https://phabricator.wikimedia.org/T360455) [13:49:23] I think I got it right! [13:49:31] (03CR) 10Klausman: [C:03+1] ci: add blubber for articlequality [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1042154 (https://phabricator.wikimedia.org/T360455) (owner: 10Ilias Sarantopoulos) [14:07:32] (03CR) 10Ilias Sarantopoulos: [C:03+2] ci: add blubber for articlequality [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1042154 (https://phabricator.wikimedia.org/T360455) (owner: 10Ilias Sarantopoulos) [14:08:18] (03Merged) 10jenkins-bot: ci: add blubber for articlequality [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1042154 (https://phabricator.wikimedia.org/T360455) (owner: 10Ilias Sarantopoulos) [14:12:02] Good morning all [14:15:22] morning Chris o/ [14:33:19] isaranto: https://pypi.org/project/liftwing/ 🎉 [14:33:23] ^-- 0.1.0 works great! [14:33:24] the model metadata is a good feature. it would be great to highlight it in the README so users can be aware of it. (for situations where a user wants to see a specific model's metadata) :) [14:35:41] Ack! [14:36:34] Yeah it would be good to highlight it indeed [14:38:36] If you have something specific in mond feel free to open a PR ( or make a suggestion here ofc) [15:43:27] Logging off, have a nice weekend every1 o/ [15:44:17] 06Machine-Learning-Team, 06DC-Ops, 10ops-codfw, 06SRE: hw troubleshooting: memory errors during boot for ml-staging2001.codfw.wmnet - https://phabricator.wikimedia.org/T366670#9893496 (10Jhancock.wm) when would be a good time to coordinate this one for maintenance? I can upgrade the idrac version and resea... [15:47:12] \o [19:38:16] 06Machine-Learning-Team, 10Wikilabels, 10Cloud-VPS (Debian Buster Deprecation): Cloud VPS "wikilabels" project Buster deprecation - https://phabricator.wikimedia.org/T367562#9894377 (10Pppery)