[06:34:38] Good morning! [07:42:49] isaranto: o/ [07:42:56] thanks for the review :) [07:43:17] going to deploy logo-detection on staging [07:52:13] the pod is up and running: https://phabricator.wikimedia.org/P65452 \o/ [07:53:36] o/ [07:53:52] wow now logo-detection gets the image via parameter, very nice :) [07:58:01] nice kevin! [07:58:04] hi Luca [08:14:06] 06Machine-Learning-Team, 13Patch-For-Review: Return response time as part of the logo-detection response object - https://phabricator.wikimedia.org/T367962#9925125 (10kevinbazira) The logo detection service now returns a `latency` key in the response object. This key provides a breakdown of the response time (... [08:25:45] elukey: o/ [08:25:45] yes, it does. it was agreed that processing base64 encoded image objects was better than image URLs since images in the commons upload wizard are private to the user. [09:10:46] Morning! [09:11:39] hey! [09:25:51] How does one get from a revisison id and a wikiname to an actual page that revision is in the history of? [09:26:47] I usually use https://XX.wikipedia.org/w/index.php?&diff=YYYYY [09:27:02] ah, ty! [09:35:20] I am deploying a change for Security Contexts (https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1026954) in prod-codfw, starting with the experimental NS and then proceeding alphabetically. Beyond services restarting, there should be no disruption. [09:36:10] Oh. Nothing experimental, so scratch that bit :) [09:38:26] ack! [09:39:37] klausman: as follow up, after the kserve rollout for the security context, we should also do ores-legacy and recommendation-api-ng [09:39:50] agreed [09:39:52] in theory the python-webapp chart should already be ready to go [09:40:25] there was also mention of updating the knative chart, but I haven't looked into it [09:56:58] yep in theory knative, kserve and istio are all in need of the new seccomp configs to move to PSS [10:03:40] So I've just updated the first revscoring-based isvcs, and using httpbb, they now fail with "Method not allowed", investigating [10:03:55] (revscoring-articlequality) [10:07:19] It's onl;y the POST to /v2/models/... that fails, POSTing to /v1/.... works fine [10:08:32] Have we seen this before? [10:10:34] (03PS3) 10AikoChou: revertrisk: accept revision data as input and bypass MWAPI [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1031512 [10:15:39] wtf, my copy of the httpbb test definitions somehow changed all path lines from v1 to v2?! [10:19:13] Wild. But at least it's a PEBKAC, not something broken with prod [10:23:19] wild indeed! for the record we don't use the v2 endpoints (yet) [10:27:39] yeah, I was a bit surprised, but I thought we maybe did something to accommodate ores-legacy [10:28:07] whatever I did I also bumped all the expected return codes 200->201, so that's how I noticed. [10:50:29] * klausman lunch [12:04:09] (03PS4) 10AikoChou: revertrisk: accept revision data as input and bypass MW API [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1031512 [12:15:14] Good morning all [12:22:08] heyo chris [12:31:40] 06Machine-Learning-Team: Allow calling revertrisk language agnostic and revert risk multilingual APIs in a pre-save context - https://phabricator.wikimedia.org/T356102#9926211 (10achou) @kostajh yeah we can keep it very simple - all fields need to be provided by the caller, and missing any field will result in a... [12:32:15] Moorning o/ [12:36:21] (03PS5) 10AikoChou: revertrisk: accept revision data as input and bypass MW API [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1031512 (https://phabricator.wikimedia.org/T356102) [12:41:06] How do people feel about splitting up the httpbb test definition files (test_liftwing_*.yaml) into per-namespace files? Would make it easier for stuff like the rollout I just did. And running all tests is still easy since httpbb can take multiple args so you could use them all in one go. [12:46:22] that sounds a good idea! but we have multiple namespaces (revscoring-*) for revscoring models, it would be nice they are in one file [12:46:43] I'm not against it, I'd just like to maintain the ease of running all tests at one go for testing [12:47:04] you could use e.g. `httpbb --host inference.svc.eqiad.wmnet --https_port 30443 /srv/deployment/httpbb-tests/liftwing/test_liftwing_prod_revscoring*.yaml` [12:47:21] that would use all the test files with that pattern [12:48:03] Similar, `httpbb --host inference.svc.eqiad.wmnet --https_port 30443 /srv/deployment/httpbb-tests/liftwing/*` to test all services defined in the directory [12:48:06] TIL [12:48:13] I just tried `httpbb --host inference.svc.eqiad.wmnet --https_port 30443 /srv/deployment/httpbb-tests/liftwing/test_liftwing*.yaml` [12:48:21] then it SGTM! [12:48:54] Note that the selected host will limit it to p[rod/staging in eqiad/codfw, so you may have to run up to three commands, one for each cluster/env [12:49:30] it sounds definitely better to maintain as well. Right now the files are quite long... [12:49:54] Ok, I will make a patch and send it for review [12:50:43] one suggestion: create separate directories for production and staging since we don't have the same things deployed [12:51:10] yeah, I was considering doing that or keeping prod vs staging in the filenames. directories sound better [12:51:12] or if that doesnt help add the test_liftwing_staging_*and test_liftwing_prod_* in the names [12:51:31] ok! [14:08:45] (03CR) 10Sohom Datta: "@jsherman@wikimedia.org (and @siddharthvp@gmail.com) Could y'all take a final look at this and suggest improvements. I'll be nice to merge" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1035044 (https://phabricator.wikimedia.org/T218132) (owner: 10Rockingpenny4) [15:20:05] (03CR) 10Ilias Sarantopoulos: [C:03+1] "LGTM!" [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1049489 (https://phabricator.wikimedia.org/T308164) (owner: 10Kevin Bazira) [15:21:46] (03CR) 10Kevin Bazira: [C:03+2] "Thanks for the review :)" [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1049489 (https://phabricator.wikimedia.org/T308164) (owner: 10Kevin Bazira) [15:23:56] (03Merged) 10jenkins-bot: Update repo docs to match LiftWing API GW docs [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1049489 (https://phabricator.wikimedia.org/T308164) (owner: 10Kevin Bazira) [15:30:41] (03CR) 10Ilias Sarantopoulos: revertrisk: accept revision data as input and bypass MW API (032 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1031512 (https://phabricator.wikimedia.org/T356102) (owner: 10AikoChou) [15:32:16] going afk folks have a nice rest of day/evening [16:04:19] bye Ilias! talk to you tomorrow :) [16:13:18] (03PS6) 10AikoChou: revertrisk: accept revision data as input and bypass MW API [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1031512 (https://phabricator.wikimedia.org/T356102) [16:26:20] (03PS7) 10AikoChou: revertrisk: accept revision data as input and bypass MW API [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1031512 (https://phabricator.wikimedia.org/T356102) [16:27:26] (03CR) 10AikoChou: revertrisk: accept revision data as input and bypass MW API (032 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1031512 (https://phabricator.wikimedia.org/T356102) (owner: 10AikoChou) [18:01:55] (03CR) 10Ilias Sarantopoulos: [C:03+1] "LGTM!" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1031512 (https://phabricator.wikimedia.org/T356102) (owner: 10AikoChou) [18:58:18] (03PS1) 10Ebrahim: Make Special:ORESModels compatible with night mode [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1050024 (https://phabricator.wikimedia.org/T366379) [18:59:22] (03PS2) 10Ebrahim: Make Special:ORESModels compatible with night mode [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1050024 (https://phabricator.wikimedia.org/T366379) [19:03:09] (03PS3) 10Ebrahim: Make Special:ORESModels compatible with night mode [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1050024 (https://phabricator.wikimedia.org/T366379) [19:03:46] 06Machine-Learning-Team, 10ORES, 05FY2023-24-WE 2.1 Typography and palette customizations, 13Patch-For-Review, 10Web-Team-Backlog (Needs Prioritization (Tech)): Special:ORESModels doesnt work in night theme - https://phabricator.wikimedia.org/T366379#9928028 (10Jdlrobson) [19:07:18] (03CR) 10Jdlrobson: [C:04-1] "Thanks for the patch! I have a small request for you, after which I can merge!" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1050024 (https://phabricator.wikimedia.org/T366379) (owner: 10Ebrahim) [19:11:45] 06Machine-Learning-Team, 10ORES, 10Growth-Team-Filtering, 10PageTriage, and 2 others: Add ORES topic prediction to the NewPagesFeed - https://phabricator.wikimedia.org/T218132#9928061 (10Scardenasmolinar) [19:13:24] (03PS4) 10Ebrahim: Make Special:ORESModels compatible with night mode [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1050024 (https://phabricator.wikimedia.org/T366379) [19:24:20] (03CR) 10Ebrahim: Make Special:ORESModels compatible with night mode (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1050024 (https://phabricator.wikimedia.org/T366379) (owner: 10Ebrahim) [19:25:18] (03PS5) 10Ebrahim: Make Special:ORESModels compatible with night mode [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1050024 (https://phabricator.wikimedia.org/T366379) [19:29:48] (03CR) 10SD0001: Adds article topic model to ORES (032 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1035044 (https://phabricator.wikimedia.org/T218132) (owner: 10Rockingpenny4) [20:56:39] (03CR) 10Jdlrobson: [C:03+2] "This is great! Thank you!" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1050024 (https://phabricator.wikimedia.org/T366379) (owner: 10Ebrahim) [20:59:46] (03Merged) 10jenkins-bot: Make Special:ORESModels compatible with night mode [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1050024 (https://phabricator.wikimedia.org/T366379) (owner: 10Ebrahim)