[05:40:15] (03PS7) 10Kevin Bazira: article-country: initial commit [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1075033 (https://phabricator.wikimedia.org/T371897) [05:40:29] (03CR) 10CI reject: [V:04-1] article-country: initial commit [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1075033 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [05:41:02] (03CR) 10Kevin Bazira: article-country: initial commit (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1075033 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [05:44:43] (03CR) 10Kevin Bazira: [V:03+2 C:03+2] "Thanks for the reviews!" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1075033 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [05:44:56] (03CR) 10CI reject: [V:04-1] article-country: initial commit [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1075033 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [05:48:13] (03PS3) 10Kevin Bazira: article-country: containerize model-server [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077391 (https://phabricator.wikimedia.org/T371897) [05:58:12] (03CR) 10CI reject: [V:04-1] article-country: containerize model-server [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077391 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [07:14:29] (03CR) 10AikoChou: "Only two small things about the code structure. I'd like to know your thoughts.. thanks for your patience." [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1075033 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [07:17:05] hello! [07:17:33] (03CR) 10AikoChou: "Thanks! It is fixed now. :)" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077391 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [07:24:28] regarding the open patches, I was discussing with Kevin and I think that the solution is what Aiko pointed out in https://gerrit.wikimedia.org/r/c/machinelearning/liftwing/inference-services/+/1077391 [07:25:07] the article-country pipeline is missing that is why CI is failing (we only have the article-country-publish in the config.yaml). If we add it CI would likely pass [07:27:15] so I think that the new integration/config patch https://gerrit.wikimedia.org/r/c/integration/config/+/1078793 is not needed [07:27:38] kevinbazira aiko --^ wdyt? [07:32:42] yeah one pipeline is missing, we can see if CI works after we add the missing pipeline. [07:42:44] o/ morning! :) [07:45:16] (03PS4) 10Nik Gkountas: Support Default collections [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1072175 (https://phabricator.wikimedia.org/T374597) (owner: 10Santhosh) [07:48:34] (03PS4) 10Kevin Bazira: article-country: containerize model-server [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077391 (https://phabricator.wikimedia.org/T371897) [07:58:07] (03CR) 10CI reject: [V:04-1] article-country: containerize model-server [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077391 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [07:58:19] isaranot --^ [07:58:43] isaranto --^ [07:59:40] the patch to temporarily deactivate CI is needed [07:59:59] Morning! [08:01:23] o/ Tobias [08:02:06] kevinbazira: in the above errors from CI I see an issue coming from the formatting of countries.csv. [08:02:38] (03CR) 10Kevin Bazira: article-country: containerize model-server (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077391 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [08:27:33] kevinbazira: running the pre-commit hooks on the initial-commit https://gerrit.wikimedia.org/r/c/machinelearning/liftwing/inference-services/+/1075033 would fix the CI issues [08:27:44] there are some trailing whitespaces in countries.csv [08:28:10] you can find the error message here https://integration.wikimedia.org/ci/job/inference-services-pipeline-article-country/5/console [08:28:20] let me know if you need any help [08:38:47] (03PS8) 10Kevin Bazira: article-country: initial commit [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1075033 (https://phabricator.wikimedia.org/T371897) [08:39:18] (03CR) 10Kevin Bazira: article-country: initial commit (032 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1075033 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [09:15:44] (03CR) 10AikoChou: [C:03+1] "LGTM!" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1075033 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [09:16:33] (03CR) 10AikoChou: [C:03+1] "LGTM!" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077391 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [09:22:46] (03CR) 10Ilias Sarantopoulos: [C:03+1] "Done" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1075033 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [09:28:03] (03CR) 10Kevin Bazira: [V:03+2 C:03+2] "Thanks for the reviews!" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1075033 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [09:31:19] (03CR) 10Kevin Bazira: "recheck" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077391 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [09:31:44] (03PS5) 10Kevin Bazira: article-country: containerize model-server [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077391 (https://phabricator.wikimedia.org/T371897) [09:41:02] (03CR) 10jenkins-bot: article-country: containerize model-server [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077391 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [09:43:30] (03CR) 10Kevin Bazira: [C:03+2] "Thanks for the reviews!" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077391 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [09:52:19] (03Merged) 10jenkins-bot: article-country: containerize model-server [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077391 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [10:16:55] * aiko lunch! [10:23:40] ditto! [10:26:00] Me too! [13:25:40] (03PS5) 10AikoChou: locust: entry for reference-risk model [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077310 (https://phabricator.wikimedia.org/T372405) [13:50:47] (03CR) 10Ilias Sarantopoulos: [C:03+1] "I left a suggestion but it LGTM anyway" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077310 (https://phabricator.wikimedia.org/T372405) (owner: 10AikoChou) [14:01:02] (03CR) 10Kevin Bazira: [C:03+1] "Thank you for working on this, Aiko! I tested this and it run without issues:" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1077310 (https://phabricator.wikimedia.org/T372405) (owner: 10AikoChou) [16:13:49] * isaranto afk!