[07:43:09] (03PS1) 10Kevin Bazira: article-country: update response schema [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088214 (https://phabricator.wikimedia.org/T371897) [08:48:35] Hello! [09:10:16] (03PS1) 10AikoChou: utils: decorators for logging the size of fetched and preprocessed data [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088231 (https://phabricator.wikimedia.org/T374034) [09:15:27] (03CR) 10AikoChou: "I tested the articlequality model locally." [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088231 (https://phabricator.wikimedia.org/T374034) (owner: 10AikoChou) [09:16:46] Hi isaranto! It's a pleasure [09:17:24] o/ JJStrebeyko [09:17:28] I was trying to reach you all the possible means I could think of, so you can see my face in your linkedin [09:18:21] anyway, first of - huge fan of your work. have been trying to catch up with it around Left Wing, but still wrapping my head around Phabricator [09:22:07] I am a researcher at University of Warsaw who's into deep learning (computational cognitive science) and the problems of modern democracies (applied social sciences). Did a presentation on a conference in Poland this year about Wikipedia, what a special source of truth it is; how it is maintained by volunteers and how Big Corp and governments (WikiScanner '07) are all trying to influence the Knowledge Panel using Wikipedia [09:22:07] underneath. [09:22:39] appreciate your kind words. our phabricator board is a bit tough to navigate, that's true! it is a work in progress! [09:22:43] awesome! [09:25:16] I know about what happened to Croatian Wikipedia starting 2003. Was wandering what's Wikimedia ML Team member's take on that, do you think it could be prevented by computational means? [09:26:55] (phabricator is a bit rough, but the task at hand is rougher) [09:47:51] (03PS1) 10AikoChou: metric_utils.py: add prometheus metrics for fetched and preprocessed data size [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088242 (https://phabricator.wikimedia.org/T374034) [09:49:13] (03PS2) 10AikoChou: metric_utils.py: add prometheus metrics for fetched/preprocessed size [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088242 (https://phabricator.wikimedia.org/T374034) [09:53:19] (03PS2) 10AikoChou: reference-quality: update output schema [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1087446 (https://phabricator.wikimedia.org/T378939) [09:54:16] aiko is on 🔥 [09:55:28] (03CR) 10CI reject: [V:04-1] metric_utils.py: add prometheus metrics for fetched/preprocessed size [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088242 (https://phabricator.wikimedia.org/T374034) (owner: 10AikoChou) [10:10:18] 10Lift-Wing, 06Machine-Learning-Team, 13Patch-For-Review: Log and export preprocess size in inference services as a prometheus metric - https://phabricator.wikimedia.org/T374034#10298858 (10achou) Adding the `prometheus-client` package caused conflicting dependencies, resulting in [[ https://gerrit.wikimedia... [10:12:34] just fyi me and JJStrebeyko chatted a bit privately - JJ has been doing interesting work on fighting misinformation and NPOV so I said it might be interesting to reach out to the research team [10:16:33] I'll send a patch for adding load testing for damaging models on ml-staging [10:21:49] (03CR) 10AikoChou: "As I noted in https://phabricator.wikimedia.org/T374034#10298858, the failed CI test builds are caused by conflicting `prometheus-client` " [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088242 (https://phabricator.wikimedia.org/T374034) (owner: 10AikoChou) [10:24:38] (03PS1) 10Ilias Sarantopoulos: locust: add test for enwiki damaging [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088255 [10:26:02] aiko: you could loosen the prometheus-client requirement in the python/requirements.txt in sth that would allow both kserve versions to be installed [10:30:47] e.g. use prometheus-client>=0.13.1 in python/requirements.txt. wdyt? [10:33:17] isaranto: ahh right! I didn't think about it [10:33:31] isaranto: thank u!! [10:34:47] (03PS3) 10AikoChou: metric_utils.py: add prometheus metrics for fetched/preprocessed size [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088242 (https://phabricator.wikimedia.org/T374034) [10:36:25] it is not ideal but we just want to have the requirements listed in the python utils [10:37:52] (03PS2) 10Ilias Sarantopoulos: locust: add test for enwiki damaging [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088255 [10:42:10] turned it in WIP --^ it is failing [11:00:37] anybody having any issus with gerrit or is it just me? [11:02:37] 06Machine-Learning-Team: [ml-lab] Use a (jupyter) notebook and load a LLM from huggingface - https://phabricator.wikimedia.org/T377574#10298925 (10isarantopoulos) Resolving this as the the necessary info has been added to the [[ https://wikitech.wikimedia.org/wiki/Machine_Learning/ML-Lab | ml-lab Wikitech pa... [11:02:39] 06Machine-Learning-Team: [ml-lab] Use a (jupyter) notebook and load a LLM from huggingface - https://phabricator.wikimedia.org/T377574#10298926 (10isarantopoulos) 05Open→03Resolved [11:03:18] 06Machine-Learning-Team: Investigate kserve 0.13.0 upgrade - https://phabricator.wikimedia.org/T367048#10298928 (10isarantopoulos) [11:08:35] 06Machine-Learning-Team: Investigate kserve 0.13.0 upgrade - https://phabricator.wikimedia.org/T367048#10298936 (10isarantopoulos) I ran some load tests on revscoring with wrk before: ` wrk -c 1 -t 1 --timeout 2s -s inference-damaging.lua https://inference.svc.codfw.wmnet:30443/v1/models/enwiki-damaging:predic... [11:14:11] (03CR) 10Klausman: metric_utils.py: add prometheus metrics for fetched/preprocessed size (033 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088242 (https://phabricator.wikimedia.org/T374034) (owner: 10AikoChou) [11:14:53] Morning! [11:17:02] Hola! [11:18:28] (03PS3) 10Ilias Sarantopoulos: locust: add test for enwiki damaging [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088255 [11:34:45] 06Machine-Learning-Team: Investigate kserve 0.13.0 upgrade - https://phabricator.wikimedia.org/T367048#10299001 (10isarantopoulos) Revscoring has been upgraded to kserve 0.13.1 This is the updated state on kserve versions: | **service** | **kserve version** | | reference quality| 0.13.1| |revscoring | 0.13.1 |... [11:35:41] (03PS9) 10Ilias Sarantopoulos: ores-legacy: add deprecation message to UI endpoint and change migration deadline [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1030178 (https://phabricator.wikimedia.org/T349996) [11:36:44] (03CR) 10CI reject: [V:04-1] ores-legacy: add deprecation message to UI endpoint and change migration deadline [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1030178 (https://phabricator.wikimedia.org/T349996) (owner: 10Ilias Sarantopoulos) [12:16:09] (03PS10) 10Ilias Sarantopoulos: ores-legacy: add deprecation message to UI endpoint and change migration deadline [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1030178 (https://phabricator.wikimedia.org/T349996) [12:17:47] (03CR) 10CI reject: [V:04-1] ores-legacy: add deprecation message to UI endpoint and change migration deadline [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1030178 (https://phabricator.wikimedia.org/T349996) (owner: 10Ilias Sarantopoulos) [12:33:15] (03PS11) 10Ilias Sarantopoulos: ores-legacy: add deprecation message to UI endpoint and change migration deadline [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1030178 (https://phabricator.wikimedia.org/T349996) [12:35:42] (03PS1) 10Ilias Sarantopoulos: ores-legacy: fix ci test image [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088285 [12:36:09] (03PS12) 10Ilias Sarantopoulos: ores-legacy: add deprecation message to UI endpoint and change migration deadline [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1030178 (https://phabricator.wikimedia.org/T349996) [12:37:05] (03PS2) 10Ilias Sarantopoulos: ores-legacy: fix ci test image [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088285 [12:37:53] (03CR) 10CI reject: [V:04-1] ores-legacy: add deprecation message to UI endpoint and change migration deadline [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1030178 (https://phabricator.wikimedia.org/T349996) (owner: 10Ilias Sarantopoulos) [12:38:57] (03CR) 10Ilias Sarantopoulos: "will be merged after the CI fixes in the patch" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1030178 (https://phabricator.wikimedia.org/T349996) (owner: 10Ilias Sarantopoulos) [13:24:21] (03CR) 10Ilias Sarantopoulos: [C:03+1] "Some minor comments other than that it looks good!" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1087446 (https://phabricator.wikimedia.org/T378939) (owner: 10AikoChou) [13:42:31] (03CR) 10Kevin Bazira: [C:03+1] "LGTM! Tested locally by running:" [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088285 (owner: 10Ilias Sarantopoulos) [13:47:19] (03CR) 10Ilias Sarantopoulos: [C:03+1] reference-quality: update output schema (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1087446 (https://phabricator.wikimedia.org/T378939) (owner: 10AikoChou) [13:47:43] (03CR) 10Ilias Sarantopoulos: article-country: update response schema (034 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088214 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [13:48:14] (03CR) 10Ilias Sarantopoulos: [C:03+2] ores-legacy: fix ci test image [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088285 (owner: 10Ilias Sarantopoulos) [13:48:30] (03PS13) 10Ilias Sarantopoulos: ores-legacy: add deprecation message to UI endpoint and change migration deadline [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1030178 (https://phabricator.wikimedia.org/T349996) [13:54:34] (03CR) 10Kevin Bazira: [C:03+1] ores-legacy: add deprecation message to UI endpoint and change migration deadline [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1030178 (https://phabricator.wikimedia.org/T349996) (owner: 10Ilias Sarantopoulos) [14:03:57] (03CR) 10Klausman: utils: decorators for logging the size of fetched and preprocessed data (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088231 (https://phabricator.wikimedia.org/T374034) (owner: 10AikoChou) [14:28:47] * isaranto afk - be back later [14:36:59] (03PS2) 10Kevin Bazira: article-country: update response schema [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088214 (https://phabricator.wikimedia.org/T371897) [14:37:40] (03CR) 10CI reject: [V:04-1] article-country: update response schema [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088214 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [14:42:39] (03PS3) 10Kevin Bazira: article-country: update response schema [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088214 (https://phabricator.wikimedia.org/T371897) [14:48:00] (03CR) 10Kevin Bazira: article-country: update response schema (034 comments) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088214 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [16:13:26] (03CR) 10Nik Gkountas: [C:03+2] Implement batching in get_wiki_page_info [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1087962 (https://phabricator.wikimedia.org/T379037) (owner: 10Sbisson) [16:14:54] (03Merged) 10jenkins-bot: Implement batching in get_wiki_page_info [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1087962 (https://phabricator.wikimedia.org/T379037) (owner: 10Sbisson) [16:28:27] (03PS1) 10Sbisson: Remove print() [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1088333 (https://phabricator.wikimedia.org/T379037) [16:44:57] (03CR) 10Nik Gkountas: [C:03+2] "I had a draft comment that I forgot about, and then I gave a +2 to the previous patch. Anyway, good catch." [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1088333 (https://phabricator.wikimedia.org/T379037) (owner: 10Sbisson) [16:45:38] (03Merged) 10jenkins-bot: Remove print() [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1088333 (https://phabricator.wikimedia.org/T379037) (owner: 10Sbisson) [16:47:28] (03PS9) 10Sbisson: API Continue support [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1061713 (https://phabricator.wikimedia.org/T379037) (owner: 10Santhosh) [17:26:31] (03CR) 10Ilias Sarantopoulos: article-country: update response schema (031 comment) [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1088214 (https://phabricator.wikimedia.org/T371897) (owner: 10Kevin Bazira) [17:26:58] (03CR) 10Ilias Sarantopoulos: [C:03+2] ores-legacy: add deprecation message to UI endpoint and change migration deadline [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1030178 (https://phabricator.wikimedia.org/T349996) (owner: 10Ilias Sarantopoulos) [17:27:40] (03Merged) 10jenkins-bot: ores-legacy: add deprecation message to UI endpoint and change migration deadline [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1030178 (https://phabricator.wikimedia.org/T349996) (owner: 10Ilias Sarantopoulos) [22:15:59] (03CR) 10Nik Gkountas: [C:04-1] "works fine. Just a couple of minor issues" [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1061713 (https://phabricator.wikimedia.org/T379037) (owner: 10Santhosh) [22:32:40] (03PS1) 10Nik Gkountas: update cache in a single thread [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1088376 (https://phabricator.wikimedia.org/T379036) [22:33:20] (03CR) 10CI reject: [V:04-1] update cache in a single thread [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1088376 (https://phabricator.wikimedia.org/T379036) (owner: 10Nik Gkountas) [22:35:29] (03PS1) 10Nik Gkountas: fix return type for all __hash__ methods to be int [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1088377 [22:39:11] (03PS2) 10Nik Gkountas: update cache in a single thread [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1088376 (https://phabricator.wikimedia.org/T379036) [22:58:54] (03PS1) 10Nik Gkountas: remove level 1 and 2 pages from "Vital articles" default collections [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/1088382 (https://phabricator.wikimedia.org/T374597)