[06:50:05] good morning [06:50:37] moin [07:00:56] good morning [07:05:32] good morning! [07:13:40] iirc regarding the above error in revertrisk models we started throwing an InferenceError (500) at some point instead of a 400 while checking the languages. we should make it a 400 as Luca mentioned above [07:16:18] a no nevermind. [07:17:41] we dont need to raise a 400 if the model is not in the initial list of wikis because we support all wikis by some default feature values. However we should be checking against canonical wiki names to avoid getting an error from mwapi [07:40:28] ^--- looking [07:59:59] 10Lift-Wing, 06Machine-Learning-Team: revertrisk model servers should return a 400 response for non canonical language names - https://phabricator.wikimedia.org/T399437 (10isarantopoulos) 03NEW [08:02:07] kevinbazira: thanks for looking. It isn't urgent but we should indeed fix this. I opened a task --^ to track this and added it in our log as well [08:02:33] great, ty! [08:58:50] 10Lift-Wing, 06Machine-Learning-Team: revertrisk model servers should return a 400 response for non canonical language names - https://phabricator.wikimedia.org/T399437#10999218 (10achou) We can implement a function like below in preprocess_utils.py to check lang against the [canonical wikis.tsv](https://gitla... [11:52:10] elukey: I'll deploy MinT/machinetranslation now. Let me know if you're around. Gives me confidence ;) [12:14:15] Starting with staging. [12:33:35] and done! [12:57:33] kart_: sorry I was afk! [12:57:36] nice :) [13:01:06] Thanks for all the help! [13:04:04] it was a long one but I am glad that we solved it [13:05:44] yes! [13:06:08] elukey: Can you file a task for updating from old deployment.yaml as well? [13:07:09] We also need to move http_base and http_bucket away from entrypoint.sh [13:08:03] kart_: I think it is fine to leave as is [13:49:01] 06Machine-Learning-Team, 07Essential-Work: Update knative's queue proxy image and the Swift/S3 accounts used on ml-serve clusters - https://phabricator.wikimedia.org/T398533#11000373 (10isarantopoulos) Changes have been deployed in codfw (`ml-staging-codfw` and `ml-serve-codfw`). eqiad will need to be depooled... [13:51:42] elukey: o/ kevinbazira will be rolling out the above changes --^ to ml-serve-eqiad. Do you have any time this week to assist by depooling eqiad? [13:52:21] isaranto: anytime in the morning is fine [13:52:59] thank you! kevinbazira I'll let you two coordinate on this then. ping me if I can help with anything else [13:53:37] thanks! I'll ping elukey tomorrow morning [14:22:30] (03PS1) 10Dreamy Jazz: Exclude boilerplate maintenance script code from test coverage [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1169142 (https://phabricator.wikimedia.org/T399460) [14:52:40] 06Machine-Learning-Team, 06Research, 05Goal: AI/ML Model Request: "Improve Tone" Suggested Edit - https://phabricator.wikimedia.org/T392283#11000796 (10isarantopoulos) [14:55:18] 06Machine-Learning-Team, 05Goal: AI/ML Infrastructure Request: **Accessing topics endpoints at scale** - https://phabricator.wikimedia.org/T392833#11000817 (10isarantopoulos) [14:56:32] 06Machine-Learning-Team, 10EditCheck, 10VisualEditor, 07Chinese-Sites, 10Editing-team (Tracking): Prepare annotool for Tone Check model evaluation - https://phabricator.wikimedia.org/T392324#11000826 (10SSalgaonkar-WMF) 05Open→03Resolved [16:20:05] (03PS1) 10Kevin Bazira: RRLA: Validate lang parameter against canonical wikis [machinelearning/liftwing/inference-services] - 10https://gerrit.wikimedia.org/r/1169195 (https://phabricator.wikimedia.org/T399437) [16:26:32] 10Lift-Wing, 06Machine-Learning-Team, 13Patch-For-Review: revertrisk model servers should return a 400 response for non canonical language names - https://phabricator.wikimedia.org/T399437#11001354 (10kevinbazira) I have pushed a fix for this issue. I tested the solution locally, and below are the results.... [18:17:20] (03CR) 10Novem Linguae: [C:03+2] Exclude boilerplate maintenance script code from test coverage [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1169142 (https://phabricator.wikimedia.org/T399460) (owner: 10Dreamy Jazz) [20:12:51] (03Merged) 10jenkins-bot: Exclude boilerplate maintenance script code from test coverage [extensions/ORES] - 10https://gerrit.wikimedia.org/r/1169142 (https://phabricator.wikimedia.org/T399460) (owner: 10Dreamy Jazz)