[15:36:27] godog: what's up with grouping keys and push gateway? [15:36:43] joal pointed me at https://github.com/prometheus/pushgateway/issues/65 and said I'd have a problem if i didn't use them [15:36:55] but, as far as I can tell, my metrics with different label values look okay [15:41:32] ottomata: I'd need more context, what are you trying to do and what's the problem ? [15:52:58] godog: i think there is not a problem [15:52:59] hm [15:53:02] q [15:53:11] are all labels including in the 'grouping key' by default? [15:53:38] joseph was worried that unless i set a grouping key, metrics with different label values would overwrite each other [15:54:02] my understanding is that depends on the method used (reading from the docs) [15:54:21] which grouping key is used that is [15:54:42] hm [15:54:52] we are using the java client [15:54:56] https://prometheus.github.io/client_java/io/prometheus/client/exporter/PushGateway.html [15:55:08] i'm calling [15:55:08] pushAdd​(Collector collector, String job) [15:55:23] and, from mwhat I can tell my metrics with differnet label values are all pushed correctly [15:57:26] mmhh yeah my reading is that the only grouping key would be 'job' [15:59:01] ottomata: in other words I think the 'job' label would be overwritten if you were to push metrics with a 'job' label different than the grouping key [15:59:06] i.e. 'job' in this case [16:00:12] so say your grouping key is job=good, the metrics within that push with e.g. job=bad would show up with job=good instead [16:00:33] that's my understanding at least, I might be wrong [16:17:36] hm [16:17:37] okay. [16:17:56] but if there are other labels too? [16:18:06] so, i'm only testing one job right now [16:18:17] does that mean if there are different jobs running that are all pushing [16:18:29] that's when it would break? [16:18:36] even if the label values are all distinct? [16:19:09] my understanding is that job=verygood would be distinct grouping key [16:19:18] I don't see how it'd be any useful otherwise [16:20:43] the easiest I think is to test with multiple jobs and other labels [16:25:50] ottomata: gotta go, we can followup here and/or on phab [16:26:30] yeah ok will try with other jobs [16:26:33] thanks godog