[16:49:54] <ryankemper>	 hey o11y, I could use some help figuring out how to properly craft recording rules wrt Search team's WDQS error budget metrics here: https://gerrit.wikimedia.org/r/plugins/gitiles/operations/grafana-grizzly/+/refs/heads/master/slo_definitions.json#110
[16:50:45] <ryankemper>	 I'm not 100% (or even 50% :P) sure on the best way to do that, my initial idea is to record a metric for `wdqs_req_success_ratio` that can be used in the error budget calculations. Here's a rough example patch: https://gerrit.wikimedia.org/r/c/operations/puppet/+/879599
[16:51:28] <ryankemper>	 Am I on the right track here? And what's the best naming convention for the `- record: ...` line? The docs mention the name should follow the convention `level:metric:operations` but I'm not quite sure I'm doing that correctly in my example patch
[17:00:10] <herron>	 hey ryankemper, yes on the right track, I added myself to the patch will have a closer look
[17:16:47] <ryankemper>	 Here's the corresponding patch for the `grafana-grizzly` side showing how the newly recorded metric would be used: https://gerrit.wikimedia.org/r/c/operations/grafana-grizzly/+/879606
[18:40:42] <herron>	 cool, just added myself on that as well.  let's land on the recording rules first, and then we can update the dash to make use of them
[21:46:28] <ryankemper>	 Thanks for the review herron! Ready for another look whenever: https://gerrit.wikimedia.org/r/c/operations/puppet/+/879599/6/modules/profile/files/thanos/recording_rules.yaml
[22:46:55] <herron>	 ryankemper: thanks, just updated, I *think* after this we should be good to go