[11:05:10] godog: yello, I'm running into # TODO(filippo): handle machines with disks attached to raid controllers _and_ regular sata I think [11:05:36] I get unhealthy smart, because smartctl doesn't like auto for md disks [11:05:50] Smartctl open device: /dev/sda failed: DELL or MegaRaid controller, please try adding '-d megaraid,N' [11:05:58] Is that something you've seen already? [11:08:25] claime: hi, I can't remember offhand, which host are you looking at? [11:08:40] All the new mw hosts [11:08:51] mw2429 for instance [11:09:01] ok thank you, I'll take a look now [11:09:04] <3 [11:09:39] I think it may just be some parsing to add so it adds the correct -d megaraid,1 to the smartctl command line [11:09:51] But I wouldn't want to break existing parsing for other hosts [11:13:24] claime: ok so IIRC that comment was for hosts with a mixture of disks attached to raid controllers and not [11:13:55] it looks like to me smartctl is failing to auto-detect what to do on these new hosts, but yeah the script will likely need adjusting to pass the correct flags [11:17:22] I'm re-reading the script and it looks like we're assuming that when using md then smartctl will do the right thing, which is obviously not the case here [11:17:58] Yeah, and I'm not sure how to tell it that it won't work short of trying once, parsing the output, and retrying with a different argument set [11:22:11] mmhh yeah, I'm wondering if the 'raid' fact would return megaraid then things would work [11:22:19] that's easy to test though [11:22:46] I'm saying that because in the megaraid case we do smartctl --scan-open and that does seem to do the right thing [11:24:27] I see in /var/lib/puppet/lib/facter/raid.rb values that perhaps need adding to? [11:24:56] megaraid_sas and the pci IDs I suppose [11:25:38] yeah I'll check the pci ids for our raid controler [11:26:06] Yeah, 65:00.0 RAID bus controller: LSI Logic / Symbios Logic MegaRAID Tri-Mode SAS3516 (rev 01) [11:26:18] That doesn't seem to be in the raid.rb facter [11:26:21] I'll add it [11:26:23] Thanks [11:27:32] for sure! let me know how that goes [11:28:10] yup, testing locally it works [11:28:14] patch incoming [11:29:23] \o/ \o/ \o/ [11:31:27] going to lunch, will take a look later [11:35:13] np, bon appétit [12:56:42] godog: cleaned up all smart alerts, including thanos-fe and ms-fe :D [12:57:20] claime: well done! thank you for taking a look [12:58:51] np, I wouldn't have thought to go and change the facter script tbh [13:00:08] yeah it took me a couple of re-reads of the smart data dump script to jog my memory [13:01:04] sort-of related, at some point in the distro upgrade cycle we should be able to ask smartctl for json output and get rid of the dodgy parsing [13:11:34] buster still only has old, brief or hex [13:19:49] indeed, bullseye it is