[11:45:00] <jbond>	 godog: wonder if you could give some advice on metric design
[11:45:17] <jbond>	 i was thnking of updateing puppet-merge so it drops some data in the node.d folder
[11:45:36] <jbond>	 currently the data im thinking of is starttime, endtime, hash, durations
[11:45:45] <jbond>	 im wondering if i should have something like
[11:46:05] <jbond>	 puppet-merge{start_time, end_time, hash} = duration
[11:46:06] <jbond>	 or
[11:46:20] <jbond>	 puppet_merge_starts_time{hash} = 1
[11:46:26] <jbond>	 puppet_merge_end_time{hash} = 1
[11:46:32] <jbond>	 or something elses?
[12:02:29] <godog>	 jbond: interesting, what sort of info/insight are you looking to get ?
[12:03:09] <jbond>	 w had an issue the other day where merge times whre taking longer then expected so it would be good to track that.  however (and this is creep)
[12:03:35] <jbond>	 we also currently have an issue when we do a merge so it would be good if we could use them the start end time as an anootation
[12:09:47] <godog>	 interesting, ok I would drop sth like puppet_merge_start_time{git_sha=".."} <unix epoch>
[12:09:56] <godog>	 ditto for end time
[12:10:11] <godog>	 git_sha is the same label name as we use for puppet_agent_catalog_version_info
[12:11:10] <jbond>	 godog: yes it can be (currently its the long one but i can trim it)
[12:11:26] <jbond>	 ack ill do that thanks
[12:11:31] <godog>	 yes I recommend doing that so we can correlate if needed
[12:11:51] <jbond>	 +1 sgtm thanks
[12:11:51] <godog>	 feel free to send the reviews my way jbond and we can iterate there too
[12:11:59] <jbond>	 will do thanks
[12:12:07] <godog>	 sure np, thanks for reaching out