[09:00:34] tappof: hello! I just saw https://gerrit.wikimedia.org/r/c/operations/cookbooks/+/1124142 why not use the slug ? [09:01:08] that's usually what we recommend, as it's more machine readable [09:03:39] tappof: you also need to update https://github.com/wikimedia/operations-puppet/blob/08eefaa046b24853b51919047bf7515c315af28c/modules/netbox/types/device/network.pp otherwise puppet will not be happy [09:05:56] actually, we already have it doh :facepalm: [09:08:48] you can blame me tappof ;) [09:09:21] XioNoX: I think I did not understand what you mean by 'slug'. I merged this change https://gerrit.wikimedia.org/r/c/operations/cookbooks/+/1124142 a few minutes ago. If you want to add some code suggestions directly in the patch, I'll be happy to use them. [09:09:45] already commented ;) [09:10:35] I missed a refresh on the Gerrit page... thank you! :) [09:17:56] indeed puppet isn't happy on prometheus hosts atm :( [09:17:58] so yeah puppet is now broken on the prometheus hosts sigh, the puppet patch is the most urgent one [09:18:23] the fix for the graphql query can be done after, it will just change the value to a slightly different string [09:21:26] I'm reverting the change in the cookbook to satisfy Puppet, and I'll submit a new patch for the cookbook later. [09:23:12] sounds good, let's add a big warning in the cookbook too, so we don't get bitten by that trap in the future [09:25:19] given the data is already in the exported repo I think fixing forward would be quicker but up to you [09:30:40] volans, I think you're right. Here is the PS: https://gerrit.wikimedia.org/r/c/operations/puppet/+/1124734 XioNoX [09:31:32] XioNoX: ^^^ [09:31:34] as you're the expert :D [09:31:41] yeah was thinking about the optional [09:31:53] afaik network devices always have a model [09:32:11] I think you cannot have a device without a device type (aka model) [09:32:12] and iiuc the prometheus code relies on the model [09:34:15] tappof: let's update it and remove the Optional[] [09:34:55] So, do you want me to remove the 'Optional' from the field? I added it because of the 'Optional' in the manufacturer field. [09:34:57] XioNoX: why the manufacturer is optional though? [09:34:57] ah ok XioNoX [09:35:12] that puzzles me [09:35:19] also if you remove the optional you need to change the order [09:35:27] yeah volans [09:35:30] as optional fields cannot be before a mandatory field [09:35:49] volans: https://github.com/wikimedia/operations-puppet/commit/b40ebc3fde8a547153d730c3a302339e097cb75c still investigating [09:37:11] in the meanwhile I've sent https://gerrit.wikimedia.org/r/c/operations/cookbooks/+/1124735 for future-proof [09:38:03] XioNoX: volans Optional removed from the PS [09:38:11] dunno why j.ohn added the optional in a separate commit [09:38:20] like he found a case in which was not present [09:41:24] volans: yeah I can't find of a reason [09:42:06] let me check one last thing [09:43:04] Ack, XioNoX. I'll wait to merge the patch. Let me know when I can submit it [09:43:41] I looked at the devices page on netbox sort by manufacturer in both directions, nothing stood up [09:44:29] yes volans same thing I tried yesterday [09:44:29] device type is a mandatory field in the add new device form [09:44:55] and manufacturer is a mandatory field in the add new device type form [09:45:06] yeah, and I went through the whole list of `profile::netbox::data::network_devices:` in puppetserver1001:/srv/git/netbox-hiera# less common.yam [09:45:12] all have a manufacturer [09:45:24] I would remove optional from both Id' say [09:45:26] I was worried it did some mangling with virtual-chassis [09:45:39] ah [09:45:41] let's jsut do the model now to unblock it [09:45:52] the model means changing the cookbook too [09:46:01] if you want the immediate fix leave the optional ;) [09:46:14] volans: why? [09:46:20] doens't care about the order? [09:46:34] I don't think so [09:46:43] I assume puppet is always stupid to be on the safe side [09:46:54] ok then [09:47:12] https://www.irccloud.com/pastebin/xqKRuUOu/ [09:47:21] it's in a different order in the final yaml [09:47:27] k [09:47:37] tappof: go for it! [09:47:44] ack XioNoX [09:50:16] XioNoX: volans merged [09:50:58] probably nicer to force a run on all prometheus hosts if you checked that it worked on one [09:51:11] * volans running on 3003 [09:51:40] btw IMHO you should chat with Jesse to find ways to improve the puppet runs, they cannot be so slow [09:55:16] run ok on 3003 [09:55:27] it worked on 7001 [09:55:29] ok [09:56:08] if needed you can use https://wikitech.wikimedia.org/wiki/Cumin#Run_Puppet_only_if_last_run_failed ;) [09:56:25] running on prometheus hosts only, no need for matching all [09:58:21] I don't know if godog was doing something else... For me, this was the first step in my action plan, so it is not needed [09:59:58] thank you volans and XioNoX for the support, I'll reach out to you with the updated PS related to the cookbook [10:00:10] thx and sorry for the mess [10:01:09] I'm all good [12:28:51] fyi, I'm deploying https://gerrit.wikimedia.org/r/c/operations/puppet/+/1122955 [12:55:51] ack XioNoX