[16:23:11] Amir1: 1000 modules removed since ~2 years ago, https://phabricator.wikimedia.org/P18389 [16:23:32] by proxy of stale metric files under resourceloader_build.* for T298521 [16:23:32] T298521: Numerous Graphite queries stopped working (timeout after 6s) - https://phabricator.wikimedia.org/T298521 [16:25:33] Oh nice. [16:26:11] BTW I cleaned the top deprecated bit (importscriptfromuri or something similar) [16:26:43] okay [16:27:08] I vaguely recall skipping that after a brief manual review because of reliance on the "load only once each url" mechanism that the old function has. [16:27:27] (https://grafana.wikimedia.org/d/000000037/mw-js-deprecate?orgId=1&from=now-30d&to=now&var-Step=24h&refresh=1m) [16:27:39] some user scripts were using that and relying on it. e.g. manyu of them will start with "importScript("MediaWiki:MD5.js") and they would rely on it only loading the first time or smth like that. [16:27:49] but maybe less common when using importScriptURI directly [16:28:49] Some left. I will check those. Likely iterating over global object [16:34:59] Oh and I replaced mw.loader.load('http://[wikimedia uri]') to // to reduce insecure redirects. Didn't check its impact though [16:35:36] I typically use https, but yeah either way should be fine if it's already using mw.loader since that isn't meant to de-dupe. [16:36:04] although with HSTS browsers will generally do that without hitting the network