[02:33:01] I added a multi-DC rollout plan to T279664, see what you think [02:33:03] T279664: Progressive Multi-DC roll out - https://phabricator.wikimedia.org/T279664 [18:42:56] Amir1: doInsert() is a @stable interface currently. [18:43:39] with insert() basically a 'finally' wrapper that should not be overridden [18:43:43] as* [18:44:11] I think moving to sqlPlatform for text formatting is an even better separation though, but I suppose worthy of a release note and ecosystem check. [18:45:58] Something along the lines of: The stable interface for sql method overrides was moved from abstract do* methods to the SqlPlatform interface. This reduces the responsiblity to just the formatting of the sql queries. To override the entire method, insert() etc remain the methods to implement/override as before. (And we can expand that note to list the other methods as well, assuming you're planning to do the same for those) [18:45:58] Krinkle: 😭😭😭😭 [18:46:21] I will. Afk right now [18:46:35] Thanks for the note [18:47:46] ack, left on Gerit as well [18:47:47] LGTM otehrwise