[05:41:57] TimStarling: Reedy: If either of you happen to recall any historical reason /not/ to do https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/816030/1 - would love to know. Not urgent :) [05:59:40] $dbSuffix = $site doesn't make sense, doesn't matter if it works or not [06:06:33] TimStarling: ack, but variable name aside, it seems akward to have SiteConfiguration provide a method that's essentially "split dbname by configured list of suffixes" but then have to manually undo that operation to satisfy the get()/getAll() contract of the same class, using knowledge previously given to the class. [06:07:11] I suppose we could rename the get()/getAll() signature to be $site instead, or e.g. add an extra statement there or extra method like suffixFromSite() that every caller must call for the alias use case. [06:08:07] yes, that's what I was about to write on gerrit, rename the variable to $site [06:08:22] in SiteConfiguration::get() etc. [06:09:08] another option is to modify mergeParams() to add params['site'] to wikitags instead of (or in addition, for theoretical backcompat with someone using 'wiki' in wgConf) which it already has access to I think. [06:09:22] okay, will do that then. [06:13:15] I have a copy of InitialiseSettings.php from 2009, it uses 'wiki' as an array key several times [06:13:47] https://paste.tstarling.com/p/BguiIy.html [06:15:27] and it uses 'wikipedia' not at all [06:16:57] ack, will leave that as-is internally then so that people can pass in whatever they wish. I imagine people still using a suffix like 'wiki' in $wgConf itself would likely not have an alias like 'wiki' => 'wikipedia' at the same time, but anyway, so long as they map it back to 'wiki' as we do in wmf-config then that will work quite precisely as expected. [06:21:48] I opened a copy of CommonSettings.php from 2004 it is giving me the nostalgias [06:23:20] it's so short, 280 lines [06:28:16] " Attempt to remove a hard-coded "wikipedia". " https://github.com/wikimedia/mediawiki/commit/bc2915b7220e4cd7a511213ca54b67743361e684 [06:28:54] Added siteFromDB() 2004, http://mediawiki.org/wiki/Special:Code/MediaWiki/4738 [06:29:12] I was expecting to find a commit that added support for aliased suffixes somtime between 2004 and 2010 [06:29:18] but nope, guess not :) [06:29:42] I removed the passwords so that you can enjoy it too: https://phabricator.wikimedia.org/P31695 [06:42:30] > $wgDBname = $lang . $dbSuffix; [06:42:43] Oh, it was going the other way around [06:43:13] Something we still do in multiversion, but this line likely survived through all that [06:50:28] (this line, being the conditional above it) [06:59:15] I'm reviewing OAuth for multi-DC now, there will be a task eventually [07:08:12] ok, not eventually, it's 5pm Friday. I cut out the WIP and just filed T313578 [07:08:12] T313578: Make OAuth work in Multi-DC active/active mode - https://phabricator.wikimedia.org/T313578 [19:12:44] Krinkle: in X-Wikimedia-Debug's popup.html, the elements are all class=option, but readonly is class=optionx -- is that intentional? [19:12:50] https://gerrit.wikimedia.org/r/plugins/gitiles/performance/WikimediaDebug/+/refs/heads/master/popup.html#23 [20:29:53] ori: it is not! I believe we encountered this in a code review very recently. I figured it'd have landed by now but guess not [20:30:28] It means that the option is ignored by the state sender [20:34:11] Yep, https://gerrit.wikimedia.org/r/c/performance/WikimediaDebug/+/812444 [20:34:42] I need to preview this to see what the UI is like with more options. Will land soon