[01:29:51] <Krinkle>	 AaronSchulz: ack, Ill change the tests then https://gerrit.wikimedia.org/r/c/mediawiki/core/+/817411
[01:30:00] <Krinkle>	 looks like it was added in an attempt to improve code coverage
[04:15:05] <TimStarling>	 I only just realised that there was a pre-existing LoadBalancer dashboard https://grafana-rw.wikimedia.org/d/000000363/mediawiki-mysql-loadbalancer?orgId=1
[04:15:37] <TimStarling>	 I made https://grafana-rw.wikimedia.org/d/G9kbQdRVz/mediawiki-loadbalancer a couple of weeks ago and I think it's better than the old one
[04:16:03] <TimStarling>	 any objections to me deleting the old dashboard?
[04:26:37] <ori>	 +1
[04:27:01] <ori>	 there's a link to the old one here that would need updating: https://wikitech.wikimedia.org/wiki/MariaDB/monitoring
[04:32:32] <ori>	 is thumb.php used in wmf prod or does thumbor obviate its use completely?
[04:32:48] <Krinkle>	 ori: on private wikis thumb.php proxies to thumbor I believe.
[04:33:14] <Krinkle>	 beyond that, afaik we don't have any internal traffic to thumb.php, e.g. no more 404 upload.wm.o -> localwiki thumb.php like we used to.
[04:33:36] <Krinkle>	 proxying is done from PHP, after handling credentials
[04:33:52] <ori>	 ack, thanks
[15:48:59] <ori>	 Krinkle: https://gerrit.wikimedia.org/r/c/performance/WikimediaDebug/+/816218 should be good to go. Would you be able to cut a new release with it? I don't think I have access to publish the Firefox addon anymore.
[16:59:59] <Krinkle>	 AaronSchulz: js version of our getWithSet idiom :) https://gerrit.wikimedia.org/r/c/performance/WikimediaDebug/+/806291/3/background.js
[18:55:17] <ori>	 Krinkle: since the cached value doesn't persist longer than the browser, maybe it would be simpler to just memory.set(key, entry); setTimeout(() => memory.delete(key), ttl*1000);
[21:27:11] <Krinkle>	 ori: looks like you are still in the google group for chrome store at least: https://groups.google.com/u/2/g/chrome-wikimedia-debug/about
[21:27:38] <Krinkle>	 but docs in the README, and happy to review a changelog/version commit as well. 
[21:27:56] <Krinkle>	 will do a release one way or the other soon for the php74 button
[21:28:14] <Krinkle>	 https://wikitech.wikimedia.org/wiki/Performance/Runbook/WikimediaDebug
[23:03:38] <ori>	 Yeah, I saw the instructions, and I am in the Chrome group, but not Firefox AFAICT