[01:39:57] TimStarling: is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/828652 good to merge now ? [19:04:14] Hey AaronSchulz are you still the maintainer of FlaggedRevisions? I am a bit stuck with this UBN bug: https://phabricator.wikimedia.org/T316947 [19:04:29] Saw you listed on https://www.mediawiki.org/wiki/Developers/Maintainers [19:04:37] Was wondering if you can meet with Subbu and I to chat about this today. [19:28:29] I don't think we have information here beyond general analysis of current code that Subbu and you would find. The code hasn't changed recently from what I can tell. Though if local repro shows it working on an earlier version, that would narrow it down. At this point, I assume a change occurred in the TOC related code in code or skin, and during development a caller or contract was missed in Codesearch which could be patched and reviewed [19:28:29] in-team as with other unowned code. [20:01:35] The FlaggedRevisions extension seems to override the parser for a "stable version" but Subbu and I have no idea how as we don't understand the extension. We can look at this ourselves, but we were hoping rather than us spending several hours working this out we could short circuit this with a 30 minute chat from someone who actually understands the extension/. [20:03:20] Jdlrobson I managed to repro this locally on dev set up just now. I can confirm this is only the case when flaggedrevs is enabled, and doesn't show up when an explicit oldid param is present. [20:06:11] subbu: are you using Vagrant to setup flaggedrevs or vanilla MediaWiki? [20:06:21] vanilla [20:06:23] I've been having trouble getting it working locally with a vanilla MW [20:06:27] What configuration are you using? [20:06:58] maybe we can get on google meet and look at this? [20:11:04] and, looks like this has always been broken and not a new breakage as far as I can tell .. in an attempt to bisect, I was trying to find a "good" revision. so, maybe we just debug this assuming this has *always* been broken with flaggedrevs. [20:12:22] subbu:we have a slot in 1hr 30m [20:12:40] okay, lets sync then. [20:13:13] Sounds like matmarex has an idea about what's going on too [20:13:20] great! [20:13:25] once we've got a sense of what the fix is we can work out how to do it [20:34:51] Okay looks like we've figured this out on Slack with help from ladsgroup. [20:55:44] AaronSchulz: Also, I suggest removing your name from https://www.mediawiki.org/wiki/Developers/Maintainers if it's not appropriate and you don't want to be bothered about FlaggedRevs again. [20:56:07] This list is used pretty religiously by product team in these kind of emergencies. [22:46:55] "quick, does anyone know Unassigned's e-mail address?"