[17:06:12] Hi there. We (the moderator tools team) have been working up a patch that adds a hook to core (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/833471). Things are looking pretty good, but the fresnel job in jenkins (https://integration.wikimedia.org/ci/job/mediawiki-fresnel-patch-docker/60011/consoleFull) is consistently dumping a stack trace on [17:06:12] one of the runs when the autoloader hits our hook (https://integration.wikimedia.org/ci/job/mediawiki-fresnel-patch-docker/59986/artifact/log/fresnel_records/before/scenario-View%20history%20of%20a%20page-run-6/screenshot--image.png). This *seems* like a CI bug to me (which I'd be happy to document in phab), but just wanted to check and see if [17:06:13] we're overlooking something important that might cause problems in production. Could y'all have a look? [17:16:17] Actually, the more I look at this the more confident I am that it is a bug. The error is getting thrown in the "before" stage, which shouldn't be trying to load the new hook at all, right? [20:33:35] JSherman: do you need to run maintenance/generateLocalAutoload.php to update autoload.php? [20:35:30] looks like I disconnected and a message didn't post: [20:35:30] > JSherman 13:26:50 [20:35:31] I went ahead and +2ed this since all the blocking ci checks pass, but I'm happy to followup with a bug report if this doesn't throw errors in production. [20:36:32] ori: we ran it and it and the hook is properly referenced. I actually tried relocating the hook in another request to double check and I ran into the same issue [20:37:39] I wouldn't expect it to try to load our new hook at all in the "before" peformance check. Shouldn't that be a clean checkout of master? [20:44:04] where do you see that the error came from the "before" check? [20:47:47] I do think you need to add the class to autoload.php, but I'm not sure why none of the other CI jobs failed. [20:49:25] That dir should be autoloaded due to namespacing... [20:49:32] in the before fresnel record in the build artifacts. Consistently happens on run 6 of recent changes: [20:49:33] https://integration.wikimedia.org/ci/job/mediawiki-fresnel-patch-docker/60011/artifact/log/fresnel_records/before/scenario-View%20recent%20changes-run-6/ [20:50:39] huh. weird. dunno, then. [20:52:00] Reedy: yeah, it looks to me (a completely uniformed outsider) like our updated directory reference is present in the "before" autoloader, but our new hook isn't there, because it shouldn't be? My question is why does the autoloader look for my new hook in the before run? [20:54:13] It sounds like a messed up working copy (or opcache?) for some reason [20:55:59] That is my thinking as well. It seems like the state is dirty. This is passing in all the other checks, and so far nothing has gotten angry after +2ing the patch, so I'll go ahead and file a bug. [20:56:07] I was going to say the same [20:56:26] File a bug for the fresnel test issue, and don't lose any sleep over the rest of it if the patch is working in voting CI :) [20:58:09] ack; wilco. thanks!