[00:34:30] <AaronSchulz>	 TimStarling: do you mind looking at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/784756 ?
[02:25:16] <AaronSchulz>	 Krinkle: is there a task about xhprof percentiles being messed up?
[02:25:28] <AaronSchulz>	 *percentages
[02:33:04] * AaronSchulz looks at https://phabricator.wikimedia.org/T247332
[02:37:27] <Krinkle>	 AaronSchulz: yes... are they still messed somewhere?
[02:37:46] <AaronSchulz>	 on my test wiki, yes
[02:37:50] <AaronSchulz>	 cli/web
[02:38:01] <Krinkle>	 Probably too many start calls
[02:38:38] <Krinkle>	 https://www.mediawiki.org/wiki/MediaWiki-Docker/Configuration_recipes/Profiling
[02:39:04] <Krinkle>	 Either don't start as this snippet, or start early like prod and tell wgProf that it's already running
[02:39:16] * Krinkle off now
[02:40:10] <AaronSchulz>	 I was using something like that (and only enable call)
[02:40:26] <AaronSchulz>	 I'm trying autoprepend now
[03:10:53] <AaronSchulz>	 custom autoprepend seems to work
[18:41:31] <Krinkle>	 AaronSchulz: even one enable call will be too many in LocalSettings given Mw starts it on its own during Setup already
[18:41:38] <Krinkle>	 Unless running=true is given
[18:42:04] <AaronSchulz>	 Krinkle: I added a var_dump() and only saw one call
[18:42:12] <Krinkle>	 But yeah auto prepend + wgProfiler running =true will work too
[18:42:15] <AaronSchulz>	 the only fix it to use prepend
[18:42:50] <AaronSchulz>	 maybe something about autoloading that confuses it (main() has 6us and autoload 66ms)
[18:42:55] <Krinkle>	 Works fine without auto prepend locally. I set up wgProfiler and let Mw start it.
[18:43:09] <Krinkle>	 And then profiler output text
[18:43:40] <AaronSchulz>	 I'm using php 8.1.2 with jit enabled btw
[18:43:47] <Krinkle>	 There will only be one enable call from Profiler.php but I mean native tideways if you call that directly then Mw will not know not to call it again
[18:44:02] <Krinkle>	 Unless running=true is given
[18:52:20] <AaronSchulz>	 I wasn't calling it natively either. I am now, since I use autoprepend and running=true. But stock profiling without autoprepend gives garbage numbers on all my computers.
[18:52:26] <AaronSchulz>	 (cli and web mode)
[18:57:28] <Krinkle>	 Ok. Is that with shutdown handler or profile output?
[18:57:40] <Krinkle>	 Could be a php 8 issue
[18:57:53] <Krinkle>	 Haven't tried on that yet
[18:58:10] <Krinkle>	 Worth filing a bug for perhaps. Should I definitely work
[23:37:27] <AaronSchulz>	 Krinkle: is https://gerrit.wikimedia.org/r/c/mediawiki/core/+/842883 supposed to be for 1.39 or 1.40?