[20:58:55] TimStarling: I'm reviewing https://gerrit.wikimedia.org/r/c/mediawiki/php/excimer/+/876032/ and as part of it looking to better understand the surrounding code. so If I understand correctly, the frame entries is basically a list of frame objects by reference, and in case of stacks that involve the same function mutiple times, it actually re-uses the same frame by reference so the list potentially contains the same exact same frame object [20:58:55] multiple times, is that right? [20:59:47] if correct - is it expected to be possible/needed that it finds the truncation marker after it added it? I don't mind it being there just in case, but I'm not seeing how it's possible. [21:54:11] Ah, it's Saturday there, right. [23:04:33] Timezones!