[00:21:06] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/876059/ [00:21:12] ^ REL1_39 patch [00:21:12] https://integration.wikimedia.org/ci/job/mediawiki-core-php74-phan-docker/5091/console [00:21:18] 00:06:47 includes/profiler/ProfilerExcimer.php:81 PhanTypeMismatchArgumentInternal Argument 1 ($array) is ($realStats + $cpuStats) of type float|int but \array_keys() takes array [00:21:18] 00:06:47 includes/profiler/ProfilerExcimer.php:136 PhanTypeMismatchArgumentInternal Argument 1 ($array) is ($cpuStats + $realStats) of type float|int but \array_keys() takes array [00:21:46] Do we need to backport something from master? [00:22:17] Guessing it's possibly related to patches to Eximer itself? [00:23:20] Yup, a83f630d637d6217d93bc057d0d177841d3cde38 [05:38:47] Krinkle: the frame struct includes prev_index, and so does the hashtable key, so if the same function is in a stack multiple times, each time will have a different prev_index and hence a different object [05:39:31] the first thing excimer_log_find_or_add_frame() does is recursively traverse the whole linked list of frames [22:29:39] Reedy: moving php-cssjanus to mediawiki/libs/ now [22:29:54] all my hard work!!!!! [22:30:23] Want me to remove the github action commits and push again so the rest can be merged? [22:30:56] if it's not blocked on php8.2/phan, then sure, I vaguely sense you didnt want to merge it yet either way [22:31:38] tests won't pass on PHP 8.2, but that's not going to change on gerrit or github [22:31:49] ack [22:36:06] Done and merged [22:53:05] Reedy: I'm thinking maybe also to move it on packagist (I had already moved the source repo on the github side a few months ago) [22:53:27] to have wikimedia in the name, seems good, but not sure how much work that is or if its maybe too disruptive [22:53:35] I think we've done it for a few libs from mediawiki>wikimedia right? [22:54:17] Not for a while [22:55:57] I don't think it's much work though... [22:56:14] Some people get irked when packages show as abandoned etc in composer commands