[01:53:58] Krinkle: Thanks! [01:54:05] yw [01:55:24] AaronSchulz: one unresolved comment left at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/822201/3/includes/cache/LinkCache.php#424 - not sure if you want to use false there after all (might more clearly/strongly indicate evidence of absence) or to update the docs instead. [02:01:08] James_F is too fast for second thoughts [02:01:49] I thought I'd better add a test case to that bug fix I just uploaded -- got it up there a few seconds before James_F hit +2 [02:02:18] TimStarling: Ha. [02:02:36] you'll need to reapply your +2 to PS4 [02:02:42] TimStarling: Ack. [02:02:55] The REL1_40 branch is in ~58 minutes' time. [02:02:57] So… [02:03:34] and gate takes about 17 minutes? [02:03:52] Yeah, I wanted to get on with it. :-) [02:04:03] * James_F re-tests. [02:09:33] Oh, wait, Daylight Confusion Time. I should have branched it a few minutes ago. [02:09:38] Oh well, I'll wait for it to land. [02:17:28] Krinkle: Is https://gerrit.wikimedia.org/r/c/mediawiki/core/+/894238 good to merge? Your new test now passes? [02:17:42] ack, go ahead [02:47:10] TimStarling: filed request for DBA ref T331956, took a brief look at enabling php on perfsite, seems there's multiple different patterns in different puppet modules for how to do that. E.g. some use mod_php (like xhgui, fairly easy) and others php-fpm that might require a bit more provision logic. Our sre contact for this server is now o11y, so if we don't have a preference could also ask them. [02:47:10] T331956: Create "excimer" misc database - https://phabricator.wikimedia.org/T331956