[18:34:12] <cdanis>	 Krinkle: lol... do comment lines 'count' for code coverage?
[18:34:28] <Krinkle>	 cdanis: I don't think so.
[18:34:44] <cdanis>	 so why is it failing now?
[18:34:48] <Krinkle>	 context?
[18:35:46] <cdanis>	 oh sorry -- https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1061574
[18:36:36] <Krinkle>	 https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-patch/79549/console
[18:36:39] <Krinkle>	 In CloverXml.php line 69:
[18:36:39] <Krinkle>	                                      
[18:36:39] <Krinkle>	   String could not be parsed as XML  
[18:36:39] <Krinkle>	                                      
[18:36:47] <cdanis>	 heh
[18:36:51] <cdanis>	 got it
[18:36:56] <Krinkle>	 gerrit comment = status === failure ? down : same or up.
[18:37:15] <cdanis>	 the gerrit comment sounded so definitive
[18:37:45] <Krinkle>	 https://gerrit.wikimedia.org/g/integration/config/+/21e7a3eda2f46d1a26007eec2ae35f6df379ed55/zuul/layout.yaml#692
[18:37:48] <Krinkle>	 Yeah :D
[18:38:01] <Krinkle>	 the other jobs will also fail in a minute
[18:38:05] <Krinkle>	 (probably)
[18:38:08] <Krinkle>	 which will make it stand out less
[18:38:17] <Krinkle>	 but because it's one of the fastest jobs, it's confusing until then.
[18:38:22] <cdanis>	 ack
[18:38:38] <cdanis>	 so, CI failures aside, is this patch LGTM to you now?
[18:39:12] <cdanis>	 your edit is good with me :)
[18:39:33] <Krinkle>	 I believe piotr is finishing the review today or tomorrow.
[18:39:42] <cdanis>	 oh, cool, ty
[18:39:46] <Krinkle>	 yw
[18:40:33] <Krinkle>	 cdanis: could you help me with https://gerrit.wikimedia.org/r/c/operations/puppet/+/1097459 ?
[18:40:50] <Krinkle>	 antoine and I tried out the rename repo feature in Gerrit, but scap is 404'ing on the deployment server now :D
[18:41:12] <Krinkle>	 lesson for next time: prepare puppet and SRE ahead of time
[18:41:24] <cdanis>	 ahh
[18:41:26] <cdanis>	 yes, can do
[18:43:30] <cdanis>	 Krinkle: merged and puppet-merged, and running puppet on deploy2002 now
[18:45:47] <Krinkle>	 thx!
[18:48:20] <cdanis>	 done