[09:24:45] hashar: I'm out next week, but if you want to try the Apache rollout today, i'll still have today/tomorrow/Friday to help with fixing Selenium tests [09:25:04] we could also leave it for January [09:25:08] kostajh: I don't think I will be able to make it :\ [09:25:16] no problem [09:25:29] I had a look at the quibble dockerfiles on monday and it is a bit of a mess to vary the version with php-fpm [09:26:02] where I left of is that if we run selenium test solely with the php72 image, we are already set [09:26:16] since the image for it is ready [09:27:08] but we run selenium tests with 7.3 and 7.4 :-\ [09:27:43] I am half tempted to craft a multi php versions image and lets one switch from one to another using an environment variable [09:27:51] that is where I am with my thinking about the problem [09:40:29] hmm, why do we run the Selenium tests with 7.3 and 7.4? Presumably if something doesn't work in PHP 7.3 / 7.4, it is already caught by integration/unit tests [10:30:53] possibly yeah [10:31:08] or some extensions do not support 7.2 anymore [10:31:54] ah yeah that is for REL1_35 and later [10:32:06] we have dropped 7.2 support from the rel branches [10:32:19] but keep it for master/wmf branches since we run 7.2 on production [10:32:45] anyway [10:33:04] I had issue with `docker-pkg` which I managed to fix up. The config.yaml requires a seed_image to be set [10:36:00] I guess I will try to craft something [10:37:22] ok, no rush though. [10:40:30] notably the config files for php-fpm refers to a specific version of php such as /etc/php/7.2/fpm [10:40:43] and I wanted to somehow avoid copy pasting [10:41:18] which maybe can be done with some symbolic linking after installing the php package [10:41:31] like /etc/php/selected-version/fpm [11:00:04] 10Quibble, 10Continuous-Integration-Config: Switch all Quibble Selenium jobs to use apache - https://phabricator.wikimedia.org/T285649 (10kostajh) Another thing that will reduce the risk of this change is to roll out {T296826} to extensions/skins first; this will retry a failed test in the event of a failure. [11:41:40] hashar: btw I wrote a post about Selenium + CI https://www.kostaharlan.net/posts/wikimedia-selenium/ [11:47:51] (03PS5) 10Kosta Harlan: BrowserTests: Option to run npm install in parallel [integration/quibble] - 10https://gerrit.wikimedia.org/r/738061 (https://phabricator.wikimedia.org/T226869) [12:17:10] kostajh: +1 nice analysis :] [14:43:49] 10Quibble, 10Continuous-Integration-Config: Switch all Quibble Selenium jobs to use apache - https://phabricator.wikimedia.org/T285649 (10awight) >>! In T285649#7563424, @kostajh wrote: > Sounds good. Let me know how I can help. @awight will you be around? Yes, I'll be around this week and next. Great to see... [16:58:25] 10Quibble, 10Continuous-Integration-Config: Switch all Quibble Selenium jobs to use apache - https://phabricator.wikimedia.org/T285649 (10hashar) I had a side track with `docker-pkg` (`seed_images` must be set in the config [[ https://gerrit.wikimedia.org/r/c/operations/docker-images/docker-pkg/+/747060 | Gerr... [17:05:35] those quibble apache images give me headhaches when it comes to support multiple php versions :\ [22:02:00] (03PS1) 10Kosta Harlan: Add phpcs stage [integration/quibble] - 10https://gerrit.wikimedia.org/r/747617 (https://phabricator.wikimedia.org/T297561) [22:02:31] 10Quibble, 10Continuous-Integration-Infrastructure, 10Continuous-Integration-Config, 10Patch-For-Review: Run linters before starting longer running jobs - https://phabricator.wikimedia.org/T297561 (10kostajh) > steps 2-3 could be done entirely in Quibble, but having as a service seems useful for other tool... [22:02:52] (03CR) 10Kosta Harlan: "I could use help figuring out how to fix the unit test complaining about requests not being found." [integration/quibble] - 10https://gerrit.wikimedia.org/r/747617 (https://phabricator.wikimedia.org/T297561) (owner: 10Kosta Harlan) [22:05:23] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs stage [integration/quibble] - 10https://gerrit.wikimedia.org/r/747617 (https://phabricator.wikimedia.org/T297561) (owner: 10Kosta Harlan)