[09:59:23] hashar: I bumped the retry limit for api-testing to 3 attempts, and that seems to have gotten it to pass https://gerrit.wikimedia.org/r/c/mediawiki/core/+/751997 [10:36:41] kostajh: I assume cause that consumes the DeferredUpdate queue [10:36:49] yeah [10:37:00] it's making assumptions about what is in RecentChanges [10:37:01] I think as a part of api-testing introduction we have added support to force run the job queue [10:37:50] in wdio, there is support for `browser.waitUntil()`; I don't think there is an equivalent in mocha/supertest but it would be nice to have some utility like that, where the code could wait until recentChanges has the expected result, retrying every N seconds or whatever [10:37:54] $wgSecretKey = 'supercalifragilisticexpialidocious'; [10:38:52] and the api testing framework as a lib/wiki.js runJobs() function [10:39:01] which should be used rather than blindly retrying ;) [10:40:24] sure, although I'd rather have the retry there for now as i suspect lots of jobs are failing, then have another patch that removes `--retries` where we can work out how to fix each individual test [10:50:34] kostajh: I posted a comment [10:50:49] const { wiki } = require('api-testing'); // XXX I don't know how to get just one export [10:50:50] await wiki.runAllJobs(); [10:50:54] that might do it [10:51:06] api-testing index.js has an export for several modules [10:51:16] but I don't know how in nodejs I could get just the "wiki" one [10:51:25] so the require line is probably wrong [10:52:22] ah https://phabricator.wikimedia.org/T231822 was the task [10:52:38] which got us to add the $wgSecretKey in order for test suite to be able to run jobs [10:58:02] I don't know anything about js :-\ I really need to train myself [12:15:37] hashar: fixed as you suggested :) [12:15:50] yeah sorry [12:15:54] the retries might have worked [12:16:04] but that felt more like a workaround ;D [12:16:23] I cant remember how deferredupdates are handled in phpunit [12:16:31] ideally the jobs would have to be expliitly run by the test [12:20:09] kostajh: +2